587ff2cf47
Publish snapshot / snapshot (push) Failing after 1m58s
Publishing infrastructure - Three Gitea workflows: ci.yml (PRs, non-main pushes), publish-snapshot.yml (main -> Gitea under dist-tag @main) and release.yml (tags -> Gitea + npmjs) - Tag-driven releases as <package-dir>-v<version>; the manifest stays the source of truth and release.yml refuses to run if tag and manifest disagree - Every publish is idempotent: each step checks the registry first, so a run that fails on the second registry can simply be re-run - Hard coverage gate (85% branches) shared by CI, the pre-push hook and local runs, since the thresholds live in vitest.config.ts rather than a CI flag - README.PUBLISH.md documents the whole mechanism Toolchain - TypeScript 7 native compiler; drop tsgo and ts-node, use tsx for dev runs - Biome 1.9 -> 2.x, Vitest 1 -> 4, zod 3 -> 4, inquirer 8 -> 14, pnpm 11.17.0 - Replace inquirer-checkbox-plus-prompt, which is peer-capped at inquirer <9, with enquirer's AutoComplete; the CubeSelection contract is unchanged - Stand in for zod 4's removed z.AnyZodObject with a local AnyObjectSchema Repo hygiene - Stop tracking dist/; ignore coverage/, *.tsbuildinfo, .npmrc* and release.json - Drop package-lock.json in favour of pnpm-lock.yaml Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
185 lines
6.1 KiB
TypeScript
185 lines
6.1 KiB
TypeScript
/**
|
|
* Error and discovery edge cases for cubes/loader.
|
|
*
|
|
* Runs against a real temp directory because loadCubes() dynamically imports
|
|
* manifest files — there is no seam worth faking here.
|
|
*/
|
|
|
|
import fs from 'node:fs';
|
|
import os from 'node:os';
|
|
import path from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import { findCubeDirectories, getCube, loadCubes } from '../src/cubes/loader.js';
|
|
|
|
describe('loader edge cases', () => {
|
|
let originalCwd: string;
|
|
let originalHome: string | undefined;
|
|
let tmpDir: string;
|
|
let emptyHome: string;
|
|
|
|
const cube = (dir: string, manifest: string, deployName = 'deploy.py') => {
|
|
fs.mkdirSync(path.join(tmpDir, dir), { recursive: true });
|
|
fs.writeFileSync(path.join(tmpDir, dir, 'manifest.mjs'), manifest);
|
|
fs.writeFileSync(path.join(tmpDir, dir, deployName), '# deploy');
|
|
};
|
|
|
|
beforeEach(() => {
|
|
originalCwd = process.cwd();
|
|
originalHome = process.env.HOME;
|
|
tmpDir = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'nopy-loader-')));
|
|
emptyHome = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'nopy-loader-home-')));
|
|
process.env.HOME = emptyHome;
|
|
process.chdir(tmpDir);
|
|
fs.writeFileSync(path.join(tmpDir, '.nopyrc.json'), JSON.stringify({ cubeDirs: ['./'] }));
|
|
});
|
|
|
|
afterEach(() => {
|
|
process.chdir(originalCwd);
|
|
if (originalHome === undefined) {
|
|
delete process.env.HOME;
|
|
} else {
|
|
process.env.HOME = originalHome;
|
|
}
|
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
|
fs.rmSync(emptyHome, { recursive: true, force: true });
|
|
});
|
|
|
|
describe('findCubeDirectories', () => {
|
|
it('includes directories from cubeDirs', () => {
|
|
expect(findCubeDirectories()).toContain(tmpDir);
|
|
});
|
|
|
|
it('includes directories marked with a .npcubes file', () => {
|
|
fs.writeFileSync(path.join(tmpDir, '.nopyrc.json'), JSON.stringify({ cubeDirs: [] }));
|
|
fs.writeFileSync(path.join(tmpDir, '.npcubes'), '');
|
|
const nested = path.join(tmpDir, 'a', 'b');
|
|
fs.mkdirSync(nested, { recursive: true });
|
|
process.chdir(nested);
|
|
|
|
expect(findCubeDirectories()).toContain(tmpDir);
|
|
});
|
|
|
|
it('does not treat a .npcubes directory as a marker', () => {
|
|
fs.writeFileSync(path.join(tmpDir, '.nopyrc.json'), JSON.stringify({ cubeDirs: [] }));
|
|
fs.mkdirSync(path.join(tmpDir, '.npcubes'));
|
|
|
|
expect(findCubeDirectories()).not.toContain(tmpDir);
|
|
});
|
|
|
|
it('de-duplicates a directory listed twice', () => {
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.nopyrc.json'),
|
|
JSON.stringify({ cubeDirs: ['./', tmpDir] })
|
|
);
|
|
fs.writeFileSync(path.join(tmpDir, '.npcubes'), '');
|
|
|
|
expect(findCubeDirectories().filter((d) => d === tmpDir)).toHaveLength(1);
|
|
});
|
|
});
|
|
|
|
describe('loadCubes', () => {
|
|
it('derives the id from a [bracket] name prefix', async () => {
|
|
cube('bracketed', 'export default { name: "[apt:base] Apt Base" }');
|
|
|
|
const { cubes, errors } = await loadCubes();
|
|
|
|
expect(errors).toEqual([]);
|
|
expect(cubes['apt:base'].name).toBe('[apt:base] Apt Base');
|
|
});
|
|
|
|
it('falls back to the directory name when no id is derivable', async () => {
|
|
cube('fallback-id', 'export default { name: "No Id Here" }');
|
|
|
|
const { cubes } = await loadCubes();
|
|
|
|
expect(cubes['fallback-id']).toBeDefined();
|
|
});
|
|
|
|
it('defaults the schema when the manifest omits one', async () => {
|
|
cube('no-schema', 'export default { id: "no-schema", name: "No Schema" }');
|
|
|
|
const { cubes } = await loadCubes();
|
|
|
|
expect(cubes['no-schema'].getDefaults()).toEqual({});
|
|
});
|
|
|
|
it('reports a manifest whose default export is not an object', async () => {
|
|
cube('bad-export', 'export default "just a string"');
|
|
|
|
const { cubes, errors } = await loadCubes();
|
|
|
|
expect(cubes['bad-export']).toBeUndefined();
|
|
expect(errors[0]).toMatch(/Invalid manifest export/);
|
|
});
|
|
|
|
it('reports a manifest with no default export', async () => {
|
|
cube('no-export', 'export const nothing = 1;');
|
|
|
|
const { errors } = await loadCubes();
|
|
|
|
expect(errors[0]).toMatch(/Invalid manifest export/);
|
|
});
|
|
|
|
it('reports a manifest missing a name', async () => {
|
|
cube('no-name', 'export default { id: "no-name" }');
|
|
|
|
const { errors } = await loadCubes();
|
|
|
|
expect(errors[0]).toMatch(/missing 'name'/);
|
|
});
|
|
|
|
it('reports a manifest that fails to import', async () => {
|
|
cube('broken', 'this is not valid javascript !!!');
|
|
|
|
const { errors } = await loadCubes();
|
|
|
|
expect(errors[0]).toMatch(/Failed to load manifest/);
|
|
});
|
|
|
|
it('reports duplicate cube ids', async () => {
|
|
cube('first', 'export default { id: "dup", name: "First" }');
|
|
cube('second', 'export default { id: "dup", name: "Second" }');
|
|
|
|
const { cubes, errors } = await loadCubes();
|
|
|
|
expect(Object.keys(cubes)).toEqual(['dup']);
|
|
expect(errors[0]).toMatch(/Duplicate cube id 'dup'/);
|
|
});
|
|
|
|
it('skips hidden and node_modules directories', async () => {
|
|
cube('.hidden/inner', 'export default { id: "hidden", name: "Hidden" }');
|
|
cube('node_modules/pkg', 'export default { id: "vendored", name: "Vendored" }');
|
|
cube('visible', 'export default { id: "visible", name: "Visible" }');
|
|
|
|
const { cubes } = await loadCubes();
|
|
|
|
expect(Object.keys(cubes)).toEqual(['visible']);
|
|
});
|
|
|
|
it('ignores configured cube directories that do not exist', async () => {
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.nopyrc.json'),
|
|
JSON.stringify({ cubeDirs: ['./', './does-not-exist'] })
|
|
);
|
|
cube('visible', 'export default { id: "visible", name: "Visible" }');
|
|
|
|
const { cubes, errors } = await loadCubes();
|
|
|
|
expect(errors).toEqual([]);
|
|
expect(cubes.visible).toBeDefined();
|
|
});
|
|
});
|
|
|
|
describe('getCube', () => {
|
|
it('returns a single cube by id', async () => {
|
|
cube('one', 'export default { id: "one", name: "One" }');
|
|
|
|
await expect(getCube('one')).resolves.toMatchObject({ id: 'one' });
|
|
});
|
|
|
|
it('returns undefined for an unknown id', async () => {
|
|
await expect(getCube('nope')).resolves.toBeUndefined();
|
|
});
|
|
});
|
|
});
|