mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
Builds on the COD-37 registry: surfaces detected/registered attachments as dismissible cards with a first-page thumbnail and an inline preview — the consumer the registry PR deliberately deferred. Backend: - document-thumbnailer: first-page PNG thumbnails (PNG passthrough; PDF via pdftoppm; Office via the preview cache). - document-preview-cache: disk-cached DOCX/PPTX -> PDF conversion (LibreOffice / PowerShell COM), in-flight dedup, multi-converter fallback. - file-routes: serveConvertedPreview / serveThumbnail + four routes — GET .../attachments/:id/preview, .../thumbnail and the workspace-path file-preview / file-thumbnail. Reuses the registry's TOCTOU-safe resolveServableAttachmentPath, so previews stream the freshly-resolved path. - server: enrich detected attachment events with a thumbnail route. - image-watcher: .png now routes to attachment:detected — this PR adds the card consumer, so the screenshot popup is no longer its only handler. Frontend: - panels-ui: attachment cards (addAttachmentCard, lazy stack, Clear-all, per-session cleanup) plus a 3-arg openFilePreview that renders registered attachments inline (image/PDF) or via the server-converted PDF (docx/pptx). - app.js: wire attachment:detected -> _onAttachmentDetected and card state. - styles: attachment-card + stack styling. Verified: tsc / eslint / prettier / frontend-syntax clean; new thumbnailer + preview-cache unit tests pass; full test:ci green (2861 passed); card render + preview overlay + dismiss verified in-browser.
110 lines
3.8 KiB
TypeScript
110 lines
3.8 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import { execFile } from 'node:child_process';
|
|
import fs from 'node:fs/promises';
|
|
import { clearDocumentPreviewCache, getOfficePreviewPdfPath } from '../src/document-preview-cache.js';
|
|
|
|
vi.mock('node:child_process', () => ({
|
|
execFile: vi.fn((_cmd, _args, _options, callback) => {
|
|
setTimeout(() => callback(null, { stdout: '', stderr: '' }), 1);
|
|
return {};
|
|
}),
|
|
}));
|
|
|
|
vi.mock('node:fs/promises', () => ({
|
|
default: {
|
|
stat: vi.fn(),
|
|
mkdir: vi.fn(async () => undefined),
|
|
copyFile: vi.fn(async () => undefined),
|
|
mkdtemp: vi.fn(async () => '/tmp/codeman-document-preview-cache/work-test'),
|
|
readdir: vi.fn(async () => ['deck.pdf']),
|
|
rename: vi.fn(async () => undefined),
|
|
rm: vi.fn(async () => undefined),
|
|
},
|
|
}));
|
|
|
|
const mockedExecFile = vi.mocked(execFile);
|
|
const mockedStat = vi.mocked(fs.stat);
|
|
const mockedRename = vi.mocked(fs.rename);
|
|
|
|
describe('document-preview-cache', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
clearDocumentPreviewCache();
|
|
|
|
let cachedPdfExists = false;
|
|
mockedStat.mockImplementation(async (path) => {
|
|
const pathText = String(path);
|
|
if (pathText.includes('codeman-document-preview-cache') && pathText.endsWith('.pdf')) {
|
|
if (!cachedPdfExists) throw new Error('ENOENT');
|
|
return { size: 4096, isFile: () => true } as never;
|
|
}
|
|
|
|
return { size: 1845494, mtimeMs: 12345, isFile: () => true } as never;
|
|
});
|
|
mockedRename.mockImplementation(async () => {
|
|
cachedPdfExists = true;
|
|
});
|
|
mockedExecFile.mockImplementation((cmd, _args, _options, callback) => {
|
|
if (cmd === 'powershell.exe') {
|
|
cachedPdfExists = true;
|
|
}
|
|
|
|
setTimeout(() => callback(null, { stdout: '', stderr: '' }), 1);
|
|
return {} as never;
|
|
});
|
|
});
|
|
|
|
it('deduplicates concurrent Office preview conversions and reuses the cached PDF', async () => {
|
|
const [firstPath, secondPath] = await Promise.all([
|
|
getOfficePreviewPdfPath('/tmp/deck.pptx', 'pptx'),
|
|
getOfficePreviewPdfPath('/tmp/deck.pptx', 'pptx'),
|
|
]);
|
|
const thirdPath = await getOfficePreviewPdfPath('/tmp/deck.pptx', 'pptx');
|
|
|
|
expect(firstPath).toBeTruthy();
|
|
expect(secondPath).toBe(firstPath);
|
|
expect(thirdPath).toBe(firstPath);
|
|
expect(mockedExecFile).toHaveBeenCalledTimes(1);
|
|
expect(mockedExecFile).toHaveBeenCalledWith(
|
|
'soffice',
|
|
expect.arrayContaining([
|
|
'--headless',
|
|
'--convert-to',
|
|
'pdf',
|
|
expect.stringMatching(/^-env:UserInstallation=file:/),
|
|
]),
|
|
expect.any(Object),
|
|
expect.any(Function)
|
|
);
|
|
});
|
|
|
|
it('prefers Microsoft Word for DOCX files on Windows-mounted paths', async () => {
|
|
const result = await getOfficePreviewPdfPath(
|
|
'/mnt/c/Users/aakhter/Documents/codeman-inline-viewer-test.docx',
|
|
'docx'
|
|
);
|
|
|
|
expect(result).toContain('/mnt/c/Users/aakhter/AppData/Local/Temp/codeman-document-preview-cache/');
|
|
expect(mockedExecFile).toHaveBeenCalledWith(
|
|
'powershell.exe',
|
|
expect.arrayContaining(['-NoProfile', '-NonInteractive', '-EncodedCommand']),
|
|
expect.any(Object),
|
|
expect.any(Function)
|
|
);
|
|
const powerShellCall = mockedExecFile.mock.calls.find(([cmd]) => cmd === 'powershell.exe');
|
|
const encodedCommand = powerShellCall?.[1]?.at(-1);
|
|
const decodedCommand = Buffer.from(String(encodedCommand), 'base64').toString('utf16le');
|
|
expect(decodedCommand).toContain('$source = ');
|
|
expect(decodedCommand).toContain('C:\\Users\\aakhter\\AppData\\Local\\Temp\\codeman-document-preview-cache\\');
|
|
expect(decodedCommand).toContain('.docx');
|
|
expect(decodedCommand).toContain('$output = ');
|
|
expect(decodedCommand).toContain('.pdf');
|
|
expect(mockedExecFile).not.toHaveBeenCalledWith(
|
|
'soffice',
|
|
expect.any(Array),
|
|
expect.any(Object),
|
|
expect.any(Function)
|
|
);
|
|
});
|
|
});
|