mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-10-03 05:59:43 +02:00
* fix(test): share route error handler with test harness + fix stale assertions
The route test harness built a bare Fastify instance without the production
global error handler (server.ts), so structured errors thrown by route helpers
(findSessionOrFail → 404, parseBody → 400) fell through to Fastify's default
handler — yielding a `{statusCode,error,message}` body instead of the
`{success:false,...}` shape, and the tests asserted the old implicit-200
behavior. 51 route tests across 7 files were red.
- Extract the handler into src/web/route-error-handler.ts; server.ts and the
test harness now install the identical handler (single source of truth).
- Correct stale assertions across route test files: throw-based error paths
now assert 404 (unknown session) / 400 (invalid body); genuine in-handler
`return createErrorResponse(...)` paths (200 + success:false) left untouched.
- Reformat a few test files prettier flagged (pre-existing non-compliance).
Route suite: 307/307 passing (was 256/307). No production behavior change.
* test(respawn): mock child_process so AI checker never spawns real processes
respawn-controller.test.ts drives the AI idle checker (ai-checker-base), whose
runCheck() spawns a real `tmux new-session` running `claude -p`. The AI-enabled
tests only assert the ai_checking state transition (then cancel/stop), so the
spawn produced stray real tmux sessions and claude processes on every run — the
reason `npm test` (full suite) was unsafe to run inside a managed session.
Mock node:child_process here (mirroring ai-idle-checker.test.ts), spreading the
real module so `exec` stays intact for transitively-imported modules
(tmux-manager calls promisify(exec) at load). With this, the full non-mobile
suite runs without spawning any real tmux/claude.
---------
Co-authored-by: Teigen <teigen@TeigendeMac-mini.local>
219 lines
6.6 KiB
TypeScript
219 lines
6.6 KiB
TypeScript
/**
|
|
* @fileoverview Tests for hook-event-routes route handlers.
|
|
*
|
|
* Uses app.inject() — no real HTTP ports needed.
|
|
* Port: N/A (app.inject doesn't open ports)
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
|
|
import { createRouteTestHarness, type RouteTestHarness } from './_route-test-utils.js';
|
|
import { registerHookEventRoutes } from '../../src/web/routes/hook-event-routes.js';
|
|
|
|
describe('hook-event-routes', () => {
|
|
let harness: RouteTestHarness;
|
|
|
|
beforeEach(async () => {
|
|
harness = await createRouteTestHarness(registerHookEventRoutes);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await harness.app.close();
|
|
});
|
|
|
|
// ========== POST /api/hook-event ==========
|
|
|
|
describe('POST /api/hook-event', () => {
|
|
it('accepts a valid hook event and broadcasts it', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'stop',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: null,
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(harness.ctx.broadcast).toHaveBeenCalledWith(
|
|
'hook:stop',
|
|
expect.objectContaining({ sessionId: harness.ctx._sessionId })
|
|
);
|
|
});
|
|
|
|
it('sends push notifications for hook events', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'idle_prompt',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: null,
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
expect(harness.ctx.sendPushNotifications).toHaveBeenCalledWith(
|
|
'hook:idle_prompt',
|
|
expect.objectContaining({ sessionId: harness.ctx._sessionId })
|
|
);
|
|
});
|
|
|
|
it('returns 404 for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'stop',
|
|
sessionId: 'nonexistent-session',
|
|
data: null,
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
expect(body.error).toBeDefined();
|
|
});
|
|
|
|
it('rejects invalid event type', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'invalid_event_type',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: null,
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('rejects missing sessionId', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'stop',
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('signals respawn controller on stop event', async () => {
|
|
const mockController = {
|
|
signalStopHook: vi.fn(),
|
|
signalElicitation: vi.fn(),
|
|
signalIdlePrompt: vi.fn(),
|
|
};
|
|
harness.ctx.respawnControllers.set(harness.ctx._sessionId, mockController as never);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'stop',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: null,
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
expect(mockController.signalStopHook).toHaveBeenCalled();
|
|
});
|
|
|
|
it('signals respawn controller on elicitation_dialog event', async () => {
|
|
const mockController = {
|
|
signalStopHook: vi.fn(),
|
|
signalElicitation: vi.fn(),
|
|
signalIdlePrompt: vi.fn(),
|
|
};
|
|
harness.ctx.respawnControllers.set(harness.ctx._sessionId, mockController as never);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'elicitation_dialog',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: null,
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
expect(mockController.signalElicitation).toHaveBeenCalled();
|
|
});
|
|
|
|
it('signals respawn controller on idle_prompt event', async () => {
|
|
const mockController = {
|
|
signalStopHook: vi.fn(),
|
|
signalElicitation: vi.fn(),
|
|
signalIdlePrompt: vi.fn(),
|
|
};
|
|
harness.ctx.respawnControllers.set(harness.ctx._sessionId, mockController as never);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'idle_prompt',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: null,
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
expect(mockController.signalIdlePrompt).toHaveBeenCalled();
|
|
});
|
|
|
|
it('records hook event in run summary tracker', async () => {
|
|
const mockTracker = { recordHookEvent: vi.fn() };
|
|
harness.ctx.runSummaryTrackers.set(harness.ctx._sessionId, mockTracker as never);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'stop',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: { tool_name: 'bash' },
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
expect(mockTracker.recordHookEvent).toHaveBeenCalledWith('stop', expect.any(Object));
|
|
});
|
|
|
|
it('starts transcript watcher when transcript_path is provided', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'stop',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: { transcript_path: '/home/user/.claude/transcript.jsonl' },
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
expect(harness.ctx.startTranscriptWatcher).toHaveBeenCalledWith(
|
|
harness.ctx._sessionId,
|
|
'/home/user/.claude/transcript.jsonl'
|
|
);
|
|
});
|
|
|
|
it('accepts valid data payload with extra fields', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/hook-event',
|
|
payload: {
|
|
event: 'permission_prompt',
|
|
sessionId: harness.ctx._sessionId,
|
|
data: { tool_name: 'bash', command: 'ls -la' },
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
});
|
|
});
|
|
});
|