DevvynandClaude Opus 5.5
02e40f506b
Addresses the review on #472. - CRED_STORES: `.config/gh` and `.azure` now carry `enabledByEnv` (CODEMAN_AGENT_IMAGE_INSTALL_GH / _AZ), and resolveDockerCredentialArtifacts skips a store unless that variable is exactly `1`, read at container create. A host that merely has ~/.config/gh/hosts.yml or a plaintext MSAL cache no longer copies them into every case container. Tests: the default environment seeds neither even with the files present, and each store follows only its own switch. - Multi-user mode: a non-admin's Clone Repo clone and preflight run with `git -c credential.helper=` (GIT_NO_CREDENTIAL_HELPERS, placed before the subcommand), so the server account's helpers are never lent to them. Verified against a real private repo that it also clears the URL-scoped credential.<url>.helper entries, and that public clones still work. Tests: the argv in test/git-clone.test.ts, and the route decision (non-admin cleared; admin and single-user kept) in test/routes/case-clone-credential-helpers.test.ts. - Docs: recreate the case container to pick up seeds (docker/README.md, Docker-Cases wiki, docker-cases.md); the multi-user behaviour in docker/README.md and security-architecture.md; "functionally unchanged" instead of "unchanged" for an image built with both switches off (server.Dockerfile comment, README, changeset). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0167CiuzLrmjYWxwKp3rMWjw
1.7 KiB
aicodeman
| aicodeman |
|---|
| minor |
Docker images: optional GitHub CLI and Azure CLI for private GitHub and Azure DevOps repositories. Both are opt-in and off by default. Build the server image with CODEMAN_INSTALL_GH=1 / CODEMAN_INSTALL_AZ=1 (under build: args: in docker/docker-compose.override.yml) to add gh and/or az with the azure-devops extension, plus system Git credential helpers that route github.com through gh auth git-credential and dev.azure.com / *.visualstudio.com through a new az-backed helper (docker/git-credential-azure-cli, which also honours AZURE_DEVOPS_EXT_PAT). Sign the CLIs in once from a shell session and Add Case → Clone Repo can clone private repositories; until then a private clone still fails fast with an authentication error. The Docker-case agent image takes the same switches from CODEMAN_AGENT_IMAGE_INSTALL_GH / _AZ (the environment: of the override file, or in front of build-agent-image.mjs), and, only with those switches on, a seeded Docker case also copies the gh sign-in (~/.config/gh/hosts.yml, config.yml) and the az sign-in files from ~/.azure into newly created case containers, read-only and per file like the other CLIs. In multi-user mode, Clone Repo runs a non-admin's clone and preflight with git's credential helpers cleared, so the server account's sign-in is never lent to them. The Clone Repo authentication error now says how to sign the server's git in instead of claiming private repositories cannot be cloned. This changes server.Dockerfile, so Compose deployments need a Start-Codeman.sh rebuild rather than an in-app update; with neither switch set the rebuilt image is functionally unchanged.