mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
DevvynandClaude Sonnet 5
3f2928ae73
Addresses the "left as they are"/"worth knowing" items Ark0N named when merging #380 (the CLI-catalogue-driven install.sh + Docker agent image PR), none of which were correctness-blocking but all of which were real: - Removed install.sh's dead _cli_index/check_cli/get_cli_path helpers: the catalogue-driven menu and hints stopped calling them and nothing else ever did. - The generator no longer emits CLI_KIND/CLI_NPM, two bash arrays install.sh never read (the .mjs/docker-hosts.ts producers already read the JSON catalogue's kind/npmPackage fields directly, so only the bash copies were dead). - detect_all_clis now skips a disabled entry's probe entirely instead of running it and filtering the result downstream. No stock entry ships disabled today, so this closes a latent inefficiency before it is a latent bug rather than fixing an observed one. - The install hint for a launcherProfile entry (DeepSeek today) now explains in one line why it's a docs link and not a command: its own docs page documents `npm install -g @deepseek-ai/dsh`, which installs the launcher only and can't drive a pane, the exact trap the menu already avoids by withholding the command. Driven by a new generated CLI_LAUNCHER_ONLY array (from discovery.launcherProfile), not an id check, so any future launcherProfile entry gets the same caveat free. - Corrected the non-interactive-default comment: on a wget-only host, Claude's curl one-liner is filtered out of the offered list first, so the default becomes whichever npm-based entry sorts earliest instead (Codex today), not always Claude. Behaviour is unchanged — it was already printed, never silent — only the comment overclaimed. Tests: extended test/install-sh-invariants.test.ts with a positive guard for the new array and the trimmed array list, a negative guard that CLI_KIND/CLI_NPM/the three dead helpers cannot come back, and two real-bash tests (driven the same way the existing skip-menu tests are) proving a disabled entry is genuinely never probed rather than merely filtered after the fact. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011WzDjJnbK7zug8iQWnCc9z
1.6 KiB
1.6 KiB
aicodeman
| aicodeman |
|---|
| patch |
Cleans up the loose ends the maintainer flagged as "worth knowing rather than fixing" when
merging the CLI-catalogue-driven install.sh/Docker-agent-image PR (#380):
install.shno longer carries_cli_index/check_cli/get_cli_path, three generic lookup helpers left behind once the catalogue-driven menu and hints stopped calling them.- The generator no longer emits
CLI_KIND/CLI_NPM, two bash arrays nothing ininstall.shread (the.mjs/docker-hosts.tsproducers already read the JSON catalogue'skind/npmPackagefields directly). detect_all_clisnow skips a disabled entry entirely rather than probing it and filtering the result downstream — no stock entry ships disabled today, so this is a latent inefficiency closed before it is a latent bug, not a behaviour change.- The install hint for a
launcherProfileentry (DeepSeek today) now explains, in one line, why it is a docs link rather than a runnable command — its docs page documentsnpm install -g @deepseek-ai/dsh, which installs the launcher only and cannot drive a pane on its own, the exact trap the menu already avoids by withholding the command. Driven by a new generatedCLI_LAUNCHER_ONLYarray (fromdiscovery.launcherProfile), not an id check. - The non-interactive default's comment no longer claims it is always Claude Code: on a wget-only host, Claude's curl one-liner is filtered out of the offered list first, so the default becomes whichever npm-based entry sorts earliest instead. Behaviour is unchanged (and was already printed, so never silent) — only the comment was wrong.