mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-10-07 07:59:42 +02:00
The opt-in multi-user feature's only enforcement is web-layer scoping (all sessions share one OS account). An adversarial review found 8 critical + 7 high cross-user holes that defeated it, plus mediums; all fixed here. Single-user (flag-off) behavior stays byte-identical apart from documented consistency deltas. Ownership / confinement: - DELETE /api/sessions (bulk) + /:id now owner-scope / findSessionOrFail - quick-start, cron (create+fire), scheduled runs confine workingDir to the owner's space; case link/docker-link/docker-import confine the host path - resolveCasePath no longer resolves linked cases for non-admins; foreign remote/docker cases are skipped (fall through to the caller's own local case) - history, subagents/workflows, mux-sessions, orchestrator, cron run-history, away-digest, and remote/docker host reads are owner- or admin-scoped Permission policy (section 6.3): - non-granted users are downgraded at every spawn site incl. legacy /api/scheduled, PlanOrchestrator one-shots, remote launch, and the cron-fire gemini/codex bypass switches; resolveClaudeModeForUsername now fails closed Auth / store: - verify-first login throttle (a correct password is never locked out), /ws terminal subject to the change-password lockbox, cookie fast-path re-validates identity live, role/grant changes revoke sessions, admin delete runs the last-admin guard before any teardown - users.json: distinguish missing (ENOENT) from corrupt/unreadable so a bad read can't overwrite all accounts; unique per-process temp write path Event streams: - debounced session:updated + batched task:updated, clipboard, and push notifications route by owner (fail closed); getLightState hides machine-wide globalStats from non-admins Tests: two suites updated to assert the fixed (secure) behavior. tsc, eslint, and test:ci all green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
54 lines
2.0 KiB
TypeScript
54 lines
2.0 KiB
TypeScript
/**
|
|
* @fileoverview Push notification routes.
|
|
* Manages VAPID keys, push subscriptions, and preference updates.
|
|
*/
|
|
|
|
import { FastifyInstance } from 'fastify';
|
|
import { v4 as uuidv4 } from 'uuid';
|
|
import { ApiErrorCode, createErrorResponse } from '../../types.js';
|
|
import { PushSubscribeSchema, PushPreferencesUpdateSchema } from '../schemas.js';
|
|
import { parseBody } from '../route-helpers.js';
|
|
import type { InfraPort } from '../ports/index.js';
|
|
|
|
export function registerPushRoutes(app: FastifyInstance, ctx: InfraPort): void {
|
|
app.get('/api/push/vapid-key', async () => {
|
|
return { success: true, data: { publicKey: ctx.pushStore.getPublicKey() } };
|
|
});
|
|
|
|
app.post('/api/push/subscribe', async (req) => {
|
|
const { endpoint, keys, userAgent, pushPreferences } = parseBody(PushSubscribeSchema, req.body);
|
|
const record = ctx.pushStore.addSubscription({
|
|
id: uuidv4(),
|
|
endpoint,
|
|
keys,
|
|
userAgent: userAgent ?? req.headers['user-agent'] ?? '',
|
|
createdAt: Date.now(),
|
|
pushPreferences: pushPreferences ?? {},
|
|
// Multi-user: stamp the trusted caller identity so sendPushNotifications can
|
|
// scope session notifications to the owner (+ admins). Undefined in single-user.
|
|
username: req.authUser?.username,
|
|
role: req.authUser?.role,
|
|
});
|
|
return { success: true, data: { id: record.id } };
|
|
});
|
|
|
|
app.put('/api/push/subscribe/:id', async (req) => {
|
|
const { id } = req.params as { id: string };
|
|
const { pushPreferences } = parseBody(PushPreferencesUpdateSchema, req.body);
|
|
const updated = ctx.pushStore.updatePreferences(id, pushPreferences);
|
|
if (!updated) {
|
|
return createErrorResponse(ApiErrorCode.NOT_FOUND, 'Subscription not found');
|
|
}
|
|
return {};
|
|
});
|
|
|
|
app.delete('/api/push/subscribe/:id', async (req) => {
|
|
const { id } = req.params as { id: string };
|
|
const removed = ctx.pushStore.removeSubscription(id);
|
|
if (!removed) {
|
|
return createErrorResponse(ApiErrorCode.NOT_FOUND, 'Subscription not found');
|
|
}
|
|
return {};
|
|
});
|
|
}
|