mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
Codeman maintainer
7fc4784d0f
Confirming an AskUserQuestion left its tab flowing red for the rest of the turn (owner report: ~8 minutes on a running session, with no dialog anywhere on screen). Two separate bugs, both live-verified. The re-capture erased the evidence the staleness check runs on. Claude Code fires the Notification behind the dialog (measured 6-7s on v2.1.237, documented up to ~30s), so the 600ms re-capture routinely lands on a frame the user has ALREADY answered, parses nothing, and applyCapture overwrote item.options with undefined. A MISSING options is how "we never could read this dialog" is expressed, and those items stay answerable by design, so a cleared field was indistinguishable from a never-parsed one and the item became permanently unsweepable: it survived every GET /api/approvals and every page reload, cleared only on `stop`, and still accepted an answer, sending a bare `1` into a composer with no dialog under it. applyCapture is now ADD-ONLY for options. Nothing ran the staleness check while a page was open. It lived only in GET /api/approvals, which seedApprovals() calls on init and reconnect, so `stop` was the first thing that ever cleared an answered dialog. The `working` signal now runs the pane-VERIFIED variant (resolveIfDialogGone -> verifyStillAnswerable): the heuristic only decides when to look, the screen decides the outcome, so the existing "working can flap" rule is respected. A frame that parses no options is now conclusive in two cases, and only those, so an unreadable capture still keeps the alert: the item once parsed options, or the frame shows Claude actively running a turn. A modal dialog BLOCKS the turn, so the two cannot coexist - measured, a live-dialog frame carries neither the elapsed-timer spinner nor the "esc to interrupt" footer, which the dialog replaces with "Enter to select". That second signal is reached by a delayed staleness pass (3s) scheduled alongside the re-capture, which closes the late-hook case where the prompt is answered before the hook lands: nothing ever parses, `stop` may have gone by already, and the alert outlived reloads until the 12h TTL. The pass is deliberately later than RECAPTURE_DELAY_MS, whose whole reason for existing is that the hook can beat Ink to the screen. Frontend: _onHookElicitationComplete cleared only the elicitation entry, but an AskUserQuestion arrives as permission_prompt, so it was clearing the wrong alert; it now clears both, matching the server's kind-agnostic APPROVAL_RESOLVING_EVENTS. Verified end to end on an isolated beta instance, not just in unit tests: before, resolution could only come from the stop route (approval:resolved always immediately preceding hook:stop); after, it arrives from the new paths, and a simulated late hook resolves at +3.12s with no stop, no working signal and no GET, while the pane is still working. Tests use frames captured off a live pane and each new one was confirmed to fail against the old behaviour. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
557 lines
22 KiB
TypeScript
557 lines
22 KiB
TypeScript
/**
|
||
* Approvals Inbox store unit tests (src/web/approval-inbox.ts).
|
||
*
|
||
* Pure in-memory registry: no ports, no server. Constructs its own
|
||
* ApprovalInbox instances (never the process singleton) so tests cannot
|
||
* leak state into the route tests that share the module.
|
||
*/
|
||
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
|
||
import {
|
||
ApprovalInbox,
|
||
normalizeCapturedFrame,
|
||
parseDialogOptions,
|
||
type ApprovalItem,
|
||
type ApprovalResolvedInfo,
|
||
} from '../src/web/approval-inbox.js';
|
||
|
||
const PERMISSION_FRAME = [
|
||
' Do you want to make this edit to foo.ts?',
|
||
' ❯ 1. Yes',
|
||
' 2. Yes, allow all edits during this session (shift+tab)',
|
||
' 3. No, and tell Claude what to do differently (esc)',
|
||
].join('\n');
|
||
|
||
const TWO_OPTION_FRAME = [' Trust the files in this folder?', ' ❯ 1. Yes, proceed', ' 2. No, exit'].join('\n');
|
||
|
||
// The live AskUserQuestion shape (measured on Claude Code v2.1.226): a
|
||
// description row under every option and a ─ separator before "Chat about this".
|
||
const ASK_USER_QUESTION_FRAME = [
|
||
' ☐ Color',
|
||
' Which color do you prefer?',
|
||
'❯ 1. Red',
|
||
' Prefer red',
|
||
' 2. Blue',
|
||
' Prefer blue',
|
||
' 3. Green',
|
||
' Prefer green',
|
||
' 4. Type something.',
|
||
'────────────────────────────────────────',
|
||
' 5. Chat about this',
|
||
'Enter to select · ↑/↓ to navigate · Esc to cancel',
|
||
].join('\n');
|
||
|
||
// Both frames captured off a live Claude Code v2.1.237 pane. They are the
|
||
// discriminator behind the late-hook resolution: a modal dialog BLOCKS the
|
||
// turn, so a working line and a dialog cannot coexist. Note the dialog frame
|
||
// carries no `esc to interrupt` footer either — the dialog replaces it.
|
||
const LIVE_DIALOG_FRAME = [
|
||
'● Bash(sleep 12; echo "slept 12s")',
|
||
' ⎿ slept 12s',
|
||
'────────────────────────────────────────',
|
||
' ☐ Proceed',
|
||
'',
|
||
'Proceed?',
|
||
'',
|
||
'❯ 1. Yes',
|
||
' Go ahead and proceed.',
|
||
' 2. No',
|
||
' Do not proceed.',
|
||
' 3. Type something.',
|
||
'────────────────────────────────────────',
|
||
' 4. Chat about this',
|
||
'',
|
||
'Enter to select · ↑/↓ to navigate · Esc to cancel',
|
||
].join('\n');
|
||
|
||
const WORKING_FRAME = [
|
||
'● Bash(sleep 25)',
|
||
' ⎿ Tip: Use git worktrees to run multiple Claude sessions in parallel.',
|
||
'✢ Clauding… (13s · ↓ 1.4k tokens)',
|
||
'────────────────────────────────────────',
|
||
'❯',
|
||
'────────────────────────────────────────',
|
||
' ⏵⏵ bypass permissions on (shift+tab to cycle) · esc to interrupt · ← for agents',
|
||
].join('\n');
|
||
|
||
function collect(inbox: ApprovalInbox) {
|
||
const pending: ApprovalItem[] = [];
|
||
const updated: ApprovalItem[] = [];
|
||
const resolved: ApprovalResolvedInfo[] = [];
|
||
inbox.onPending = (i) => pending.push(i);
|
||
inbox.onUpdated = (i) => updated.push(i);
|
||
inbox.onResolved = (i) => resolved.push(i);
|
||
return { pending, updated, resolved };
|
||
}
|
||
|
||
describe('parseDialogOptions', () => {
|
||
it('parses a 3-option permission dialog with the ❯ cursor', () => {
|
||
const options = parseDialogOptions(PERMISSION_FRAME);
|
||
expect(options).toEqual([
|
||
{ n: 1, label: 'Yes' },
|
||
{ n: 2, label: 'Yes, allow all edits during this session (shift+tab)' },
|
||
{ n: 3, label: 'No, and tell Claude what to do differently (esc)' },
|
||
]);
|
||
});
|
||
|
||
it('parses a 2-option dialog', () => {
|
||
expect(parseDialogOptions(TWO_OPTION_FRAME)).toHaveLength(2);
|
||
});
|
||
|
||
it('returns undefined when nothing parses', () => {
|
||
expect(parseDialogOptions('just some terminal output\nwith no menu')).toBeUndefined();
|
||
expect(parseDialogOptions(undefined)).toBeUndefined();
|
||
// A single numbered line is not a dialog.
|
||
expect(parseDialogOptions('1. lonely item')).toBeUndefined();
|
||
});
|
||
|
||
it('requires consecutive numbering from 1', () => {
|
||
expect(parseDialogOptions('2. Yes\n3. No')).toBeUndefined();
|
||
});
|
||
|
||
it('takes the LAST complete block in the frame (dialogs render at the bottom)', () => {
|
||
const frame = ['1. old option', '2. old option two', 'some output in between', TWO_OPTION_FRAME].join('\n');
|
||
const options = parseDialogOptions(frame);
|
||
expect(options?.[0].label).toBe('Yes, proceed');
|
||
});
|
||
|
||
it('caps option labels at 120 chars', () => {
|
||
const long = 'x'.repeat(300);
|
||
const options = parseDialogOptions(`1. ${long}\n2. No`);
|
||
expect(options?.[0].label).toHaveLength(120);
|
||
});
|
||
|
||
it('parses the AskUserQuestion shape (descriptions between options, separator before the last)', () => {
|
||
const options = parseDialogOptions(ASK_USER_QUESTION_FRAME);
|
||
expect(options?.map((o) => o.label)).toEqual(['Red', 'Blue', 'Green', 'Type something.', 'Chat about this']);
|
||
});
|
||
|
||
it('a gap of more than 3 lines ends the option block', () => {
|
||
const frame = ['1. Yes', '2. No', 'a', 'b', 'c', 'd', 'unrelated 3. text'].join('\n');
|
||
const options = parseDialogOptions(frame);
|
||
expect(options).toHaveLength(2);
|
||
});
|
||
});
|
||
|
||
describe('normalizeCapturedFrame', () => {
|
||
it('strips ANSI, right-trims, and drops trailing blank lines', () => {
|
||
const raw = '\x1b[31mred\x1b[0m \nline2\n\n\n';
|
||
expect(normalizeCapturedFrame(raw)).toBe('red\nline2');
|
||
});
|
||
|
||
it('keeps only the last 30 lines', () => {
|
||
const raw = Array.from({ length: 50 }, (_, i) => `line${i}`).join('\n');
|
||
const out = normalizeCapturedFrame(raw)!;
|
||
expect(out.split('\n')).toHaveLength(30);
|
||
expect(out.startsWith('line20')).toBe(true);
|
||
});
|
||
|
||
it('returns undefined for empty/null captures', () => {
|
||
expect(normalizeCapturedFrame(null)).toBeUndefined();
|
||
expect(normalizeCapturedFrame('\n\n')).toBeUndefined();
|
||
});
|
||
|
||
it('converts absolute row repaints (formatPaneSnapshot frames) into lines', () => {
|
||
// The visible tmux capture carries NO newlines; every row is painted at
|
||
// `ESC[<row>;1H`. Measured against a live dialog frame.
|
||
const raw = '\x1b[12;1H Which color do you prefer?\x1b[13;1H❯ 1. Red\x1b[14;1H Prefer red\x1b[15;1H 2. Blue';
|
||
const out = normalizeCapturedFrame(raw)!;
|
||
expect(out.split('\n')).toEqual([' Which color do you prefer?', '❯ 1. Red', ' Prefer red', ' 2. Blue']);
|
||
expect(parseDialogOptions(out)).toEqual([
|
||
{ n: 1, label: 'Red' },
|
||
{ n: 2, label: 'Blue' },
|
||
]);
|
||
});
|
||
|
||
it('turns mid-row cursor jumps into spaces instead of gluing words', () => {
|
||
const out = normalizeCapturedFrame('\x1b[5;1Hstatus:\x1b[5;20Hready');
|
||
expect(out).toBe('status: ready');
|
||
});
|
||
});
|
||
|
||
describe('ApprovalInbox', () => {
|
||
let inbox: ApprovalInbox;
|
||
|
||
beforeEach(() => {
|
||
vi.useFakeTimers();
|
||
inbox = new ApprovalInbox();
|
||
});
|
||
|
||
afterEach(() => {
|
||
inbox.stop();
|
||
vi.useRealTimers();
|
||
});
|
||
|
||
it('notePrompt creates a pending item with parsed options and emits onPending', () => {
|
||
const { pending } = collect(inbox);
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1-case',
|
||
kind: 'permission',
|
||
toolName: 'Edit',
|
||
capture: () => PERMISSION_FRAME,
|
||
});
|
||
expect(item.options).toHaveLength(3);
|
||
expect(item.context).toContain('Do you want to make this edit');
|
||
expect(pending).toHaveLength(1);
|
||
expect(inbox.listPending()).toHaveLength(1);
|
||
expect(inbox.getById(item.id)?.id).toBe(item.id);
|
||
expect(inbox.getForSession('s1')?.id).toBe(item.id);
|
||
});
|
||
|
||
it('a new prompt supersedes the session previous item', () => {
|
||
const { resolved } = collect(inbox);
|
||
const first = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission' });
|
||
const second = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'question' });
|
||
expect(inbox.listPending()).toHaveLength(1);
|
||
expect(inbox.getById(first.id)).toBeUndefined();
|
||
expect(inbox.getById(second.id)).toBeDefined();
|
||
expect(resolved).toEqual([expect.objectContaining({ id: first.id, resolution: 'superseded' })]);
|
||
});
|
||
|
||
it('idle prompts never get digit options', () => {
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'idle',
|
||
capture: () => PERMISSION_FRAME,
|
||
});
|
||
expect(item.options).toBeUndefined();
|
||
expect(item.context).toBeDefined();
|
||
});
|
||
|
||
it('resolveForSession with a kinds filter skips other kinds (working-flap guard)', () => {
|
||
const { resolved } = collect(inbox);
|
||
inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission' });
|
||
inbox.resolveForSession('s1', 'resolved_in_terminal', ['idle']);
|
||
expect(inbox.listPending()).toHaveLength(1);
|
||
|
||
inbox.notePrompt({ sessionId: 's2', sessionName: 'w2', kind: 'idle' });
|
||
inbox.resolveForSession('s2', 'resolved_in_terminal', ['idle']);
|
||
expect(inbox.getForSession('s2')).toBeUndefined();
|
||
expect(resolved.filter((r) => r.resolution === 'resolved_in_terminal')).toHaveLength(1);
|
||
});
|
||
|
||
it('take removes as answered; restore re-inserts unless superseded', () => {
|
||
const { resolved } = collect(inbox);
|
||
const item = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission' });
|
||
const taken = inbox.take(item.id)!;
|
||
expect(taken.id).toBe(item.id);
|
||
expect(inbox.take(item.id)).toBeUndefined();
|
||
expect(resolved.at(-1)).toMatchObject({ id: item.id, resolution: 'answered' });
|
||
|
||
inbox.restore(taken);
|
||
expect(inbox.getById(item.id)).toBeDefined();
|
||
|
||
// A newer prompt wins over a restore.
|
||
const taken2 = inbox.take(item.id)!;
|
||
const newer = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'question' });
|
||
inbox.restore(taken2);
|
||
expect(inbox.getForSession('s1')?.id).toBe(newer.id);
|
||
});
|
||
|
||
it('acknowledge marks an idle item seen without resolving it, and emits onUpdated once', () => {
|
||
const { updated, resolved } = collect(inbox);
|
||
const item = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'idle' });
|
||
const acked = inbox.acknowledge('s1');
|
||
expect(acked?.id).toBe(item.id);
|
||
expect(acked?.acknowledgedAt).toBeGreaterThan(0);
|
||
// Still pending and still answerable: the human looked, they did not answer.
|
||
expect(inbox.getById(item.id)?.acknowledgedAt).toBeGreaterThan(0);
|
||
expect(inbox.listPending()).toHaveLength(1);
|
||
expect(resolved).toHaveLength(0);
|
||
expect(updated).toEqual([expect.objectContaining({ id: item.id })]);
|
||
// Idempotent: a second view does not re-broadcast.
|
||
expect(inbox.acknowledge('s1')).toBeUndefined();
|
||
expect(updated).toHaveLength(1);
|
||
});
|
||
|
||
it('acknowledge never touches a permission/question item (viewing is not answering)', () => {
|
||
const { updated } = collect(inbox);
|
||
const permission = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission' });
|
||
expect(inbox.acknowledge('s1')).toBeUndefined();
|
||
expect(inbox.getById(permission.id)?.acknowledgedAt).toBeUndefined();
|
||
|
||
const question = inbox.notePrompt({ sessionId: 's2', sessionName: 'w2', kind: 'question' });
|
||
expect(inbox.acknowledge('s2')).toBeUndefined();
|
||
expect(inbox.getById(question.id)?.acknowledgedAt).toBeUndefined();
|
||
expect(updated).toHaveLength(0);
|
||
|
||
expect(inbox.acknowledge('nope')).toBeUndefined();
|
||
});
|
||
|
||
it('a new prompt after an acknowledgement arms the alert again', () => {
|
||
inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'idle' });
|
||
inbox.acknowledge('s1');
|
||
const next = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'idle' });
|
||
expect(next.acknowledgedAt).toBeUndefined();
|
||
expect(inbox.getForSession('s1')?.acknowledgedAt).toBeUndefined();
|
||
});
|
||
|
||
it('dismiss removes without answering', () => {
|
||
const { resolved } = collect(inbox);
|
||
const item = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'question' });
|
||
expect(inbox.dismiss(item.id)).toBe(true);
|
||
expect(inbox.dismiss(item.id)).toBe(false);
|
||
expect(resolved.at(-1)).toMatchObject({ resolution: 'dismissed' });
|
||
});
|
||
|
||
it('items expire after the TTL on read', () => {
|
||
const { resolved } = collect(inbox);
|
||
inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission' });
|
||
vi.advanceTimersByTime(13 * 60 * 60 * 1000);
|
||
expect(inbox.listPending()).toHaveLength(0);
|
||
expect(resolved.at(-1)).toMatchObject({ resolution: 'expired' });
|
||
});
|
||
|
||
it('re-captures once after a short delay and emits onUpdated', () => {
|
||
const { updated } = collect(inbox);
|
||
let frame = 'still painting...';
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => frame,
|
||
});
|
||
expect(item.options).toBeUndefined();
|
||
frame = PERMISSION_FRAME;
|
||
vi.advanceTimersByTime(700);
|
||
expect(updated).toHaveLength(1);
|
||
expect(inbox.getById(item.id)?.options).toHaveLength(3);
|
||
});
|
||
|
||
it('the delayed re-capture never touches a superseded item', () => {
|
||
let frame = 'first';
|
||
const first = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission', capture: () => frame });
|
||
const second = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'question', capture: () => frame });
|
||
frame = PERMISSION_FRAME;
|
||
const { updated } = collect(inbox);
|
||
vi.advanceTimersByTime(700);
|
||
expect(updated.every((i) => i.id !== first.id)).toBe(true);
|
||
expect(inbox.getById(second.id)).toBeDefined();
|
||
});
|
||
|
||
describe('verifyStillAnswerable', () => {
|
||
it('resolves the item and refuses when a parsed dialog left the screen', () => {
|
||
const { resolved } = collect(inbox);
|
||
let frame = PERMISSION_FRAME;
|
||
const item = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission', capture: () => frame });
|
||
expect(item.options).toHaveLength(3);
|
||
frame = 'the dialog is gone, claude is typing';
|
||
expect(inbox.verifyStillAnswerable(item.id)).toBe(false);
|
||
expect(inbox.getById(item.id)).toBeUndefined();
|
||
expect(resolved.at(-1)).toMatchObject({ id: item.id, resolution: 'resolved_in_terminal' });
|
||
});
|
||
|
||
it('refreshes context/options when the dialog is still up', () => {
|
||
let frame = PERMISSION_FRAME;
|
||
const item = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission', capture: () => frame });
|
||
frame = TWO_OPTION_FRAME;
|
||
expect(inbox.verifyStillAnswerable(item.id)).toBe(true);
|
||
expect(inbox.getById(item.id)?.options).toHaveLength(2);
|
||
});
|
||
|
||
it('is inconclusive (allows) for items that never parsed options', () => {
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => 'unparseable dialog',
|
||
});
|
||
expect(item.options).toBeUndefined();
|
||
expect(inbox.verifyStillAnswerable(item.id)).toBe(true);
|
||
});
|
||
|
||
it('is true for unknown ids only as false (missing item refuses)', () => {
|
||
expect(inbox.verifyStillAnswerable('nope:1')).toBe(false);
|
||
});
|
||
});
|
||
|
||
describe('answered-in-the-terminal staleness', () => {
|
||
// Claude Code delays the Notification hook behind the dialog (measured 6s
|
||
// on v2.1.237, documented up to ~30s), so the 600ms re-capture routinely
|
||
// lands on a frame the user has ALREADY answered. Erasing `options` there
|
||
// made the item permanently unsweepable, because a missing `options` is how
|
||
// "we never could read this dialog" is expressed, and such items stay
|
||
// answerable on purpose. The red tab alert then survived every
|
||
// `GET /api/approvals` and every reload, clearing only on `stop`.
|
||
it('a re-capture taken after the answer does not erase parsed options', () => {
|
||
const { updated } = collect(inbox);
|
||
let frame = ASK_USER_QUESTION_FRAME;
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => frame,
|
||
});
|
||
expect(item.options).toHaveLength(5);
|
||
|
||
// Answered in the terminal before the re-capture fires.
|
||
frame = "● User answered Claude's questions:\n ⎿ · Which color do you prefer? → Red\n\n✶ Cooking… (6s)";
|
||
vi.advanceTimersByTime(600);
|
||
|
||
expect(updated).toHaveLength(1);
|
||
expect(inbox.getById(item.id)?.context).toContain('User answered');
|
||
expect(inbox.getById(item.id)?.options).toHaveLength(5);
|
||
// ...which keeps the staleness check conclusive instead of inconclusive.
|
||
expect(inbox.verifyStillAnswerable(item.id)).toBe(false);
|
||
expect(inbox.getById(item.id)).toBeUndefined();
|
||
});
|
||
|
||
it('resolveIfDialogGone resolves a dialog answered in the terminal', () => {
|
||
const { resolved } = collect(inbox);
|
||
let frame = PERMISSION_FRAME;
|
||
const item = inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission', capture: () => frame });
|
||
frame = 'the dialog is gone, claude is typing';
|
||
|
||
inbox.resolveIfDialogGone('s1');
|
||
|
||
expect(inbox.getById(item.id)).toBeUndefined();
|
||
expect(resolved.at(-1)).toMatchObject({ id: item.id, resolution: 'resolved_in_terminal' });
|
||
});
|
||
|
||
it('resolveIfDialogGone keeps a dialog that is still on screen', () => {
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => PERMISSION_FRAME,
|
||
});
|
||
inbox.resolveIfDialogGone('s1');
|
||
expect(inbox.getById(item.id)).toBeDefined();
|
||
});
|
||
|
||
it('resolveIfDialogGone never touches an idle item (that is the working signal job)', () => {
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'idle',
|
||
capture: () => 'composer is empty',
|
||
});
|
||
inbox.resolveIfDialogGone('s1');
|
||
expect(inbox.getById(item.id)).toBeDefined();
|
||
});
|
||
|
||
// The late-hook hole: Claude Code fires the Notification behind the dialog,
|
||
// so a prompt answered before the hook lands produces an item whose FIRST
|
||
// capture already has no dialog in it. Nothing ever parsed, so "options
|
||
// vanished" can never fire, and `stop` had already gone by too — the red
|
||
// alert then survived reloads until the 12h TTL.
|
||
it('resolves an item that never parsed options once the pane is visibly working', () => {
|
||
const { resolved } = collect(inbox);
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => WORKING_FRAME,
|
||
});
|
||
expect(item.options).toBeUndefined();
|
||
|
||
expect(inbox.verifyStillAnswerable(item.id)).toBe(false);
|
||
expect(inbox.getById(item.id)).toBeUndefined();
|
||
expect(resolved.at(-1)).toMatchObject({ id: item.id, resolution: 'resolved_in_terminal' });
|
||
});
|
||
|
||
it('keeps an unreadable dialog answerable when the pane is NOT visibly working', () => {
|
||
// The conservative rule this fix must not loosen: no options and no proof
|
||
// the turn is running means "we cannot read it", not "it is gone".
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => 'some dialog shape we cannot parse',
|
||
});
|
||
expect(item.options).toBeUndefined();
|
||
expect(inbox.verifyStillAnswerable(item.id)).toBe(true);
|
||
expect(inbox.getById(item.id)).toBeDefined();
|
||
});
|
||
|
||
it('a real live-dialog frame carries no working line, so it is never false-resolved', () => {
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => LIVE_DIALOG_FRAME,
|
||
});
|
||
expect(item.options).toHaveLength(4);
|
||
expect(inbox.verifyStillAnswerable(item.id)).toBe(true);
|
||
expect(inbox.getById(item.id)).toBeDefined();
|
||
});
|
||
|
||
it('resolveIfDialogGone clears a late-hook item on the next working signal', () => {
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => WORKING_FRAME,
|
||
});
|
||
inbox.resolveIfDialogGone('s1');
|
||
expect(inbox.getById(item.id)).toBeUndefined();
|
||
});
|
||
|
||
it('the delayed staleness pass resolves a late-hook item with no working signal needed', () => {
|
||
const { resolved } = collect(inbox);
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => WORKING_FRAME,
|
||
});
|
||
expect(item.options).toBeUndefined();
|
||
|
||
vi.advanceTimersByTime(600); // re-capture: enrichment only, never resolves
|
||
expect(inbox.getById(item.id)).toBeDefined();
|
||
|
||
vi.advanceTimersByTime(2400); // the delayed staleness pass
|
||
expect(inbox.getById(item.id)).toBeUndefined();
|
||
expect(resolved.at(-1)).toMatchObject({ id: item.id, resolution: 'resolved_in_terminal' });
|
||
});
|
||
|
||
it('a dialog Ink paints late is NOT resolved by the delayed pass', () => {
|
||
// The paint race the re-capture exists for: the hook can beat Ink to the
|
||
// screen. Resolving inside that window would clear the alert for a dialog
|
||
// that was about to appear, so the frame is what decides, every time.
|
||
let frame = WORKING_FRAME;
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => frame,
|
||
});
|
||
frame = LIVE_DIALOG_FRAME; // Ink finishes painting
|
||
|
||
vi.advanceTimersByTime(600);
|
||
expect(inbox.getById(item.id)?.options).toHaveLength(4);
|
||
vi.advanceTimersByTime(2400);
|
||
expect(inbox.getById(item.id)).toBeDefined();
|
||
});
|
||
|
||
it('resolving cancels both pending timers', () => {
|
||
const { updated } = collect(inbox);
|
||
const item = inbox.notePrompt({
|
||
sessionId: 's1',
|
||
sessionName: 'w1',
|
||
kind: 'permission',
|
||
capture: () => PERMISSION_FRAME,
|
||
});
|
||
inbox.dismiss(item.id);
|
||
vi.advanceTimersByTime(5000);
|
||
expect(updated).toHaveLength(0);
|
||
expect(inbox.listPending()).toHaveLength(0);
|
||
});
|
||
|
||
it('resolveIfDialogGone is a no-op for a session with nothing pending', () => {
|
||
const { resolved } = collect(inbox);
|
||
expect(() => inbox.resolveIfDialogGone('nobody')).not.toThrow();
|
||
expect(resolved).toHaveLength(0);
|
||
});
|
||
});
|
||
|
||
it('stop() clears items and silences events', () => {
|
||
const { resolved } = collect(inbox);
|
||
inbox.notePrompt({ sessionId: 's1', sessionName: 'w1', kind: 'permission' });
|
||
inbox.stop();
|
||
expect(inbox.listPending()).toHaveLength(0);
|
||
expect(resolved).toHaveLength(0);
|
||
});
|
||
});
|