mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-10-02 05:29:42 +02:00
Codeman maintainer
2b89f35599
Follow-up to #209 and #210. Both land a real fix (a pane that is a login shell picks up /etc/profile and the per-user PATH entries an ssh remote command never sees, which is what was failing agent CLIs with exit 127). Three corrections: 1. `-i -l` is no longer hardcoded onto the resolved shell. That path ultimately comes from the passwd entry, which is user data and can name anything, and a shell that rejects an unknown flag exits on the spot: nushell, elvish and xonsh take neither flag, so a user with one of those in passwd would have gotten a dead pane on arrival, which is exactly the #208 failure #209 builds on top of. loginShellArgs() applies them only to the POSIX-family shells verified to accept both, and a test really launches every allowlisted shell present on the machine rather than trusting the set. csh/tcsh are excluded deliberately: tcsh honors -l only when it is the ONLY flag. 2. `remain-on-exit on` -> `failed`, moved LAST in the tmux command chain. `on` keeps the pane after a CLEAN exit too, so typing `exit` in a remote shell stranded a dead pane, the session outlived it, and the next launch's `-A` reattached to that corpse: "Pane is dead (status 0)" instead of a shell, permanently, on the DEFAULT path. Verified against a real tmux, as was the fix: `failed` tears the session down on status 0 and keeps the pane on 127 with the "command not found" still on screen, which is the case #210 wanted. It is last because tmux aborts the remaining commands of a `\;` sequence once one errors (also verified) and `failed` needs tmux >= 3.2 on the REMOTE host; leading, a rejection there would have silently dropped status/mouse/prefix/ escape-time/window-size along with it. 3. `$SHELL` -> `"${SHELL:-/bin/sh}"`, via one shared remoteLoginShellCommand() helper instead of the string being rebuilt in tmux-manager as well. Also corrects the rationale both PRs carried: a tmux pane already hands the shell a tty, so it was interactive all along ($- contains i for a bare /bin/bash in a pane) and ~/.bashrc was always being sourced. `-l` is the flag doing the work. End-to-end verified, not just unit-tested: the emitted remote pane command was run through all three quoting layers under a minimal sshd-style PATH with the CLI installed only on a login-shell PATH entry, and it resolved and launched the CLI with its arguments intact and a space-containing remote path preserved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
36 lines
1.6 KiB
TypeScript
36 lines
1.6 KiB
TypeScript
/**
|
|
* @fileoverview Utility module exports.
|
|
*
|
|
* This module re-exports all utility classes and functions for easy import.
|
|
*
|
|
* @module utils
|
|
*/
|
|
|
|
export { BufferAccumulator } from './buffer-accumulator.js';
|
|
export { CleanupManager } from './cleanup-manager.js';
|
|
export { Debouncer, KeyedDebouncer } from './debouncer.js';
|
|
export { startEventLoopMonitor } from './event-loop-monitor.js';
|
|
export type { EventLoopMonitorHandle } from './event-loop-monitor.js';
|
|
export { StaleExpirationMap } from './stale-expiration-map.js';
|
|
export {
|
|
ANSI_ESCAPE_PATTERN_FULL,
|
|
ANSI_ESCAPE_PATTERN_SIMPLE,
|
|
TOKEN_PATTERN,
|
|
SPINNER_PATTERN,
|
|
stripAnsi,
|
|
SAFE_PATH_PATTERN,
|
|
execPattern,
|
|
} from './regex-patterns.js';
|
|
export { MAX_SESSION_TOKENS } from './token-validation.js';
|
|
export { isSafePushEndpoint } from './push-endpoint-validation.js';
|
|
export { stringSimilarity, fuzzyPhraseMatch, todoContentHash } from './string-similarity.js';
|
|
export { assertNever } from './type-safety.js';
|
|
export { wrapWithNice } from './nice-wrapper.js';
|
|
export { resolveLocalShell, loginShellArgs } from './shell-resolver.js';
|
|
export { findClaudeDir, getAugmentedPath, getClaudeCliVersion, getClaudeBinaryPath } from './claude-cli-resolver.js';
|
|
export { spawnPtyWithHelperRepair } from './node-pty-repair.js';
|
|
export { resolveOpenCodeDir } from './opencode-cli-resolver.js';
|
|
export { resolveCodexDir, isCodexAvailable } from './codex-cli-resolver.js';
|
|
export { resolveGeminiDir, isGeminiAvailable } from './gemini-cli-resolver.js';
|
|
export { resolveAntigravityDir, isAntigravityAvailable } from './antigravity-cli-resolver.js';
|