mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
- UI: add the missing data-tab="case-remote" tab button; dispatch it through submitCaseModal()/switchCaseModalTab() to linkRemoteCase() (was dead code). - Restore: restoreMuxSessions() now passes remote (muxSession.remote ?? savedState.remote) into the Session constructor, so remote metadata round-trips on restart instead of reattaching from a local cwd / respawning LOCAL / being erased from state.json. Recovery tests added. - Run flows: runClaude()/runShell() route remote cases through /api/quick-start (POST /api/sessions stat-validates workingDir locally); run*() skip the /api/*/status pre-check and omit inert config/env for remote cases. - Quick-start: resolve the remote case BEFORE the local CLI availability gates and skip isCodex/Gemini/OpenCodeAvailable() when remote; REJECT envOverrides/effort/codex/gemini/openCode config for remote (they don't cross ssh) instead of silently dropping them. - Injection: reject $, backtick, $( in remotePath + identityFile at the schema layer (they survive shellescape into the bash -c launch double-quote layer). Regression tests for $(...) and backtick payloads added. - Remote socket/name: launch on a DEDICATED -L codeman-remote socket under a codeman-ssh-<id> name that fails a remote Codeman's SAFE_MUX_NAME_PATTERN, so a remote instance can't adopt the session; scope tmux set-options per-session (never -g) so they don't mutate other sessions. - Kill: best-effort ssh 'tmux -L codeman-remote kill-session' on remote session kill (fire-and-forget, never blocks/throws the local kill) so the remote agent isn't orphaned forever. - Probe: wire checkRemoteTmuxAvailable() into POST /api/quick-start (structured OPERATION_FAILED) and as courtesy validation in remote-link; add a default -o ConnectTimeout=10 to buildSshConnectionArgs (overridable via extraSshOptions). - Command default: remote claude default is now 'exec claude --dangerously-skip-permissions' (per-host override stays the escape hatch), mirroring local non-interactive semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
856 lines
30 KiB
TypeScript
856 lines
30 KiB
TypeScript
/**
|
|
* @fileoverview Tests for case-routes route handlers.
|
|
*
|
|
* Uses app.inject() — no real HTTP ports needed.
|
|
* Port: N/A (app.inject doesn't open ports)
|
|
*
|
|
* Responses follow the uniform envelope contract:
|
|
* SUCCESS -> HTTP 2xx, body = { success: true, data: <payload> }
|
|
* ERROR -> HTTP 4xx/5xx, body = { success: false, error, errorCode }
|
|
* Bare handler returns are wrapped into { success:true, data } and returned
|
|
* error envelopes are mapped to their conventional HTTP status by the same
|
|
* preSerialization hook the production server installs (mirrored below so test
|
|
* behavior matches production exactly).
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
|
|
import Fastify, { type FastifyInstance } from 'fastify';
|
|
import fastifyCookie from '@fastify/cookie';
|
|
import { createMockRouteContext, type MockRouteContext } from '../mocks/index.js';
|
|
import { installRouteErrorHandler } from '../../src/web/route-error-handler.js';
|
|
import { ApiErrorCode, httpStatusForErrorCode } from '../../src/types.js';
|
|
import { registerCaseRoutes } from '../../src/web/routes/case-routes.js';
|
|
|
|
// Mock filesystem modules
|
|
vi.mock('node:fs', async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import('node:fs')>();
|
|
return {
|
|
...actual,
|
|
existsSync: vi.fn(() => false),
|
|
mkdirSync: vi.fn(),
|
|
writeFileSync: vi.fn(),
|
|
readdirSync: vi.fn(() => []),
|
|
};
|
|
});
|
|
|
|
vi.mock('node:fs/promises', () => ({
|
|
default: {
|
|
readdir: vi.fn(async () => []),
|
|
readFile: vi.fn(async () => {
|
|
const err = new Error('ENOENT') as NodeJS.ErrnoException;
|
|
err.code = 'ENOENT';
|
|
throw err;
|
|
}),
|
|
writeFile: vi.fn(async () => {}),
|
|
},
|
|
}));
|
|
|
|
vi.mock('../../src/templates/claude-md.js', () => ({
|
|
generateClaudeMd: vi.fn(() => '# CLAUDE.md\nGenerated content'),
|
|
}));
|
|
|
|
vi.mock('../../src/hooks-config.js', () => ({
|
|
writeHooksConfig: vi.fn(async () => {}),
|
|
}));
|
|
|
|
// Stub the remote-tmux prereq probe so remote-link tests never shell out to ssh
|
|
// (readRemoteHosts/writeRemoteHosts stay real, backed by the mocked fs).
|
|
vi.mock('../../src/remote-hosts.js', async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import('../../src/remote-hosts.js')>();
|
|
return {
|
|
...actual,
|
|
checkRemoteTmuxAvailable: vi.fn(async () => ({ ok: true, tmuxPath: '/usr/bin/tmux' })),
|
|
};
|
|
});
|
|
|
|
// Import mocked modules for test control
|
|
import { existsSync, mkdirSync, readdirSync } from 'node:fs';
|
|
import fs from 'node:fs/promises';
|
|
import { checkRemoteTmuxAvailable } from '../../src/remote-hosts.js';
|
|
|
|
const mockedExistsSync = vi.mocked(existsSync);
|
|
const mockedMkdirSync = vi.mocked(mkdirSync);
|
|
const mockedReaddirSync = vi.mocked(readdirSync);
|
|
const mockedReaddir = vi.mocked(fs.readdir);
|
|
const mockedReadFile = vi.mocked(fs.readFile);
|
|
const mockedWriteFile = vi.mocked(fs.writeFile);
|
|
const mockedCheckRemoteTmux = vi.mocked(checkRemoteTmuxAvailable);
|
|
|
|
interface CaseRouteHarness {
|
|
app: FastifyInstance;
|
|
ctx: MockRouteContext;
|
|
}
|
|
|
|
/**
|
|
* Build a route harness that mirrors production: cookie plugin, the shared
|
|
* route error handler, AND the uniform-envelope preSerialization hook (copied
|
|
* from src/web/server.ts) so bare handler returns become { success:true, data }
|
|
* and returned error envelopes get mapped to a conventional HTTP status.
|
|
*/
|
|
async function createEnvelopeHarness(): Promise<CaseRouteHarness> {
|
|
const app = Fastify({ logger: false });
|
|
await app.register(fastifyCookie);
|
|
|
|
// Uniform response envelope (matches src/web/server.ts preSerialization hook).
|
|
app.addHook('preSerialization', (req, reply, payload: unknown, done) => {
|
|
if (!req.url.startsWith('/api')) return done(null, payload);
|
|
if (payload === null || typeof payload !== 'object') return done(null, payload);
|
|
if (Buffer.isBuffer(payload) || typeof (payload as { pipe?: unknown }).pipe === 'function') {
|
|
return done(null, payload);
|
|
}
|
|
const p = payload as { success?: unknown; errorCode?: unknown };
|
|
if (p.success === false) {
|
|
if (reply.statusCode === 200 && typeof p.errorCode === 'string') {
|
|
reply.code(httpStatusForErrorCode(p.errorCode as ApiErrorCode));
|
|
}
|
|
return done(null, payload);
|
|
}
|
|
if (p.success === true) return done(null, payload);
|
|
return done(null, { success: true, data: payload });
|
|
});
|
|
|
|
const ctx = createMockRouteContext();
|
|
registerCaseRoutes(app, ctx as never);
|
|
installRouteErrorHandler(app);
|
|
await app.ready();
|
|
|
|
return { app, ctx };
|
|
}
|
|
|
|
describe('case-routes', () => {
|
|
let harness: CaseRouteHarness;
|
|
|
|
beforeEach(async () => {
|
|
harness = await createEnvelopeHarness();
|
|
vi.clearAllMocks();
|
|
|
|
// Default: existsSync returns false, readFile throws ENOENT
|
|
mockedExistsSync.mockReturnValue(false);
|
|
mockedReadFile.mockRejectedValue(Object.assign(new Error('ENOENT'), { code: 'ENOENT' }));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await harness.app.close();
|
|
});
|
|
|
|
// ========== GET /api/cases ==========
|
|
|
|
describe('GET /api/cases', () => {
|
|
it('returns empty array when no cases exist', async () => {
|
|
mockedReaddir.mockRejectedValue(new Error('ENOENT'));
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data).toEqual([]);
|
|
});
|
|
|
|
it('returns cases from CASES_DIR', async () => {
|
|
mockedReaddir.mockResolvedValue([
|
|
{ name: 'my-case', isDirectory: () => true },
|
|
{ name: 'other-case', isDirectory: () => true },
|
|
{ name: 'readme.txt', isDirectory: () => false },
|
|
] as never);
|
|
// No CLAUDE.md exists
|
|
mockedExistsSync.mockReturnValue(false);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.data).toHaveLength(2);
|
|
expect(body.data[0].name).toBe('my-case');
|
|
expect(body.data[1].name).toBe('other-case');
|
|
expect(body.data[0].hasClaudeMd).toBe(false);
|
|
});
|
|
|
|
it('includes hasClaudeMd flag', async () => {
|
|
mockedReaddir.mockResolvedValue([{ name: 'case-with-md', isDirectory: () => true }] as never);
|
|
mockedExistsSync.mockReturnValue(true);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.data[0].hasClaudeMd).toBe(true);
|
|
});
|
|
|
|
it('includes linked cases from linked-cases.json', async () => {
|
|
// CASES_DIR readdir returns one case
|
|
mockedReaddir.mockResolvedValue([{ name: 'regular-case', isDirectory: () => true }] as never);
|
|
// linked-cases.json is read second (after CASES_DIR readdir)
|
|
let readCallCount = 0;
|
|
mockedReadFile.mockImplementation(async () => {
|
|
readCallCount++;
|
|
if (readCallCount === 1) {
|
|
return JSON.stringify({ 'linked-project': '/home/user/projects/linked' });
|
|
}
|
|
throw Object.assign(new Error('ENOENT'), { code: 'ENOENT' });
|
|
});
|
|
// existsSync: path exists for linked case, CLAUDE.md check
|
|
mockedExistsSync.mockImplementation((p: string) => {
|
|
if (typeof p === 'string' && p.includes('linked')) return true;
|
|
return false;
|
|
});
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
// Should have both regular and linked cases
|
|
expect(body.data.length).toBeGreaterThanOrEqual(1);
|
|
});
|
|
});
|
|
|
|
describe('remote host and remote case routes', () => {
|
|
function setupRemoteConfigStore() {
|
|
const store = new Map<string, string>();
|
|
mockedReadFile.mockImplementation(async (path) => {
|
|
const key = String(path);
|
|
if (store.has(key)) return store.get(key) || '';
|
|
throw Object.assign(new Error('ENOENT'), { code: 'ENOENT' });
|
|
});
|
|
mockedWriteFile.mockImplementation(async (path, data) => {
|
|
store.set(String(path), String(data));
|
|
});
|
|
}
|
|
|
|
it('creates a remote host and lists it', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
const create = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: {
|
|
id: 'gpu-box',
|
|
label: 'GPU Box',
|
|
host: '10.0.0.42',
|
|
username: 'ubuntu',
|
|
commands: { codex: 'exec codx personal' },
|
|
},
|
|
});
|
|
expect(create.statusCode).toBe(200);
|
|
expect(JSON.parse(create.body)).toMatchObject({ success: true });
|
|
|
|
const list = await harness.app.inject({ method: 'GET', url: '/api/remote-hosts' });
|
|
expect(list.statusCode).toBe(200);
|
|
expect(JSON.parse(list.body).data).toEqual([
|
|
expect.objectContaining({ id: 'gpu-box', label: 'GPU Box', commands: { codex: 'exec codx personal' } }),
|
|
]);
|
|
});
|
|
|
|
// COD-107 — advanced SSH connection options (port, identity, SOCKS proxy,
|
|
// jump host, escape-hatch -o options) round-trip through the host schema.
|
|
it('persists advanced SSH options (port/identity/socks/jump/extra) on a remote host', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
const create = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: {
|
|
id: 'aa-desktop',
|
|
label: 'aa-desktop',
|
|
host: '192.168.55.170',
|
|
username: 'aakht',
|
|
port: 2222,
|
|
identityFile: '~/.ssh/remote_ed25519',
|
|
socksProxy: '127.0.0.1:1080',
|
|
jumpHost: 'bastion@10.0.0.1:22',
|
|
extraSshOptions: ['StrictHostKeyChecking=accept-new'],
|
|
},
|
|
});
|
|
expect(create.statusCode).toBe(200);
|
|
expect(JSON.parse(create.body)).toMatchObject({ success: true });
|
|
|
|
const list = await harness.app.inject({ method: 'GET', url: '/api/remote-hosts' });
|
|
expect(JSON.parse(list.body).data).toEqual([
|
|
expect.objectContaining({
|
|
id: 'aa-desktop',
|
|
port: 2222,
|
|
identityFile: '~/.ssh/remote_ed25519',
|
|
socksProxy: '127.0.0.1:1080',
|
|
jumpHost: 'bastion@10.0.0.1:22',
|
|
extraSshOptions: ['StrictHostKeyChecking=accept-new'],
|
|
}),
|
|
]);
|
|
});
|
|
|
|
it('rejects a malformed extraSshOptions entry (not KEY=VALUE) with INVALID_INPUT', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
const create = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: {
|
|
id: 'bad-host',
|
|
label: 'bad',
|
|
host: '10.0.0.9',
|
|
username: 'ubuntu',
|
|
extraSshOptions: ['not a valid option'],
|
|
},
|
|
});
|
|
expect(create.statusCode).toBe(httpStatusForErrorCode(ApiErrorCode.INVALID_INPUT));
|
|
expect(JSON.parse(create.body)).toMatchObject({ success: false, errorCode: ApiErrorCode.INVALID_INPUT });
|
|
});
|
|
|
|
it('rejects a malformed socksProxy (missing port) with INVALID_INPUT', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
const create = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: { id: 'bad2', label: 'bad2', host: '10.0.0.9', username: 'ubuntu', socksProxy: '127.0.0.1' },
|
|
});
|
|
expect(create.statusCode).toBe(httpStatusForErrorCode(ApiErrorCode.INVALID_INPUT));
|
|
expect(JSON.parse(create.body)).toMatchObject({ success: false });
|
|
});
|
|
|
|
it('links a remote case and includes it in GET /api/cases', async () => {
|
|
setupRemoteConfigStore();
|
|
mockedReaddir.mockRejectedValue(new Error('ENOENT'));
|
|
|
|
await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: { id: 'gpu-box', label: 'GPU Box', host: '10.0.0.42', username: 'ubuntu' },
|
|
});
|
|
|
|
const link = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/remote-link',
|
|
payload: { name: 'gpu-work', hostId: 'gpu-box', remotePath: '/home/ubuntu/work' },
|
|
});
|
|
expect(link.statusCode).toBe(200);
|
|
|
|
const cases = await harness.app.inject({ method: 'GET', url: '/api/cases' });
|
|
expect(JSON.parse(cases.body).data).toContainEqual(
|
|
expect.objectContaining({
|
|
name: 'gpu-work',
|
|
location: 'remote',
|
|
path: 'ubuntu@10.0.0.42:/home/ubuntu/work',
|
|
remote: expect.objectContaining({ hostId: 'gpu-box', path: '/home/ubuntu/work' }),
|
|
})
|
|
);
|
|
});
|
|
|
|
it('prefers remote case metadata over a same-name local managed case', async () => {
|
|
setupRemoteConfigStore();
|
|
mockedReaddir.mockResolvedValue([{ name: 'gpu-work', isDirectory: () => true }] as never);
|
|
|
|
await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: { id: 'gpu-box', label: 'GPU Box', host: '10.0.0.42', username: 'ubuntu' },
|
|
});
|
|
await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/remote-link',
|
|
payload: { name: 'gpu-work', hostId: 'gpu-box', remotePath: '/home/ubuntu/work' },
|
|
});
|
|
mockedExistsSync.mockReturnValue(true);
|
|
|
|
const cases = await harness.app.inject({ method: 'GET', url: '/api/cases' });
|
|
expect(JSON.parse(cases.body).data).toContainEqual(
|
|
expect.objectContaining({
|
|
name: 'gpu-work',
|
|
location: 'remote',
|
|
path: 'ubuntu@10.0.0.42:/home/ubuntu/work',
|
|
})
|
|
);
|
|
});
|
|
|
|
it('deletes remote case metadata only', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: { id: 'gpu-box', label: 'GPU Box', host: '10.0.0.42', username: 'ubuntu' },
|
|
});
|
|
await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/remote-link',
|
|
payload: { name: 'gpu-work', hostId: 'gpu-box', remotePath: '/home/ubuntu/work' },
|
|
});
|
|
|
|
const deleted = await harness.app.inject({ method: 'DELETE', url: '/api/cases/gpu-work' });
|
|
expect(deleted.statusCode).toBe(200);
|
|
expect(JSON.parse(deleted.body)).toEqual({ success: true, data: { name: 'gpu-work' } });
|
|
});
|
|
|
|
// Injection hardening: remotePath/identityFile are shell-escaped, then embedded
|
|
// via JSON.stringify() inside `bash -c "..."` — a DOUBLE-quote layer that
|
|
// re-exposes `$(...)`/backticks even inside the inner single quotes. The schema
|
|
// MUST reject those before they reach the launch command.
|
|
it('rejects an identityFile containing $(...) command substitution', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
const create = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: {
|
|
id: 'evil-host',
|
|
label: 'evil',
|
|
host: '10.0.0.9',
|
|
username: 'ubuntu',
|
|
identityFile: '/home/u/$(touch /tmp/pwned)',
|
|
},
|
|
});
|
|
expect(create.statusCode).toBe(httpStatusForErrorCode(ApiErrorCode.INVALID_INPUT));
|
|
expect(JSON.parse(create.body)).toMatchObject({ success: false, errorCode: ApiErrorCode.INVALID_INPUT });
|
|
});
|
|
|
|
it('rejects an identityFile containing a backtick', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
const create = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: {
|
|
id: 'evil-host2',
|
|
label: 'evil2',
|
|
host: '10.0.0.9',
|
|
username: 'ubuntu',
|
|
identityFile: '/home/u/`touch /tmp/pwned`',
|
|
},
|
|
});
|
|
expect(create.statusCode).toBe(httpStatusForErrorCode(ApiErrorCode.INVALID_INPUT));
|
|
expect(JSON.parse(create.body)).toMatchObject({ success: false, errorCode: ApiErrorCode.INVALID_INPUT });
|
|
});
|
|
|
|
it('rejects a remotePath containing $(...) command substitution', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: { id: 'gpu-box', label: 'GPU Box', host: '10.0.0.42', username: 'ubuntu' },
|
|
});
|
|
const link = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/remote-link',
|
|
payload: { name: 'gpu-work', hostId: 'gpu-box', remotePath: '/tmp/$(touch /tmp/pwned)' },
|
|
});
|
|
expect(link.statusCode).toBe(httpStatusForErrorCode(ApiErrorCode.INVALID_INPUT));
|
|
expect(JSON.parse(link.body)).toMatchObject({ success: false, errorCode: ApiErrorCode.INVALID_INPUT });
|
|
});
|
|
|
|
it('rejects a remotePath containing a backtick', async () => {
|
|
setupRemoteConfigStore();
|
|
|
|
await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: { id: 'gpu-box', label: 'GPU Box', host: '10.0.0.42', username: 'ubuntu' },
|
|
});
|
|
const link = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/remote-link',
|
|
payload: { name: 'gpu-work', hostId: 'gpu-box', remotePath: '/tmp/`touch /tmp/pwned`' },
|
|
});
|
|
expect(link.statusCode).toBe(httpStatusForErrorCode(ApiErrorCode.INVALID_INPUT));
|
|
expect(JSON.parse(link.body)).toMatchObject({ success: false, errorCode: ApiErrorCode.INVALID_INPUT });
|
|
});
|
|
|
|
it('refuses remote-link when the remote host lacks tmux (courtesy prereq probe)', async () => {
|
|
setupRemoteConfigStore();
|
|
mockedCheckRemoteTmux.mockResolvedValueOnce({
|
|
ok: false,
|
|
error: 'remote host 10.0.0.42 needs tmux installed for durable remote sessions',
|
|
});
|
|
|
|
await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/remote-hosts',
|
|
payload: { id: 'gpu-box', label: 'GPU Box', host: '10.0.0.42', username: 'ubuntu' },
|
|
});
|
|
const link = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/remote-link',
|
|
payload: { name: 'gpu-work', hostId: 'gpu-box', remotePath: '/home/ubuntu/work' },
|
|
});
|
|
expect(link.statusCode).toBe(httpStatusForErrorCode(ApiErrorCode.OPERATION_FAILED));
|
|
expect(JSON.parse(link.body)).toMatchObject({ success: false, errorCode: ApiErrorCode.OPERATION_FAILED });
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/cases ==========
|
|
|
|
describe('POST /api/cases', () => {
|
|
it('rejects invalid case name', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases',
|
|
payload: { name: 'invalid case name!!' },
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('rejects missing name', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases',
|
|
payload: {},
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('rejects path traversal in name', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases',
|
|
payload: { name: '../etc' },
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('rejects duplicate case name', async () => {
|
|
mockedExistsSync.mockReturnValue(true);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases',
|
|
payload: { name: 'existing-case' },
|
|
});
|
|
expect(res.statusCode).toBe(409);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
expect(body.error).toContain('already exists');
|
|
});
|
|
|
|
it('creates case directory with CLAUDE.md and hooks config', async () => {
|
|
mockedExistsSync.mockReturnValue(false);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases',
|
|
payload: { name: 'new-case', description: 'A new test case' },
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.case.name).toBe('new-case');
|
|
expect(body.data.case.path).toContain('new-case');
|
|
|
|
// Verify directory creation
|
|
expect(mockedMkdirSync).toHaveBeenCalled();
|
|
|
|
// Verify broadcast
|
|
expect(harness.ctx.broadcast).toHaveBeenCalledWith('case:created', expect.objectContaining({ name: 'new-case' }));
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/cases/link ==========
|
|
|
|
describe('POST /api/cases/link', () => {
|
|
it('rejects invalid request body', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/link',
|
|
payload: { name: 'bad name!' },
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('rejects missing fields', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/link',
|
|
payload: {},
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('returns not found when folder does not exist', async () => {
|
|
mockedExistsSync.mockReturnValue(false);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/link',
|
|
payload: { name: 'my-project', path: '/nonexistent/path' },
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
expect(body.error).toContain('not found');
|
|
});
|
|
|
|
it('rejects when case name already exists in CASES_DIR', async () => {
|
|
// First call (expandedPath check) returns true, second (casePath check) also returns true
|
|
mockedExistsSync.mockReturnValue(true);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/link',
|
|
payload: { name: 'existing-case', path: '/home/user/project' },
|
|
});
|
|
expect(res.statusCode).toBe(409);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
expect(body.error).toContain('already exists');
|
|
});
|
|
|
|
it('links folder successfully', async () => {
|
|
// expandedPath exists (first call), casePath does not (second call)
|
|
let callIdx = 0;
|
|
mockedExistsSync.mockImplementation(() => {
|
|
callIdx++;
|
|
return callIdx === 1; // first: folder exists, second: case dir doesn't
|
|
});
|
|
// linked-cases.json doesn't exist yet
|
|
mockedReadFile.mockRejectedValue(Object.assign(new Error('ENOENT'), { code: 'ENOENT' }));
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/cases/link',
|
|
payload: { name: 'linked-project', path: '/home/user/project' },
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.case.name).toBe('linked-project');
|
|
expect(harness.ctx.broadcast).toHaveBeenCalledWith(
|
|
'case:linked',
|
|
expect.objectContaining({ name: 'linked-project' })
|
|
);
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/cases/:name ==========
|
|
|
|
describe('GET /api/cases/:name', () => {
|
|
it('returns linked case info', async () => {
|
|
mockedReadFile.mockResolvedValue(JSON.stringify({ 'my-case': '/home/user/my-case' }) as never);
|
|
mockedExistsSync.mockReturnValue(true);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.name).toBe('my-case');
|
|
expect(body.data.linked).toBe(true);
|
|
});
|
|
|
|
it('returns CASES_DIR case when no linked case found', async () => {
|
|
// linked-cases.json read fails
|
|
mockedReadFile.mockRejectedValue(Object.assign(new Error('ENOENT'), { code: 'ENOENT' }));
|
|
// case dir exists
|
|
mockedExistsSync.mockReturnValue(true);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/regular-case',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.name).toBe('regular-case');
|
|
});
|
|
|
|
it('returns error when case not found anywhere', async () => {
|
|
mockedReadFile.mockRejectedValue(Object.assign(new Error('ENOENT'), { code: 'ENOENT' }));
|
|
mockedExistsSync.mockReturnValue(false);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/nonexistent',
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
expect(body.error).toContain('not found');
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/cases/:name/fix-plan ==========
|
|
|
|
describe('GET /api/cases/:name/fix-plan', () => {
|
|
it('returns exists=false when no fix plan file', async () => {
|
|
mockedReadFile.mockRejectedValue(Object.assign(new Error('ENOENT'), { code: 'ENOENT' }));
|
|
mockedExistsSync.mockReturnValue(false);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case/fix-plan',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.exists).toBe(false);
|
|
expect(body.data.content).toBeNull();
|
|
expect(body.data.todos).toEqual([]);
|
|
});
|
|
|
|
it('parses fix plan with todos and stats', async () => {
|
|
const fixPlanContent = [
|
|
'# Fix Plan',
|
|
'## High Priority',
|
|
'- [ ] Fix critical bug',
|
|
'- [-] Working on auth',
|
|
'- [x] Setup database',
|
|
'## Standard',
|
|
'- [ ] Add logging',
|
|
'## Completed',
|
|
'- [x] Initial setup',
|
|
].join('\n');
|
|
|
|
mockedReadFile.mockRejectedValue(Object.assign(new Error('ENOENT'), { code: 'ENOENT' }));
|
|
mockedExistsSync.mockImplementation((p: string) => {
|
|
if (typeof p === 'string' && p.includes('fix_plan')) return true;
|
|
return false;
|
|
});
|
|
|
|
// Override readFile for the fix plan read
|
|
mockedReadFile.mockImplementation(async (p: string) => {
|
|
if (typeof p === 'string' && p.includes('fix_plan')) {
|
|
return fixPlanContent as never;
|
|
}
|
|
throw Object.assign(new Error('ENOENT'), { code: 'ENOENT' });
|
|
});
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case/fix-plan',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.exists).toBe(true);
|
|
expect(body.data.todos.length).toBeGreaterThan(0);
|
|
expect(body.data.stats.total).toBeGreaterThan(0);
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/cases/:caseName/ralph-wizard/files ==========
|
|
|
|
describe('GET /api/cases/:caseName/ralph-wizard/files', () => {
|
|
it('returns error when wizard directory not found', async () => {
|
|
mockedExistsSync.mockReturnValue(false);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case/ralph-wizard/files',
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
expect(body.error).toContain('not found');
|
|
});
|
|
|
|
it('rejects path traversal in case name', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/..%2F..%2Fetc/ralph-wizard/files',
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('returns wizard files when directory exists', async () => {
|
|
mockedExistsSync.mockImplementation((p: string) => {
|
|
if (typeof p === 'string' && p.includes('ralph-wizard')) return true;
|
|
if (typeof p === 'string' && p.includes('prompt.md')) return true;
|
|
if (typeof p === 'string' && p.includes('result.json')) return true;
|
|
return false;
|
|
});
|
|
mockedReaddirSync.mockReturnValue([
|
|
{ name: 'research', isDirectory: () => true },
|
|
{ name: 'planner', isDirectory: () => true },
|
|
] as never);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case/ralph-wizard/files',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.files).toHaveLength(2);
|
|
expect(body.data.files[0].agentType).toBe('research');
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/cases/:caseName/ralph-wizard/file/:filePath ==========
|
|
|
|
describe('GET /api/cases/:caseName/ralph-wizard/file/:filePath', () => {
|
|
it('returns error for missing file', async () => {
|
|
mockedExistsSync.mockReturnValue(false);
|
|
mockedReadFile.mockRejectedValue(Object.assign(new Error('ENOENT'), { code: 'ENOENT' }));
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case/ralph-wizard/file/research%2Fprompt.md',
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('returns markdown file content', async () => {
|
|
mockedExistsSync.mockReturnValue(false);
|
|
mockedReadFile.mockResolvedValue('# Research Prompt\nContent here' as never);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case/ralph-wizard/file/research%2Fprompt.md',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.content).toContain('Research Prompt');
|
|
expect(body.data.isJson).toBe(false);
|
|
});
|
|
|
|
it('parses JSON file content', async () => {
|
|
mockedExistsSync.mockReturnValue(false);
|
|
const jsonContent = JSON.stringify({ plan: 'test plan', steps: [1, 2, 3] });
|
|
mockedReadFile.mockResolvedValue(jsonContent as never);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case/ralph-wizard/file/planner%2Fresult.json',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.isJson).toBe(true);
|
|
expect(body.data.parsed.plan).toBe('test plan');
|
|
});
|
|
|
|
it('sets no-cache headers', async () => {
|
|
mockedExistsSync.mockReturnValue(false);
|
|
mockedReadFile.mockResolvedValue('content' as never);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/cases/my-case/ralph-wizard/file/research%2Fprompt.md',
|
|
});
|
|
expect(res.headers['cache-control']).toContain('no-store');
|
|
});
|
|
});
|
|
});
|