Codeman

mirror of https://github.com/Ark0N/Codeman.git synced 2026-09-30 20:49:41 +02:00

Files

T

Claude (Codeman maintainer) 5fbe451c26 fix(attachments): harden document preview/thumbnail path (review of #120 )

Follow-up hardening applied during review of PR #120, addressing the
adversarial multi-agent findings:

- fix(preview): render auto-detected (workspace, unregistered) DOCX/PPTX via
  the file-preview route and PDFs via file-raw in openFilePreview. Previously
  the Preview button fell through to file-content, dumping the binary Office/PDF
  bytes as mojibake, and the new file-preview route was unreachable dead code.
  (MAJOR: file-preview-route-unreachable-detected-office)

- perf(convert): add a global converter-concurrency limiter
  (document-conversion-limiter.ts) wrapping every pdftoppm / soffice /
  powershell spawn, so N simultaneous preview/thumbnail requests can no longer
  fork unbounded converter processes. Default cap 3, CODEMAN_MAX_DOCUMENT_CONVERSIONS.
  (MAJOR: no-converter-concurrency-limit)

- fix(cache): bound the converted-PDF disk cache with LRU-by-mtime eviction
  (pruneDocumentPreviewCache, default 100 files, CODEMAN_MAX_PREVIEW_CACHE_FILES),
  run after each successful conversion. Was unbounded.
  (MAJOR/MINOR: preview-cache-unbounded-disk-growth)

Tests: document-conversion-limiter.test.ts, document-preview-cache-eviction.test.ts,
and route coverage for the four new endpoints in
routes/file-routes-preview-thumbnail.test.ts (closes the missing-route-test gap).
Verified end-to-end against real pdftoppm (thumbnail render + concurrency cap).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-14 08:43:57 +02:00

_route-test-utils.ts

test: repair route harness error rendering + stop AI-checker spawning real processes in tests (#97 )

2026-05-25 23:55:57 +02:00

case-routes.test.ts

feat(api): establish stable HTTP contract — uniform {success,data} envelope, status codes, /api/v1

2026-06-10 01:30:43 +02:00

file-routes-attachment-path-guard.test.ts

fix(attachments): harden registry + close magic-link injection vector

2026-06-11 10:27:09 +02:00

file-routes-preview-thumbnail.test.ts

fix(attachments): harden document preview/thumbnail path (review of #120 )