mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
arkonandClaude Opus 4.8
458fb81cbe
Point 1 of the v1.0 lock-in: commit to a stable HTTP API (the cleanest, fullest form).
Core (centralized):
- Every JSON /api response now uses ONE envelope via a Fastify preSerialization hook (src/web/server.ts): success -> { success:true, data:<payload> }; error -> { success:false, error, errorCode } with a conventional HTTP status. Non-JSON routes (file-raw, tail-file SSE, download, screenshots, /q redirect, WS) are skipped.
- Error-code -> HTTP status is a single source of truth (httpStatusForErrorCode in src/types/api.ts): 400/401/404/409/422/429/500. Expanded ApiErrorCode (added UNAUTHORIZED, CONFLICT, RATE_LIMITED). Errors are no longer HTTP 200.
- Versioned alias: /api/v1/* rewrites to /api/* (rewriteApiV1Url), so external clients pin to a stable surface while the bundled UI keeps using /api/*.
- Handlers stripped of manual 'success:true' (50 across 14 route files) so they return bare payloads the hook wraps uniformly; fixed the mux DELETE {success:<bool>} envelope collision (-> {killed}).
Frontend (48 call sites across 10 files):
- _apiJson() auto-unwraps { success:true, data } -> data (null on error), so most bare-shape readers are transparent. Raw-fetch sites relocate payload reads under .data; success/res.ok/error checks unchanged.
Docs: new docs/api-reference.md (envelope, status table, error codes, /api/v1, SSE); versioning-policy.md flipped — the HTTP/SSE API is now part of the stable, SemVer-covered surface.
Verification: full unit/route suite green (2680 passed) incl. ~166 updated assertions across 24 test files; typecheck/lint/format/frontend-syntax clean; a headless-chromium smoke loaded the migrated UI and drove the panels with 0 console/page errors; /api/status and /api/v1/status confirmed returning the uniform envelope live.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
666 lines
22 KiB
TypeScript
666 lines
22 KiB
TypeScript
/**
|
|
* @fileoverview Tests for session route handlers.
|
|
*
|
|
* Uses app.inject() (Fastify's built-in test helper) — no real HTTP ports needed.
|
|
* Port: N/A (app.inject doesn't open ports)
|
|
*
|
|
* These tests assert the UNIFORM response envelope (stable HTTP contract):
|
|
* success -> 2xx, { success: true, data: <payload> }
|
|
* error -> 4xx/5xx, { success: false, error, errorCode }
|
|
* The production server applies this via a preSerialization hook (server.ts).
|
|
* The shared route harness doesn't install it, so we build a local harness here
|
|
* that mirrors production: the same preSerialization envelope hook + the shared
|
|
* route error handler, so assertions match the real wire format.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
|
|
import Fastify, { type FastifyInstance } from 'fastify';
|
|
import fastifyCookie from '@fastify/cookie';
|
|
import { createMockRouteContext, type MockRouteContext } from '../mocks/index.js';
|
|
import { installRouteErrorHandler } from '../../src/web/route-error-handler.js';
|
|
import { ApiErrorCode, httpStatusForErrorCode } from '../../src/types.js';
|
|
|
|
// Mock execFile so the send-key route's `tmux` invocation is observable (not run for real).
|
|
const { execFile } = vi.hoisted(() => ({ execFile: vi.fn() }));
|
|
vi.mock('node:child_process', async (orig) => {
|
|
const actual = await orig<typeof import('node:child_process')>();
|
|
return { ...actual, execFile };
|
|
});
|
|
|
|
import { registerSessionRoutes } from '../../src/web/routes/session-routes.js';
|
|
|
|
interface LocalHarness {
|
|
app: FastifyInstance;
|
|
ctx: MockRouteContext;
|
|
}
|
|
|
|
/**
|
|
* Build a Fastify instance that mirrors production's uniform-envelope behavior
|
|
* (server.ts preSerialization hook) so the test wire format matches the contract:
|
|
* bare payloads become { success: true, data }, and { success:false } error
|
|
* envelopes get the conventional HTTP status from their errorCode.
|
|
*/
|
|
async function createEnvelopeHarness(
|
|
registerFn: (app: FastifyInstance, ctx: MockRouteContext) => void
|
|
): Promise<LocalHarness> {
|
|
const app = Fastify({ logger: false });
|
|
await app.register(fastifyCookie);
|
|
|
|
const ctx = createMockRouteContext();
|
|
registerFn(app, ctx);
|
|
|
|
// Mirror production uniform response envelope (server.ts).
|
|
app.addHook('preSerialization', (req, reply, payload: unknown, done) => {
|
|
if (!req.url.startsWith('/api')) return done(null, payload);
|
|
if (payload === null || typeof payload !== 'object') return done(null, payload);
|
|
if (Buffer.isBuffer(payload) || typeof (payload as { pipe?: unknown }).pipe === 'function') {
|
|
return done(null, payload);
|
|
}
|
|
const p = payload as { success?: unknown; errorCode?: unknown };
|
|
if (p.success === false) {
|
|
if (reply.statusCode === 200 && typeof p.errorCode === 'string') {
|
|
reply.code(httpStatusForErrorCode(p.errorCode as ApiErrorCode));
|
|
}
|
|
return done(null, payload);
|
|
}
|
|
if (p.success === true) return done(null, payload);
|
|
return done(null, { success: true, data: payload });
|
|
});
|
|
|
|
installRouteErrorHandler(app);
|
|
await app.ready();
|
|
|
|
return { app, ctx };
|
|
}
|
|
|
|
describe('session-routes', () => {
|
|
let harness: LocalHarness;
|
|
|
|
beforeEach(async () => {
|
|
harness = await createEnvelopeHarness(registerSessionRoutes);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await harness.app.close();
|
|
});
|
|
|
|
// ========== POST /api/sessions/:id/send-key ==========
|
|
|
|
describe('POST /api/sessions/:id/send-key', () => {
|
|
it('routes tmux send-keys through the dedicated Codeman socket (-L)', async () => {
|
|
// Regression guard: bare `tmux` would hit the user's default server and never
|
|
// find a session that lives only on the Codeman socket (#80 regression class).
|
|
execFile.mockReset();
|
|
execFile.mockImplementation((_bin: string, _argv: string[], _opts: unknown, cb: (e: Error | null) => void) =>
|
|
cb(null)
|
|
);
|
|
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/sessions/test-session-1/send-key',
|
|
payload: { key: 'S-Enter' },
|
|
});
|
|
|
|
expect(res.statusCode).toBe(200);
|
|
expect(execFile).toHaveBeenCalledTimes(1);
|
|
const [bin, argv] = execFile.mock.calls[0];
|
|
expect(bin).toBe('tmux');
|
|
expect((argv as string[]).slice(0, 2)).toEqual(['-L', 'codeman']);
|
|
expect(argv).toContain('send-keys');
|
|
expect(argv).toContain('-H');
|
|
});
|
|
|
|
it('rejects keys outside the hex allowlist without invoking tmux', async () => {
|
|
execFile.mockReset();
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/sessions/test-session-1/send-key',
|
|
payload: { key: 'rm -rf' },
|
|
});
|
|
expect(JSON.parse(res.body).success).toBe(false);
|
|
expect(execFile).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/sessions ==========
|
|
|
|
describe('GET /api/sessions', () => {
|
|
it('returns session list when sessions exist', async () => {
|
|
const res = await harness.app.inject({ method: 'GET', url: '/api/sessions' });
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(Array.isArray(body.data)).toBe(true);
|
|
expect(body.data).toHaveLength(1);
|
|
});
|
|
|
|
it('returns empty array when no sessions', async () => {
|
|
harness.ctx.sessions.clear();
|
|
const res = await harness.app.inject({ method: 'GET', url: '/api/sessions' });
|
|
expect(res.statusCode).toBe(200);
|
|
expect(JSON.parse(res.body).data).toEqual([]);
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/sessions/:id ==========
|
|
|
|
describe('GET /api/sessions/:id', () => {
|
|
it('returns session state for existing session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: `/api/sessions/${harness.ctx._sessionId}`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.data.id).toBe(harness.ctx._sessionId);
|
|
});
|
|
|
|
it('returns error for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/sessions/nonexistent',
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
expect(body.error).toBeDefined();
|
|
});
|
|
});
|
|
|
|
// ========== DELETE /api/sessions/:id ==========
|
|
|
|
describe('DELETE /api/sessions/:id', () => {
|
|
it('deletes existing session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'DELETE',
|
|
url: `/api/sessions/${harness.ctx._sessionId}`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(harness.ctx.cleanupSession).toHaveBeenCalledWith(harness.ctx._sessionId, true, 'user_delete');
|
|
});
|
|
|
|
it('returns error for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'DELETE',
|
|
url: '/api/sessions/nonexistent',
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== DELETE /api/sessions (delete all) ==========
|
|
|
|
describe('DELETE /api/sessions', () => {
|
|
it('deletes all sessions', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'DELETE',
|
|
url: '/api/sessions',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.killed).toBe(1);
|
|
expect(harness.ctx.cleanupSession).toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
// ========== PUT /api/sessions/:id/name ==========
|
|
|
|
describe('PUT /api/sessions/:id/name', () => {
|
|
it('renames session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'PUT',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/name`,
|
|
payload: { name: 'new-name' },
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.name).toBe('new-name');
|
|
expect(harness.ctx.persistSessionState).toHaveBeenCalled();
|
|
expect(harness.ctx.broadcast).toHaveBeenCalledWith('session:updated', expect.anything());
|
|
});
|
|
|
|
it('returns error for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'PUT',
|
|
url: '/api/sessions/nonexistent/name',
|
|
payload: { name: 'test' },
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== PUT /api/sessions/:id/color ==========
|
|
|
|
describe('PUT /api/sessions/:id/color', () => {
|
|
it('sets session color', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'PUT',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/color`,
|
|
payload: { color: 'blue' },
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.color).toBe('blue');
|
|
});
|
|
|
|
it('rejects invalid color', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'PUT',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/color`,
|
|
payload: { color: 'neon-rainbow' },
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/sessions/:id/input ==========
|
|
|
|
describe('POST /api/sessions/:id/input', () => {
|
|
it('sends input to session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/input`,
|
|
payload: { input: 'hello' },
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
});
|
|
|
|
it('returns error for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/sessions/nonexistent/input',
|
|
payload: { input: 'hello' },
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('rejects empty payload', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/input`,
|
|
payload: {},
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/sessions/:id/resize ==========
|
|
|
|
describe('POST /api/sessions/:id/resize', () => {
|
|
it('resizes session terminal', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/resize`,
|
|
payload: { cols: 120, rows: 40 },
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(harness.ctx._session.resize).toHaveBeenCalledWith(120, 40);
|
|
});
|
|
|
|
it('rejects cols exceeding max (500)', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/resize`,
|
|
payload: { cols: 501, rows: 24 },
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('rejects rows exceeding max (200)', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/resize`,
|
|
payload: { cols: 80, rows: 201 },
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('rejects zero dimensions', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/resize`,
|
|
payload: { cols: 0, rows: 24 },
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/sessions/:id/terminal ==========
|
|
|
|
describe('GET /api/sessions/:id/terminal', () => {
|
|
it('returns terminal buffer', async () => {
|
|
harness.ctx._session.terminalBuffer = 'hello world';
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/terminal`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.data.terminalBuffer).toBeDefined();
|
|
});
|
|
|
|
it('returns error for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/sessions/nonexistent/terminal',
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/sessions/:id/run ==========
|
|
|
|
describe('POST /api/sessions/:id/run', () => {
|
|
it('runs prompt on session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/run`,
|
|
payload: { prompt: 'do something' },
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
});
|
|
|
|
it('rejects empty prompt', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/run`,
|
|
payload: { prompt: '' },
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('returns error for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/sessions/nonexistent/run',
|
|
payload: { prompt: 'test' },
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('returns error if session is busy', async () => {
|
|
harness.ctx._session.isBusy.mockReturnValue(true);
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/run`,
|
|
payload: { prompt: 'test' },
|
|
});
|
|
expect(res.statusCode).toBe(409);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/sessions/:id/interactive ==========
|
|
|
|
describe('POST /api/sessions/:id/interactive', () => {
|
|
it('starts interactive mode', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/interactive`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(harness.ctx._session.startInteractive).toHaveBeenCalled();
|
|
});
|
|
|
|
it('returns error for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/sessions/nonexistent/interactive',
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('returns error if session is busy', async () => {
|
|
harness.ctx._session.isBusy.mockReturnValue(true);
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/interactive`,
|
|
});
|
|
expect(res.statusCode).toBe(409);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/sessions/:id/shell ==========
|
|
|
|
describe('POST /api/sessions/:id/shell', () => {
|
|
it('starts shell mode', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/shell`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(harness.ctx._session.startShell).toHaveBeenCalled();
|
|
});
|
|
|
|
it('returns error if session is busy', async () => {
|
|
harness.ctx._session.isBusy.mockReturnValue(true);
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/shell`,
|
|
});
|
|
expect(res.statusCode).toBe(409);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/sessions/:id/output ==========
|
|
|
|
describe('GET /api/sessions/:id/output', () => {
|
|
it('returns session output data', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/output`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data).toHaveProperty('textOutput');
|
|
expect(body.data).toHaveProperty('messages');
|
|
expect(body.data).toHaveProperty('errorBuffer');
|
|
});
|
|
|
|
it('returns error for unknown session', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/sessions/nonexistent/output',
|
|
});
|
|
expect(res.statusCode).toBe(404);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/sessions/:id/ralph-state ==========
|
|
|
|
describe('GET /api/sessions/:id/ralph-state', () => {
|
|
it('returns ralph state data', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/ralph-state`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data).toHaveProperty('loop');
|
|
expect(body.data).toHaveProperty('todos');
|
|
expect(body.data).toHaveProperty('todoStats');
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/sessions/:id/active-tools ==========
|
|
|
|
describe('GET /api/sessions/:id/active-tools', () => {
|
|
it('returns active tools', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: `/api/sessions/${harness.ctx._sessionId}/active-tools`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data).toHaveProperty('tools');
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/logout ==========
|
|
|
|
describe('POST /api/logout', () => {
|
|
it('returns success', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/logout',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
});
|
|
});
|
|
|
|
// ========== GET /api/history/sessions ==========
|
|
|
|
describe('GET /api/history/sessions', () => {
|
|
it('returns sessions array', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/history/sessions',
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.data).toHaveProperty('sessions');
|
|
expect(Array.isArray(body.data.sessions)).toBe(true);
|
|
});
|
|
|
|
it('sessions have required fields', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/history/sessions',
|
|
});
|
|
const body = JSON.parse(res.body);
|
|
for (const session of body.data.sessions) {
|
|
expect(session).toHaveProperty('sessionId');
|
|
expect(session).toHaveProperty('workingDir');
|
|
expect(session).toHaveProperty('projectKey');
|
|
expect(session).toHaveProperty('sizeBytes');
|
|
expect(session).toHaveProperty('lastModified');
|
|
// sessionId must be a valid UUID
|
|
expect(session.sessionId).toMatch(/^[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}$/);
|
|
}
|
|
});
|
|
|
|
it('sessions are sorted by lastModified descending', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/history/sessions',
|
|
});
|
|
const body = JSON.parse(res.body);
|
|
const dates = body.data.sessions.map((s: { lastModified: string }) => new Date(s.lastModified).getTime());
|
|
for (let i = 1; i < dates.length; i++) {
|
|
expect(dates[i - 1]).toBeGreaterThanOrEqual(dates[i]);
|
|
}
|
|
});
|
|
|
|
it('returns at most 50 sessions', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'GET',
|
|
url: '/api/history/sessions',
|
|
});
|
|
const body = JSON.parse(res.body);
|
|
expect(body.data.sessions.length).toBeLessThanOrEqual(50);
|
|
});
|
|
});
|
|
|
|
// ========== POST /api/sessions (with resumeSessionId) ==========
|
|
|
|
describe('POST /api/sessions with resumeSessionId', () => {
|
|
it('creates session with valid resumeSessionId', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/sessions',
|
|
payload: {
|
|
name: 'resume-test',
|
|
mode: 'claude',
|
|
workingDir: process.env.HOME || '/tmp',
|
|
resumeSessionId: 'a1b2c3d4-e5f6-7890-abcd-ef1234567890',
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
expect(body.data.session).toBeDefined();
|
|
});
|
|
|
|
it('rejects invalid resumeSessionId format', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/sessions',
|
|
payload: {
|
|
name: 'bad-resume',
|
|
mode: 'claude',
|
|
workingDir: process.env.HOME || '/tmp',
|
|
resumeSessionId: 'not-a-uuid',
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(400);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(false);
|
|
});
|
|
|
|
it('creates session without resumeSessionId (optional field)', async () => {
|
|
const res = await harness.app.inject({
|
|
method: 'POST',
|
|
url: '/api/sessions',
|
|
payload: {
|
|
name: 'no-resume',
|
|
mode: 'claude',
|
|
workingDir: process.env.HOME || '/tmp',
|
|
},
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const body = JSON.parse(res.body);
|
|
expect(body.success).toBe(true);
|
|
});
|
|
});
|
|
});
|