mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
Two required fixes from Ark0N's review of #458: 1. test/frontend-cli-no-id-branching.test.ts's ALLOWED_BRANCHES keyed on <file>::<line>::<expression>. A single inserted line anywhere above an entry shifted every subsequent line number, so all 21 entries went stale simultaneously and the same 21 branches were reported as "new" — on a file six other open PRs also touch. Dropped the line number from the key (<file>::<expression>, matching the backend guard's own design), which collapses 21 line-keyed entries to 11 or-collapse where the same expression recurs at multiple call sites in the same file. 2. test/run-mode-ui.test.ts's terminal-ownership guard scanned method bodies via `^ {2}async (run[A-Za-z]*)\(\) \{$`, which matched the 8 one-line run<Mode>() wrappers PR B2 introduced but not _runCliMode(mode), where the real logic (and the actual risk the guard exists to catch) now lives. Fixed the regex to `^ {2}async (_?run[A-Za-z]*)\(\w*\) \{$` and added _runCliMode to the sanity list. Same-class fix in test/opencode-resize.test.ts, which had the identical blind spot via runOpenCode.toString(). Both reproduced live before fixing (inserted the same comment line; added this.terminal.clear() to _runCliMode) to confirm the bug, then confirmed the fix catches it and the suite stays green otherwise. Also resolves Open Question 2 by dropping window.__codemanCliCatalog entirely: nothing consumed it, and a registry DECLARED_FOR_LATER field costs nothing until read while an unconsumed script tag on every page render is a different trade. Reverts Phase 1 cleanly — server.ts's injection, shortBadge back in types.ts's DECLARED_FOR_LATER list and the pinned guard test, and the three associated render-index-html.test.ts / server-index-title.test.ts assertions. Full gate: 405 files / 7717 tests / 0 failures (net unchanged), typecheck/ lint/format clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GuHtuPiHXdykq9T6rKQJ9n
351 lines
12 KiB
TypeScript
351 lines
12 KiB
TypeScript
/**
|
|
* OpenCode session UI tests
|
|
*
|
|
* Tests OpenCode-specific UI behavior:
|
|
* - Initial terminal resize (not stuck at 120x40)
|
|
* - Close modal shows "Kill Tmux & OpenCode" (not "Claude Code")
|
|
* - needsRefresh handler sends resize
|
|
*
|
|
* Port: 3211 (opencode UI tests)
|
|
*
|
|
* Run: npx vitest run test/opencode-resize.test.ts
|
|
*/
|
|
|
|
import { describe, it, expect, beforeAll, afterAll } from 'vitest';
|
|
import { chromium, type Browser, type BrowserContext, type Page } from 'playwright';
|
|
import { WebServer } from '../src/web/server.js';
|
|
|
|
const PORT = 3211;
|
|
const BASE_URL = `http://localhost:${PORT}`;
|
|
|
|
let server: WebServer;
|
|
let browser: Browser;
|
|
|
|
async function freshPage(): Promise<{ context: BrowserContext; page: Page }> {
|
|
const context = await browser.newContext({
|
|
viewport: { width: 1280, height: 800 },
|
|
});
|
|
const page = await context.newPage();
|
|
return { context, page };
|
|
}
|
|
|
|
async function navigateAndWait(page: Page): Promise<void> {
|
|
await page.goto(BASE_URL, { waitUntil: 'domcontentloaded' });
|
|
await page.waitForFunction(() => document.body.classList.contains('app-loaded'), {
|
|
timeout: 5000,
|
|
});
|
|
}
|
|
|
|
beforeAll(async () => {
|
|
server = new WebServer(PORT, false, true); // testMode
|
|
await server.start();
|
|
browser = await chromium.launch({ headless: true });
|
|
}, 30_000);
|
|
|
|
afterAll(async () => {
|
|
await browser?.close();
|
|
await server?.stop();
|
|
}, 30_000);
|
|
|
|
describe('OpenCode session initial resize', () => {
|
|
let context: BrowserContext;
|
|
let page: Page;
|
|
|
|
afterAll(async () => {
|
|
await context?.close();
|
|
});
|
|
|
|
it('selectSession is not bypassed when the shared launcher sets activeSessionId', async () => {
|
|
// This test verifies at the code level that the OpenCode launch path does
|
|
// NOT pre-set activeSessionId before calling selectSession. If it did,
|
|
// selectSession would early-return and skip sendResize.
|
|
//
|
|
// PR B2 consolidated runOpenCode() (and 7 siblings) into one shared
|
|
// _runCliMode(mode) — runOpenCode is now a one-line wrapper
|
|
// (`return this._runCliMode('opencode')`), so inspecting ITS source would
|
|
// never see the real launch logic and this check would pass vacuously
|
|
// regardless of what _runCliMode actually does. Inspect _runCliMode itself.
|
|
({ context, page } = await freshPage());
|
|
await navigateAndWait(page);
|
|
|
|
const hasPreAssignment = await page.evaluate(() => {
|
|
const app = (window as unknown as { app: { _runCliMode: { toString: () => string } } }).app;
|
|
const source = app._runCliMode.toString();
|
|
|
|
// Check: the source should NOT have activeSessionId = ... before selectSession
|
|
// Find positions of both patterns
|
|
const assignIdx = source.indexOf('this.activeSessionId = data.sessionId');
|
|
const selectIdx = source.indexOf('this.selectSession(data.sessionId)');
|
|
|
|
// If assign doesn't exist at all, that's the correct fix
|
|
if (assignIdx === -1) return false;
|
|
|
|
// If assign comes before select, that's the bug
|
|
return assignIdx < selectIdx;
|
|
});
|
|
|
|
expect(hasPreAssignment).toBe(false);
|
|
});
|
|
|
|
it('sends resize to server after creating a session via quick-start', async () => {
|
|
({ context, page } = await freshPage());
|
|
await navigateAndWait(page);
|
|
|
|
// Intercept resize API calls to track when they happen
|
|
const resizeCalls: Array<{ url: string; cols: number; rows: number }> = [];
|
|
await page.route('**/api/sessions/*/resize', async (route) => {
|
|
const request = route.request();
|
|
const body = request.postDataJSON();
|
|
resizeCalls.push({
|
|
url: request.url(),
|
|
cols: body.cols,
|
|
rows: body.rows,
|
|
});
|
|
// Let the request through to the server
|
|
await route.continue();
|
|
});
|
|
|
|
// Create a session via API (simulating what quick-start does)
|
|
const sessionId = await page.evaluate(async () => {
|
|
const res = await fetch('/api/sessions', {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ workingDir: '/tmp', name: 'oc-resize-test' }),
|
|
});
|
|
const data = await res.json();
|
|
return data.id ?? data.session?.id;
|
|
});
|
|
|
|
expect(sessionId).toBeTruthy();
|
|
|
|
// Call selectSession (which is what runOpenCode does after fix)
|
|
await page.evaluate(async (sid: string) => {
|
|
const app = (window as unknown as { app: { selectSession: (id: string) => Promise<void> } }).app;
|
|
await app.selectSession(sid);
|
|
}, sessionId);
|
|
|
|
// Wait for the resize to be sent (it's fire-and-forget in selectSession)
|
|
await page.waitForTimeout(500);
|
|
|
|
// Verify resize was called with reasonable dimensions (not 120x40 default)
|
|
expect(resizeCalls.length).toBeGreaterThanOrEqual(1);
|
|
const lastResize = resizeCalls[resizeCalls.length - 1];
|
|
expect(lastResize.url).toContain(sessionId);
|
|
// Browser viewport is 1280x800 — terminal cols/rows should be substantially
|
|
// different from the hardcoded 120x40 default. xterm.js calculates these
|
|
// from container dimensions and cell size, but in headless mode with a
|
|
// 1280x800 viewport, we should get something reasonable (>= 40 cols).
|
|
expect(lastResize.cols).toBeGreaterThanOrEqual(40);
|
|
expect(lastResize.rows).toBeGreaterThanOrEqual(10);
|
|
|
|
console.log(`[opencode-resize] resize sent: ${lastResize.cols}x${lastResize.rows}`);
|
|
|
|
// Cleanup
|
|
await page.evaluate(async (sid: string) => {
|
|
await fetch(`/api/sessions/${sid}`, { method: 'DELETE' });
|
|
}, sessionId);
|
|
});
|
|
|
|
it('selectSession does NOT early-return for a new session', async () => {
|
|
({ context, page } = await freshPage());
|
|
await navigateAndWait(page);
|
|
|
|
// Create a session
|
|
const sessionId = await page.evaluate(async () => {
|
|
const res = await fetch('/api/sessions', {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ workingDir: '/tmp', name: 'oc-earlyret-test' }),
|
|
});
|
|
const data = await res.json();
|
|
return data.id ?? data.session?.id;
|
|
});
|
|
|
|
expect(sessionId).toBeTruthy();
|
|
|
|
// Verify activeSessionId is NOT the new session before selectSession
|
|
const activeBeforeSelect = await page.evaluate(() => {
|
|
const app = (window as unknown as { app: { activeSessionId: string | null } }).app;
|
|
return app.activeSessionId;
|
|
});
|
|
|
|
// activeSessionId should be null or empty (welcome screen) — not our session
|
|
expect(activeBeforeSelect).not.toBe(sessionId);
|
|
|
|
// Now call selectSession and verify it actually runs (sets activeSessionId)
|
|
await page.evaluate(async (sid: string) => {
|
|
const app = (window as unknown as { app: { selectSession: (id: string) => Promise<void> } }).app;
|
|
await app.selectSession(sid);
|
|
}, sessionId);
|
|
|
|
const activeAfterSelect = await page.evaluate(() => {
|
|
const app = (window as unknown as { app: { activeSessionId: string | null } }).app;
|
|
return app.activeSessionId;
|
|
});
|
|
|
|
expect(activeAfterSelect).toBe(sessionId);
|
|
|
|
// Cleanup
|
|
await page.evaluate(async (sid: string) => {
|
|
await fetch(`/api/sessions/${sid}`, { method: 'DELETE' });
|
|
}, sessionId);
|
|
});
|
|
|
|
it('needsRefresh handler includes sendResize call', async () => {
|
|
// The needsRefresh handler is registered inside a closure (connectSSE),
|
|
// so we can't directly invoke it from tests. Instead, verify that the
|
|
// handler source code dispatched to the EventSource includes sendResize.
|
|
// This is a structural test — if the handler code changes, this test
|
|
// ensures the resize call is preserved.
|
|
({ context, page } = await freshPage());
|
|
await navigateAndWait(page);
|
|
|
|
// Dispatch a needsRefresh event on the EventSource and intercept
|
|
// the resulting resize API call
|
|
const sessionId = await page.evaluate(async () => {
|
|
const res = await fetch('/api/sessions', {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ workingDir: '/tmp', name: 'oc-refresh-test' }),
|
|
});
|
|
const data = await res.json();
|
|
return data.id ?? data.session?.id;
|
|
});
|
|
|
|
expect(sessionId).toBeTruthy();
|
|
|
|
// Select the session first so activeSessionId is set
|
|
await page.evaluate(async (sid: string) => {
|
|
const app = (window as unknown as { app: { selectSession: (id: string) => Promise<void> } }).app;
|
|
await app.selectSession(sid);
|
|
}, sessionId);
|
|
|
|
await page.waitForTimeout(300);
|
|
|
|
// Intercept resize calls
|
|
const resizeCalls: Array<{ url: string }> = [];
|
|
await page.route('**/api/sessions/*/resize', async (route) => {
|
|
resizeCalls.push({ url: route.request().url() });
|
|
await route.continue();
|
|
});
|
|
|
|
// Exercise the SSE fallback path. While WebSocket owns terminal I/O these
|
|
// duplicate SSE terminal events are intentionally ignored.
|
|
await page.evaluate((sid: string) => {
|
|
const app = (window as unknown as { app: { eventSource: EventSource; _disconnectWs: () => void } }).app;
|
|
app._disconnectWs();
|
|
if (app.eventSource) {
|
|
const event = new MessageEvent('session:needsRefresh', {
|
|
data: JSON.stringify({ id: sid }),
|
|
});
|
|
app.eventSource.dispatchEvent(event);
|
|
}
|
|
}, sessionId);
|
|
|
|
// Wait for the async handler (fetches /terminal buffer + sends resize)
|
|
await page.waitForTimeout(1500);
|
|
|
|
// Verify resize was called
|
|
expect(resizeCalls.length).toBeGreaterThanOrEqual(1);
|
|
console.log(`[opencode-resize] needsRefresh triggered ${resizeCalls.length} resize call(s)`);
|
|
|
|
// Cleanup
|
|
await page.route('**/api/sessions/*/resize', (route) => route.continue());
|
|
await page.evaluate(async (sid: string) => {
|
|
await fetch(`/api/sessions/${sid}`, { method: 'DELETE' });
|
|
}, sessionId);
|
|
});
|
|
});
|
|
|
|
describe('OpenCode close modal text', () => {
|
|
let context: BrowserContext;
|
|
let page: Page;
|
|
|
|
afterAll(async () => {
|
|
await context?.close();
|
|
});
|
|
|
|
it('shows "Kill Tmux & OpenCode" for opencode sessions', async () => {
|
|
({ context, page } = await freshPage());
|
|
await navigateAndWait(page);
|
|
|
|
// Create a session and mark it as opencode mode
|
|
const sessionId = await page.evaluate(async () => {
|
|
const res = await fetch('/api/sessions', {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ workingDir: '/tmp', name: 'oc-close-test', mode: 'opencode' }),
|
|
});
|
|
const data = await res.json();
|
|
return data.id ?? data.session?.id;
|
|
});
|
|
|
|
expect(sessionId).toBeTruthy();
|
|
|
|
// Wait for SSE to propagate the session
|
|
await page.waitForTimeout(500);
|
|
|
|
// Open the close confirmation modal
|
|
await page.evaluate((sid: string) => {
|
|
const app = (window as unknown as { app: { requestCloseSession: (id: string) => void } }).app;
|
|
app.requestCloseSession(sid);
|
|
}, sessionId);
|
|
|
|
// Check the kill button text
|
|
const killTitle = await page.locator('#closeConfirmKillTitle').textContent();
|
|
expect(killTitle).toBe('Kill Tmux & OpenCode');
|
|
|
|
// Close the modal
|
|
await page.evaluate(() => {
|
|
const app = (window as unknown as { app: { cancelCloseSession: () => void } }).app;
|
|
app.cancelCloseSession();
|
|
});
|
|
|
|
// Cleanup
|
|
await page.evaluate(async (sid: string) => {
|
|
await fetch(`/api/sessions/${sid}`, { method: 'DELETE' });
|
|
}, sessionId);
|
|
});
|
|
|
|
it('shows "Kill Tmux & Claude Code" for claude sessions', async () => {
|
|
({ context, page } = await freshPage());
|
|
await navigateAndWait(page);
|
|
|
|
// Create a standard claude session
|
|
const sessionId = await page.evaluate(async () => {
|
|
const res = await fetch('/api/sessions', {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ workingDir: '/tmp', name: 'cc-close-test' }),
|
|
});
|
|
const data = await res.json();
|
|
return data.id ?? data.session?.id;
|
|
});
|
|
|
|
expect(sessionId).toBeTruthy();
|
|
|
|
await page.waitForTimeout(500);
|
|
|
|
// Open the close confirmation modal
|
|
await page.evaluate((sid: string) => {
|
|
const app = (window as unknown as { app: { requestCloseSession: (id: string) => void } }).app;
|
|
app.requestCloseSession(sid);
|
|
}, sessionId);
|
|
|
|
// Check the kill button text
|
|
const killTitle = await page.locator('#closeConfirmKillTitle').textContent();
|
|
expect(killTitle).toBe('Kill Tmux & Claude Code');
|
|
|
|
// Close the modal
|
|
await page.evaluate(() => {
|
|
const app = (window as unknown as { app: { cancelCloseSession: () => void } }).app;
|
|
app.cancelCloseSession();
|
|
});
|
|
|
|
// Cleanup
|
|
await page.evaluate(async (sid: string) => {
|
|
await fetch(`/api/sessions/${sid}`, { method: 'DELETE' });
|
|
}, sessionId);
|
|
});
|
|
});
|