mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
DevvynandClaude Opus 5
4830e662f9
Every run mode is now a `CliEntry` in `src/config/cli-registry/` — discovery (search dirs, version + identity probes), the launch argv template, env handling, the `capabilities` flags that replace per-CLI branching, and the `overlays` that back the remote/docker pane commands. Code that used to ask "which CLI is this?" reads the entry instead. Behaviour is unchanged. `test/cli-registry-spawn-golden.test.ts` pins every spawn command as a literal string, captured from the hand-written builders before they were deleted, and `test/location-overlay-commands.test.ts` does the same for all 20 remote and in-container pane commands. Config can never contain shell text: an entry declares typed argv tokens, literals are validated against a safe-word pattern at LOAD time (a bad literal rejects the whole entry — a silently dropped `--no-approve` is not cosmetic), and values resolve through patterns NAMED in code, so a user `clis.json` cannot widen its own validation. `~/.codeman/clis.json` overrides any entry, read-only in this release. OMP is included as a registry entry rather than a tenth hand-written builder, so `buildOmpCommand()`, the omp availability pre-flight, the omp arm of `buildPathExport()` and the omp entries in the truecolor/NO_COLOR, alt-screen and doctor ladders all drop out. Guard rails: - `test/cli-registry-no-id-branching.test.ts` fails the build if per-CLI-id branching reappears outside `stock.ts`, in any of its four shapes (`===`, `!==`, `switch`/`case`, `includes`) — an `===`-only version would miss the negated forms, which is how 36 of them survived an earlier pass. Every allowlisted branch carries its reason. - `external`, `hooks` and `altScreen` stay three INDEPENDENT capabilities; deriving one from another shipped the `until=stop`-hangs-on-shell bug. - `param` is two namespaces. `launch.params` keys, `configSetenv.fromParam` and `privilegedParams[].param` all name a LAUNCH param; the legacy `<Mode>Config` wire field is separate, bridged only by `legacyConfigAliases`. Getting `privilegedParams[].param` wrong is SILENT — it is the multi-user bypass clamp's only handle on a CLI's privilege switch, and a wrong name clamps nothing with no error and no failing test — so `schema.ts` rejects an entry naming a param it never declared. - Registry data resolves AT CALL TIME (`sessionModeSchema()`, `allowedEnvPrefixes()`, `dependencyRegistry()`, the resolvers' `searchDirs` thunks). A module-level const freezes at first import, so a CLI enabled while the server ran moved the run menu but not that surface. - Six fields are annotated DECLARED-FOR-LATER and read by nothing (`shortBadge`, `accent`, `capabilities.echo`/`wheelForward`/ `keyboardAccessory`/`maxFrameBytes`): all frontend behaviour, transcribed rather than measured. A test pins the list so it cannot quietly grow. Three user-visible changes, all deliberate and named: - `probeDockerCliVersion()` derives the in-container binary from the registry rather than assuming it equals the mode name (`antigravity` runs `agy`). - The remote CLI version probe now covers grok and deepseek, which the hardcoded map it replaces omitted while its own comment said the rule was "every mode except shell". - `codeman doctor`'s CLI rows are generated from the entries, so Claude's install hint is the install command rather than a docs URL, five CLIs gain hints they never had, and the row order follows the catalog. Also hardened along the way: `sessionModeSchema()` is bounded at 24 chars (matching the `cliId` pattern) before its failure message quotes the value back, and `deepMerge` skips `__proto__`/`constructor`/`prototype` when reading the hand-editable `clis.json`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQkoi1cNegqVwZHgzx5SbJ
64 lines
2.7 KiB
TypeScript
64 lines
2.7 KiB
TypeScript
/**
|
|
* @fileoverview Golden pins for the remote/docker LOCATION OVERLAY commands, now that both
|
|
* are read from `overlays.<location>` on the registry entry rather than from a hardcoded
|
|
* `Record<…CommandMode, string>` in each file.
|
|
*
|
|
* The literals below are transcribed from those two tables as they stood BEFORE the wiring,
|
|
* which is the whole point: the tables were dead-simple duplicates of registry data with
|
|
* nothing keeping the two in step, and the way to delete a duplicate safely is to pin what it
|
|
* produced first. A diff here means an entry's `overlays` (or its first declared binary)
|
|
* changed what a remote or in-container pane actually runs.
|
|
*
|
|
* Note the two arms deliberately NOT read from an entry, each for its own reason: remote
|
|
* `shell` resolves the REMOTE user's login shell (unknowable from here, hence `$SHELL`), and
|
|
* docker `shell` is the entry that declares `docker: { disabled: true }` — a container has no
|
|
* per-user login shell to resolve, so it gets a plain `bash -l`.
|
|
*
|
|
* Port: none (pure, over registry data).
|
|
*/
|
|
|
|
import { it, expect } from 'vitest';
|
|
import { defaultRemoteCommandForMode, remoteLoginShellCommand } from '../src/remote-hosts.js';
|
|
import { defaultDockerCommandForMode } from '../src/docker-hosts.js';
|
|
import type { SessionMode } from '../src/types/session.js';
|
|
|
|
const REMOTE_LOGIN_SHELL = '"${SHELL:-/bin/sh}"';
|
|
|
|
it('pins every remote pane command', () => {
|
|
const expected: Record<string, string> = {
|
|
shell: `exec ${REMOTE_LOGIN_SHELL} -i -l`,
|
|
claude: remoteLoginShellCommand('claude --dangerously-skip-permissions'),
|
|
opencode: remoteLoginShellCommand('opencode'),
|
|
codex: remoteLoginShellCommand('codex'),
|
|
gemini: remoteLoginShellCommand('gemini'),
|
|
antigravity: remoteLoginShellCommand('agy'),
|
|
pi: remoteLoginShellCommand('pi'),
|
|
grok: remoteLoginShellCommand('grok'),
|
|
deepseek: remoteLoginShellCommand('dsh'),
|
|
omp: remoteLoginShellCommand('omp'),
|
|
};
|
|
for (const [mode, want] of Object.entries(expected)) {
|
|
expect(defaultRemoteCommandForMode(mode as SessionMode), mode).toBe(want);
|
|
}
|
|
expect(defaultRemoteCommandForMode('nope' as SessionMode)).toBe(expected.shell);
|
|
});
|
|
|
|
it('pins every in-container pane command', () => {
|
|
const expected: Record<string, string> = {
|
|
shell: 'exec bash -l',
|
|
claude: 'exec claude --dangerously-skip-permissions',
|
|
opencode: 'exec opencode',
|
|
codex: 'exec codex',
|
|
gemini: 'exec gemini',
|
|
antigravity: 'exec agy',
|
|
pi: 'exec pi',
|
|
grok: 'exec grok',
|
|
deepseek: 'exec dsh',
|
|
omp: 'exec omp',
|
|
};
|
|
for (const [mode, want] of Object.entries(expected)) {
|
|
expect(defaultDockerCommandForMode(mode as SessionMode), mode).toBe(want);
|
|
}
|
|
expect(defaultDockerCommandForMode('nope' as SessionMode)).toBe('exec bash -l');
|
|
});
|