mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
Codeman maintainer
d9123de9eb
Closes #211. Copying from the terminal only worked through the browser context menu, because xterm turns Ctrl+C into 0x03 and cancels the keydown, so the muscle-memory copy failed silently and read as "no copy-paste at all". With a selection, Ctrl+C now copies it, toasts, clears the selection and sends nothing to the PTY. With no selection it falls through unchanged, so the interrupt is intact. Ctrl+Shift+C is an explicit copy chord that never falls through: an explicit copy that interrupts a running agent because the selection happened to be empty would be a footgun. Three details that keep the interrupt safe: - The decision lives in attachCustomKeyEventHandler (terminal-ui.js) and the no-selection path returns true WITHOUT preventDefault. xterm calls the custom handler before its own cancel(), so returning false alone does not cancel the event; the copy path therefore calls preventDefault explicitly, or the browser would run its native copy on top of ours. - copy-selection is a full registry entry (rebindable and disableable in App Settings) whose action is deliberately absent from SHORTCUT_ACTIONS, the same trick command-palette uses: the generic capture loop preventDefaults every match it dispatches, which would cost the user the interrupt key. - The gate is keydown-only, since the custom handler also runs for keypress and keyup. Copy goes through _copyText (Clipboard API, then hidden-textarea + execCommand) rather than raw navigator.clipboard, because install.sh's LAN option serves plain HTTP where navigator.clipboard is undefined; the fallback steals focus, so the terminal is refocused afterwards. Tests: test/terminal-copy-selection.test.ts pins the gate and the SHORTCUT_ACTIONS invariant; test/terminal-copy-shortcut.test.ts drives real key presses in chromium and asserts on the clipboard plus the bytes xterm emitted (browser-driven, so excluded from test:ci like the other Playwright suites). Verified manually on an isolated beta instance before landing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
74 lines
3.5 KiB
TypeScript
74 lines
3.5 KiB
TypeScript
import { readFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { describe, expect, it } from 'vitest';
|
|
|
|
const INDEX_HTML = readFileSync(join(process.cwd(), 'src/web/public/index.html'), 'utf-8');
|
|
|
|
function normalizedHtml(value: string): string {
|
|
return value.replace(/\s+/g, ' ');
|
|
}
|
|
|
|
function extractElementById(html: string, id: string): string {
|
|
const idIndex = html.indexOf(`id="${id}"`);
|
|
expect(idIndex, `expected #${id} to exist`).toBeGreaterThanOrEqual(0);
|
|
|
|
const start = html.lastIndexOf('<', idIndex);
|
|
expect(start, `expected #${id} start tag`).toBeGreaterThanOrEqual(0);
|
|
|
|
// Bound at the next HTML comment (every following section is comment-labeled) so
|
|
// sections inserted between this element and any fixed marker don't leak into the
|
|
// slice — the cron modal's "Run At" text false-positived the stale-shortcut check.
|
|
const nextSection = html.indexOf('<!--', idIndex);
|
|
expect(nextSection, `expected section marker after #${id}`).toBeGreaterThanOrEqual(0);
|
|
|
|
const end = nextSection;
|
|
return html.slice(start, end);
|
|
}
|
|
|
|
function escapeRegExp(value: string): string {
|
|
return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
|
|
}
|
|
|
|
function expectShortcut(html: string, keys: string[], label: string): void {
|
|
const keyPattern = keys.map((key) => `<kbd>${escapeRegExp(key)}</kbd>`).join('\\s*\\+\\s*');
|
|
expect(html).toMatch(new RegExp(`${keyPattern}.*?${label}`, 'i'));
|
|
}
|
|
|
|
describe('help modal shortcuts', () => {
|
|
const helpModal = normalizedHtml(extractElementById(INDEX_HTML, 'helpModal'));
|
|
|
|
it('documents implemented global and tab shortcuts', () => {
|
|
expectShortcut(helpModal, ['Ctrl', 'W'], 'Close Session');
|
|
expectShortcut(helpModal, ['Ctrl', 'Tab'], 'Next Session');
|
|
expectShortcut(helpModal, ['Alt/Option', '['], 'Previous / Next Session');
|
|
expectShortcut(helpModal, ['Alt/Option', ']'], 'Previous / Next Session');
|
|
expectShortcut(helpModal, ['Alt/Option', '1-9'], 'Switch to Tab N');
|
|
expectShortcut(helpModal, ['Ctrl', '{'], 'Move Active Tab Left');
|
|
expectShortcut(helpModal, ['Ctrl', '}'], 'Move Active Tab Right');
|
|
expectShortcut(helpModal, ['Ctrl', '?'], 'Show Shortcuts');
|
|
expect(helpModal).not.toMatch(/Ctrl<\/kbd>\s*\+\s*<kbd>\/<\/kbd>.*?Show Shortcuts/i);
|
|
expectShortcut(helpModal, ['Ctrl', 'Shift', 'V'], 'Voice Input');
|
|
expectShortcut(helpModal, ['Escape'], 'Close Panels');
|
|
});
|
|
|
|
it('documents terminal input shortcuts without advertising stale run shortcuts', () => {
|
|
expectShortcut(helpModal, ['Ctrl', 'C'], 'Copy Selection');
|
|
expectShortcut(helpModal, ['Ctrl', 'Shift', 'C'], 'Copy Selection');
|
|
expectShortcut(helpModal, ['Ctrl', 'L'], 'Clear Terminal');
|
|
expectShortcut(helpModal, ['Ctrl', '+'], 'Increase Font');
|
|
expectShortcut(helpModal, ['Ctrl', '-'], 'Decrease Font');
|
|
expectShortcut(helpModal, ['Shift', 'Enter'], 'Insert Newline');
|
|
expectShortcut(helpModal, ['Ctrl', 'Enter'], 'Insert Newline');
|
|
// Ctrl+Shift+R (restore terminal size) is still dispatched — keep it documented.
|
|
expectShortcut(helpModal, ['Ctrl', 'Shift', 'R'], 'Restore Terminal Size');
|
|
|
|
expect(helpModal).not.toMatch(/Ctrl<\/kbd>\s*\+\s*<kbd>K<\/kbd>/i);
|
|
expect(helpModal).not.toMatch(/Ctrl<\/kbd>\s*\+\s*<kbd>Enter<\/kbd>.*?(Run|Start)/i);
|
|
});
|
|
|
|
it('does not advertise the removed Ctrl+Enter run binding in launch UI hints', () => {
|
|
expect(INDEX_HTML).not.toContain('Or press <kbd>Ctrl</kbd>+<kbd>Enter</kbd> to start');
|
|
expect(INDEX_HTML).not.toContain('title="Run (Ctrl+Enter)"');
|
|
});
|
|
});
|