Commit Graph
3 Commits
Author SHA1 Message Date
Codeman maintainer 432bd5fc0a fix(codex): #546 landing review follow-up
Pin the App Settings codexModel guard to the schema. The 28df21f4 landing fix
added a client check in saveAppSettings() that copies the pattern of
SettingsUpdateSchema.codexModel, so one bad character no longer 400s the whole
.strict() settings PUT behind a "Settings saved" toast. Nothing tied the copy
to the schema: a looser copy would bring the silent 400 back, and a stricter
one would refuse valid model ids.

The new test extracts the client pattern from the saveAppSettings() body,
checks it agrees with the schema on eight samples (empty, dotted, slashed,
colon, space, semicolon, leading dash, non-ASCII), and asserts the guard runs
before the localStorage write. Length is left out on purpose, since the
input's maxlength="100" covers .max(100). Both a loosened pattern and a guard
moved after the write turn the test red.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-09 06:11:18 +02:00
shenlvkang-collab c30128d3f0 fix(codex): limit launch defaults to local sessions 2026-10-07 17:48:46 +08:00
shenlvkang-collab 16e44aa1d1 feat(codex): add synced model and reasoning defaults 2026-10-07 17:34:25 +08:00