Codeman

2,161 Commits 65 Branches 195 Tags

2 Commits

Include renames

Author SHA1 Message Date

Author	SHA1	Message	Date
DevvynandClaude Sonnet 5	a0628a40e8	fix(cli-registry): address maintainer review on #380 Rebased onto current master (the one real conflict was the import line in docker-hosts.ts Ark0N flagged; kept both), then addressed every point from the review: 1. Rebase. Done — this branch now sits on current upstream/master. 2. Agent-image special cases are data now, not an id-keyed table outside stock.ts. `AGENT_IMAGE_SPECIAL_CASE_IDS`/`AGENT_IMAGE_SPECIAL_CASES` are gone. `CliDiscovery.install.agentImageLayer?: { kind: 'dedicated'; reason: string }` is a field on the registry entry itself (pi, deepseek), `reason` is required by schema.ts, both producers (docker-hosts.ts and cli-catalog.mjs) filter on its presence instead of an id, and the coverage test reads it from the generated catalogue. Also added the npm-package-name validation to the TS producer, which only the .mjs one had — same SAFE_PACKAGE regex, duplicated (necessarily, one side can't import the other) and now pinned byte-identical by a new parity test. 3. Changeset said five, it's eight. (Not nine — see the DeepSeek point below, which changes the true count.) Reworded to state it structurally rather than pin a number that will go stale again. Then the four behavior-changing findings: - DeepSeek was offered as a normal install option but can't actually drive a pane. `npm install -g @deepseek-ai/dsh` installs the launcher only; DeepSeek ships no profile that can run standalone. The generator now emits an empty install command for any `launcherProfile` entry, so install.sh's menu (which requires a non-empty command) skips it and falls through to its docs URL hint instead — matching what the old hand-written code did before this PR replaced it. - wget-only hosts lost every automatic install, including the npm ones that never needed curl. The menu-building loop now filters PER ENTRY (only a command starting with `curl ` is held back) rather than wiping the whole menu when DOWNLOADER != curl. - The DISPLAY/TRUSTED split and the catalogue refresh didn't hold up under review (refresh's only real write was the label; it ran before the Node existence check; its own eval-detection test was tripped by the word "eval'd" in a comment). Dropped entirely per your own recommendation — embedded catalogue only, no network fetch, no second array. install-sh-invariants.test.ts now asserts the refresh/DISPLAY machinery does not exist rather than testing its internals. The three take-or-leave items, applied: - `dsh_banner_probe`'s bash 3.2 empty-array bug: `${runner[@]}` → `${runner[@]+"${runner[@]}"}`. Verified live in a real `bash:3.2.57` container with `timeout` removed from PATH — crashed before, clean now, full `detect_all_clis` path exercised end to end. - `docker-agent-image-coverage.test.ts` now anchors on each layer's `<binary> --version` proof line instead of `Dockerfile.includes(binary)`, which stayed true if a layer were deleted but its comment survived. - Doc drift: docs/docker-cases.md (four → five, and now describes the data field), docker/agent.Dockerfile's "other four CLIs" comment (no longer a magic number — CLI_NPM_PACKAGES is generated and can grow), CLAUDE.md's install.sh size (104KB → ~112KB) and its stale mention of the now-dropped refresh. Verified: tsc clean, prettier clean, the full targeted suite (142 tests across the 8 affected files) green, and the full `npm test` gate diffed BY TEST NAME against a clean upstream/master baseline run on this same machine — identical 201-name failure set both sides (168 tests / 67 files, all pre-existing Windows-environment noise: symlinks, PTY spawning, POSIX permission bits — none of it touching anything this PR changes), zero new failures either side of the diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9ZSTEenc8soSu9bTi8Xru	2026-09-13 17:43:14 +08:00
DevvynandClaude Opus 5	1ca35095e7	refactor(install): drive CLI detection, the install menu and hints from the catalogue install.sh carried nine search-path arrays, eighteen near-identical check_<cli>/get_<cli>_path functions, and three separately hand-maintained enumerations of all nine CLIs. They had to agree and did not: upstream `b6d0f1fa` is "wire OMP into install.sh's CLI detection (it had none)", and the section comment above the roll-call named six of the nine. All of it now reads the generated catalogue. `detect_all_clis` resolves every CLI in one memoized pass into CLI_FOUND_PATH/CLI_FOUND_COUNT; `check_cli` and `get_cli_path` replace the eighteen pairs; the roll-call, the "no AI CLI found" gate and the closing reminder become loops. Probe order per CLI is unchanged and `test/install-sh-detection-parity.test.ts` proves it against the literals transcribed from the arrays this deletes. Behaviour changes worth naming: - The install menu is built from the catalogue, so it offers every enabled CLI that is not installed and ships a command — five instead of two. Gemini had a command in the registry and appeared in NO list in this script. - Its labels are now the registry's ("Claude" rather than "Claude Code"), the same trade PR A made for `codeman doctor` rows. A suffix map would just be the hand-maintained list again. - On a wget-only host the menu prints commands instead of running them. The registry's commands call curl, whereas the two literals this replaces went through download_to_stdout; rewriting curl to wget inside a string we are about to execute is the wrong instinct. The trust boundary is mechanical, not a promise: CLI_INSTALL_CMD_TRUSTED is written only from the generated per-platform arrays and is the only thing ever executed; CLI_INSTALL_CMD_DISPLAY is what the optional, opt-in refresh may rewrite. The refresh warns on all three failure shapes — empty body, unparseable content, failed fetch — which is the silent-degradation bug from the review, and it parses with node into tab-separated records read by `read`, never eval. Bash 3.2 throughout (macOS ships it): parallel indexed arrays, offset/length windows instead of delimiters, no associative arrays, namerefs, mapfile or here-strings. Verified by executing the script under a real bash 3.2 container, which is also now a CI step alongside `bash -n` and a catalogue `--check` — the empty-window case (`shell` has no binaries) is a runtime `set -u` abort that `bash -n` cannot see. Running it that way caught `detect_os` being called inside the platform loop: ten forks, and ten copies of one error, since a `die` inside `$( )` can only exit the subshell. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015EMxQreQUZX5ZyybxAGh12	2026-09-13 17:43:13 +08:00

DevvynandClaude Sonnet 5

a0628a40e8

fix(cli-registry): address maintainer review on #380

Rebased onto current master (the one real conflict was the import line
in docker-hosts.ts Ark0N flagged; kept both), then addressed every
point from the review:

**1. Rebase.** Done — this branch now sits on current upstream/master.

**2. Agent-image special cases are data now, not an id-keyed table
outside stock.ts.** `AGENT_IMAGE_SPECIAL_CASE_IDS`/`AGENT_IMAGE_SPECIAL_CASES`
are gone. `CliDiscovery.install.agentImageLayer?: { kind: 'dedicated';
reason: string }` is a field on the registry entry itself (pi,
deepseek), `reason` is required by schema.ts, both producers
(docker-hosts.ts and cli-catalog.mjs) filter on its presence instead
of an id, and the coverage test reads it from the generated catalogue.
Also added the npm-package-name validation to the TS producer, which
only the .mjs one had — same SAFE_PACKAGE regex, duplicated
(necessarily, one side can't import the other) and now pinned
byte-identical by a new parity test.

**3. Changeset said five, it's eight.** (Not nine — see the DeepSeek
point below, which changes the true count.) Reworded to state it
structurally rather than pin a number that will go stale again.

Then the four behavior-changing findings:

- **DeepSeek was offered as a normal install option but can't actually
  drive a pane.** `npm install -g @deepseek-ai/dsh` installs the
  launcher only; DeepSeek ships no profile that can run standalone.
  The generator now emits an empty install command for any
  `launcherProfile` entry, so install.sh's menu (which requires a
  non-empty command) skips it and falls through to its docs URL hint
  instead — matching what the old hand-written code did before this
  PR replaced it.
- **wget-only hosts lost every automatic install, including the npm
  ones that never needed curl.** The menu-building loop now filters
  PER ENTRY (only a command starting with `curl ` is held back) rather
  than wiping the whole menu when DOWNLOADER != curl.
- **The DISPLAY/TRUSTED split and the catalogue refresh didn't hold up
  under review** (refresh's only real write was the label; it ran
  before the Node existence check; its own eval-detection test was
  tripped by the word "eval'd" in a comment). Dropped entirely per
  your own recommendation — embedded catalogue only, no network
  fetch, no second array. install-sh-invariants.test.ts now asserts
  the refresh/DISPLAY machinery does not exist rather than testing its
  internals.

The three take-or-leave items, applied:

- `dsh_banner_probe`'s bash 3.2 empty-array bug: `${runner[@]}` →
  `${runner[@]+"${runner[@]}"}`. Verified live in a real `bash:3.2.57`
  container with `timeout` removed from PATH — crashed before, clean
  now, full `detect_all_clis` path exercised end to end.
- `docker-agent-image-coverage.test.ts` now anchors on each layer's
  `<binary> --version` proof line instead of `Dockerfile.includes(binary)`,
  which stayed true if a layer were deleted but its comment survived.
- Doc drift: docs/docker-cases.md (four → five, and now describes the
  data field), docker/agent.Dockerfile's "other four CLIs" comment (no
  longer a magic number — CLI_NPM_PACKAGES is generated and can grow),
  CLAUDE.md's install.sh size (104KB → ~112KB) and its stale mention of
  the now-dropped refresh.

Verified: tsc clean, prettier clean, the full targeted suite (142
tests across the 8 affected files) green, and the full `npm test` gate
diffed BY TEST NAME against a clean upstream/master baseline run on
this same machine — identical 201-name failure set both sides (168
tests / 67 files, all pre-existing Windows-environment noise: symlinks,
PTY spawning, POSIX permission bits — none of it touching anything
this PR changes), zero new failures either side of the diff.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R9ZSTEenc8soSu9bTi8Xru

2026-09-13 17:43:14 +08:00

DevvynandClaude Opus 5

1ca35095e7

refactor(install): drive CLI detection, the install menu and hints from the catalogue

install.sh carried nine search-path arrays, eighteen near-identical
check_<cli>/get_<cli>_path functions, and three separately hand-maintained
enumerations of all nine CLIs. They had to agree and did not: upstream b6d0f1fa
is "wire OMP into install.sh's CLI detection (it had none)", and the section
comment above the roll-call named six of the nine.

All of it now reads the generated catalogue. `detect_all_clis` resolves every
CLI in one memoized pass into CLI_FOUND_PATH/CLI_FOUND_COUNT; `check_cli` and
`get_cli_path` replace the eighteen pairs; the roll-call, the "no AI CLI found"
gate and the closing reminder become loops. Probe order per CLI is unchanged and
`test/install-sh-detection-parity.test.ts` proves it against the literals
transcribed from the arrays this deletes.

Behaviour changes worth naming:

- The install menu is built from the catalogue, so it offers every enabled CLI
  that is not installed and ships a command — five instead of two. Gemini had a
  command in the registry and appeared in NO list in this script.
- Its labels are now the registry's ("Claude" rather than "Claude Code"), the
  same trade PR A made for `codeman doctor` rows. A suffix map would just be the
  hand-maintained list again.
- On a wget-only host the menu prints commands instead of running them. The
  registry's commands call curl, whereas the two literals this replaces went
  through download_to_stdout; rewriting curl to wget inside a string we are
  about to execute is the wrong instinct.

The trust boundary is mechanical, not a promise: CLI_INSTALL_CMD_TRUSTED is
written only from the generated per-platform arrays and is the only thing ever
executed; CLI_INSTALL_CMD_DISPLAY is what the optional, opt-in refresh may
rewrite. The refresh warns on all three failure shapes — empty body, unparseable
content, failed fetch — which is the silent-degradation bug from the review, and
it parses with node into tab-separated records read by `read`, never eval.

Bash 3.2 throughout (macOS ships it): parallel indexed arrays, offset/length
windows instead of delimiters, no associative arrays, namerefs, mapfile or
here-strings. Verified by executing the script under a real bash 3.2 container,
which is also now a CI step alongside `bash -n` and a catalogue `--check` — the
empty-window case (`shell` has no binaries) is a runtime `set -u` abort that
`bash -n` cannot see. Running it that way caught `detect_os` being called inside
the platform loop: ten forks, and ten copies of one error, since a `die` inside
`$( )` can only exit the subshell.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015EMxQreQUZX5ZyybxAGh12

2026-09-13 17:43:13 +08:00