2 Commits

Include renames

Author	SHA1	Message	Date
DevvynandClaude Sonnet 5	a0628a40e8	fix(cli-registry): address maintainer review on #380 ... Rebased onto current master (the one real conflict was the import line in docker-hosts.ts Ark0N flagged; kept both), then addressed every point from the review: **1. Rebase.** Done — this branch now sits on current upstream/master. **2. Agent-image special cases are data now, not an id-keyed table outside stock.ts.** `AGENT_IMAGE_SPECIAL_CASE_IDS`/`AGENT_IMAGE_SPECIAL_CASES` are gone. `CliDiscovery.install.agentImageLayer?: { kind: 'dedicated'; reason: string }` is a field on the registry entry itself (pi, deepseek), `reason` is required by schema.ts, both producers (docker-hosts.ts and cli-catalog.mjs) filter on its presence instead of an id, and the coverage test reads it from the generated catalogue. Also added the npm-package-name validation to the TS producer, which only the .mjs one had — same SAFE_PACKAGE regex, duplicated (necessarily, one side can't import the other) and now pinned byte-identical by a new parity test. **3. Changeset said five, it's eight.** (Not nine — see the DeepSeek point below, which changes the true count.) Reworded to state it structurally rather than pin a number that will go stale again. Then the four behavior-changing findings: - **DeepSeek was offered as a normal install option but can't actually drive a pane.** `npm install -g @deepseek-ai/dsh` installs the launcher only; DeepSeek ships no profile that can run standalone. The generator now emits an empty install command for any `launcherProfile` entry, so install.sh's menu (which requires a non-empty command) skips it and falls through to its docs URL hint instead — matching what the old hand-written code did before this PR replaced it. - **wget-only hosts lost every automatic install, including the npm ones that never needed curl.** The menu-building loop now filters PER ENTRY (only a command starting with `curl ` is held back) rather than wiping the whole menu when DOWNLOADER != curl. - **The DISPLAY/TRUSTED split and the catalogue refresh didn't hold up under review** (refresh's only real write was the label; it ran before the Node existence check; its own eval-detection test was tripped by the word "eval'd" in a comment). Dropped entirely per your own recommendation — embedded catalogue only, no network fetch, no second array. install-sh-invariants.test.ts now asserts the refresh/DISPLAY machinery does not exist rather than testing its internals. The three take-or-leave items, applied: - `dsh_banner_probe`'s bash 3.2 empty-array bug: `${runner[@]}` → `${runner[@]+"${runner[@]}"}`. Verified live in a real `bash:3.2.57` container with `timeout` removed from PATH — crashed before, clean now, full `detect_all_clis` path exercised end to end. - `docker-agent-image-coverage.test.ts` now anchors on each layer's `<binary> --version` proof line instead of `Dockerfile.includes(binary)`, which stayed true if a layer were deleted but its comment survived. - Doc drift: docs/docker-cases.md (four → five, and now describes the data field), docker/agent.Dockerfile's "other four CLIs" comment (no longer a magic number — CLI_NPM_PACKAGES is generated and can grow), CLAUDE.md's install.sh size (104KB → ~112KB) and its stale mention of the now-dropped refresh. Verified: tsc clean, prettier clean, the full targeted suite (142 tests across the 8 affected files) green, and the full `npm test` gate diffed BY TEST NAME against a clean upstream/master baseline run on this same machine — identical 201-name failure set both sides (168 tests / 67 files, all pre-existing Windows-environment noise: symlinks, PTY spawning, POSIX permission bits — none of it touching anything this PR changes), zero new failures either side of the diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9ZSTEenc8soSu9bTi8Xru	2026-09-13 17:43:14 +08:00
DevvynandClaude Opus 5	7d6f612ef5	feat(cli-registry): generate a CLI catalogue for install.sh and the Docker build ... Two consumers of the registry cannot import TypeScript: `install.sh`, which runs via `curl | bash` before any checkout exists, and `scripts/build-agent-image.mjs`. Both currently hand-maintain their own CLI lists, and both have already drifted. `scripts/generate-cli-catalog.mts` (`npm run generate:cli-catalog`, plus a `--check` mode) emits from `STOCK_CLIS`: - `config/clis.stock.json` for the `.mjs` and the tests. It carries `enabled` — the field the earlier attempt omitted, which is how a disabled CLI's npm package still got baked into every agent image. - a marker-delimited block inside `install.sh`, embedded rather than fetched. The embedded copy is the FULL catalogue on purpose: the earlier design fetched it and fell back to a hardcoded two-CLI list, degrading silently on an empty response. There is no degraded mode to fall into now. The block is bash 3.2 safe: parallel indexed arrays, no associative arrays, no namerefs, no mapfile. Variable-length lists use OFFSET/LENGTH windows into one flat array rather than a delimiter, so a $HOME containing a space needs no IFS handling and `shell` (no binaries) gets length 0 and is never iterated. Search paths are emitted dir-major, matching the probe order the hand-written arrays use and `test/install-sh-detection-parity.test.ts` pins. Only fields the two consumers need are exported. `launch`/`env`/`capabilities`/ `overlays` are spawn-time concerns the server alone interprets, and a test asserts they never leak into the artifact. `main()` sits behind an `isMainModule()` guard so the sync test can import the renderers. Without it, importing the module would rewrite the artifacts as a side effect of checking them — passing always, guarding never. This commit adds the block; it does not yet delete the hand-written arrays, so the detection pin keeps measuring both against each other. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015EMxQreQUZX5ZyybxAGh12	2026-09-13 17:43:13 +08:00