2 Commits

Include renames

Author	SHA1	Message	Date
Codeman maintainer	942bf37e48	fix(custom-model): unset injected env on clear, resume on restart, select the model for pi/omp/grok ... Custom Model Endpoint Profiles (#393) let a session point its CLI at a custom OpenAI-compatible endpoint by injecting env vars or a config file and restarting the CLI in place. Review of the apply path found four things, two of them destructive. This lands all four plus the smaller items from the same review. 1. Clearing a selection did not clear it. The injected vars reach the CLI via `tmux setenv`, which persists at the tmux-session level and is inherited by `respawn-pane` (measured: `setenv FOO bar` survived two successive `respawn-pane -k`), so deleting the keys from the session's envOverrides relaunched the CLI still pointed at the old endpoint, and for the configDir kinds at a HOME/CODEX_HOME/GROK_HOME that had just been deleted. `Session.setCustomModel()` now reports the removed keys, queues them (`_pendingEnvUnsets`), and `RespawnPaneOptions.unsetEnvKeys` carries them into `applyEnvOverrides()`, which `setenv -u`s them before re-applying the live overrides, on the same path that already unsets the legacy CLAUDE_CODE_EFFORT_LEVEL. Verified on a private tmux socket that `setenv -u HOME` hands the next respawn the global HOME back. 2. Applying a model to a local claude session killed the pane. The relaunch was `claude --session-id <id>` and Claude refuses an id that already has a transcript, and unlike the dead-pane respawn this one kills a working pane first. `restartCli()` now pins the live conversation id as the resume id for that respawn when the CLI's launch declares a `fallback` chain, which renders the same `--resume <id> || --session-id <id>` shape the docker and remote pane commands use. Gated on the registry shape, not the CLI id: an entry whose resume id is minted by the CLI itself never declares that chain. 3. pi, omp and grok wrote their config file and then launched without the `--model` that selects it, so the file was ignored. The registry entry now declares `customModelInjection.launchModel` (`custom/{modelId}` for pi and omp, grok's `[model.codeman-custom]` block name), the builder renders it, and `_withCustomModelLaunchModel()` applies it onto the respawn options through `legacyConfigField`, leaving the stored <Mode>Config untouched so a clear falls back to the user's own model. A model id the CLI's `model` token pattern cannot carry is refused with a 400 rather than silently dropped by the argv engine. 4. Remote (SSH) and Docker sessions reported `restarted: true` and changed nothing: their `restartCli()` reattaches the durable tmux rather than relaunching the agent, and the env lands on the local pane. Both are refused with a 400 until those paths are plumbed. Smaller items from the same review: - The selection survives a Codeman restart as the disk-only `__customModel` bookkeeping (endpoint, model, injected key NAMES, config dir, launch model; never the values, which carry the API key). Recovery re-derives the values from the endpoint store through the same apply path the route uses and keeps the bookkeeping even when the endpoint is gone, so a later clear still has keys to unset. - Discovery goes through `webviewFetch()`, so the RESOLVED address is judged by the same egress guard the web-tab proxy uses, and `baseUrl` reuses `webviewUrlSchema` (http(s) only, no embedded credentials, link-local and cloud-metadata addresses refused). undici's `fetch failed` wrapper is unwrapped so the user sees the ECONNREFUSED underneath. - `custom-model-hosts.json` is written 0600 via tmp+rename, the per-session config dir 0700/0600 (pi and omp embed the key literally), and that dir is removed with the session. - `PR.md` is gone from the repo root and the design doc moved to `docs/custom-model-endpoints-plan.md` with the LAN address and the personal name scrubbed; every reference follows. The guide's `authStyle` text matches the shipped schema (`bearer | api-key`, default `bearer`) and says that `customModelEndpointsEnabled` is read by nothing until the picker lands. - `config/tsconfig.scripts.json` typechecks `scripts/test-local-llm-harnesses.ts` (four real type errors fixed). It is not yet wired into `npm run typecheck` because that line differs on master; adding `&& tsc -p config/tsconfig.scripts.json` there is the one-line follow-up. Tests: `test/session-custom-model-restart.test.ts` drives a real Session and fails on the unfixed code for items 1 to 3; the route suite covers item 4 and the pattern refusal; `test/tmux-manager.test.ts` pins that the unsets run before the overrides and that a shell-metachar key never reaches tmux. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>	2026-09-14 23:46:28 +02:00
DevvynandClaude Sonnet 5	61779745aa	test(custom-model): make the harness smoke test dynamic, verify all 9 CLIs end-to-end ... Rewrites scripts/test-local-llm-harnesses.mjs -> .ts to read the live CLI registry (enabledClis()) and call the real production buildCustomModelInjection()/applyConfigDirInjection() instead of keeping a second hand-maintained copy of every CLI's env/config shape. A future registry change (new CLI, edited env var, fixed config template) is now picked up automatically with zero edits to this script; only the one-shot invocation flags (info the registry genuinely doesn't model) stay in a small hand-maintained ONE_SHOT table, and a registry CLI with no entry there reports UNKNOWN rather than being silently skipped. Extracted src/custom-model-injection-apply.ts (applyConfigDirInjection/ removeConfigDir) so the production route and this script share one implementation instead of two. Full end-to-end run against a real llama-swap server, inside a codeman/agent:llm-test Docker image with all 9 CLI binaries: - claude, opencode, pi, grok, omp: PASS, real "hello world" replies - codex: confirmed FAIL for a real protocol reason, not a bug — it only speaks the Responses API since Feb 2026, which llama.cpp/llama-swap don't implement - gemini: confirmed FAIL, unresolved after real investigation — an undocumented GATEWAY AuthType gemini-cli selects once GOOGLE_GEMINI_BASE_URL is set rejects every auth-key format/override tried - deepseek: reaches the server (env vars are read) but gets a consistent HTTP_404; root cause not identified, documented as best-effort/unknown - antigravity: SKIP, no known mechanism (unchanged) Two real bugs found and fixed along the way (grok, pi/omp registry entries in stock.ts): grok's original recipe (env vars) was flat-out wrong, not just unverified — the real mechanism is a config.toml [model.<name>] block redirected via GROK_HOME. pi/omp's PI_CONFIG_DIR does nothing for either (grepped pi's entire bundled source — the string appears nowhere); the real redirect is the child process's own HOME, and both need `models` as an array of {id} objects, not an object keyed by id (silently loaded zero models otherwise). deployment_plan.md, PR.md, docs/custom-model-endpoints.md, and CLAUDE.md updated with the final confidence table reflecting all of the above. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017HqNWfmtBU2KN29SvSVWB3	2026-09-13 17:42:35 +08:00