BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-10 09:19:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): #542 landing review follow-up

Browse Source 
The Run dropdown scroll browser test built WebServer on the fixed port 3290,
which the static port guard (test/test-ports-guard.test.ts, from #556) rejects
for any file outside its shrink-only legacy list, so the CI gate failed on the
landing branch. The test now binds an ephemeral port with new WebServer(0, ...)
and navigates to server.boundPort, and its header records the new convention.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Codeman maintainer
2026-10-09 06:12:18 +02:00
parent 432bd5fc0a
commit fe1acd625e
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/run-mode-menu-scroll.browser.test.ts
+3 -5
View File
@@ -8,21 +8,19 @@
* Browser-driven, so excluded from `npm run test:ci` (config/test-suites.ts). Run locally: * Browser-driven, so excluded from `npm run test:ci` (config/test-suites.ts). Run locally:
* npm run test:browser -- test/run-mode-menu-scroll.browser.test.ts * npm run test:browser -- test/run-mode-menu-scroll.browser.test.ts
* *
* Port: 3290 * Port: ephemeral (`new WebServer(0, …)`, read back through `boundPort`)
*/ */
import { afterAll, beforeAll, describe, expect, it } from 'vitest'; import { afterAll, beforeAll, describe, expect, it } from 'vitest';
import { chromium, type Browser, type Page } from 'playwright'; import { chromium, type Browser, type Page } from 'playwright';
import { WebServer } from '../src/web/server.js'; import { WebServer } from '../src/web/server.js';
const PORT = 3290;
describe('Run dropdown on a phone', () => { describe('Run dropdown on a phone', () => {
let server: WebServer; let server: WebServer;
let browser: Browser; let browser: Browser;
let page: Page; let page: Page;
beforeAll(async () => { beforeAll(async () => {
server = new WebServer(PORT, false, true); server = new WebServer(0, false, true);
await server.start(); await server.start();
browser = await chromium.launch({ headless: true }); browser = await chromium.launch({ headless: true });
const context = await browser.newContext({ const context = await browser.newContext({
@@ -32,7 +30,7 @@ describe('Run dropdown on a phone', () => {
deviceScaleFactor: 2, deviceScaleFactor: 2,
}); });
page = await context.newPage(); page = await context.newPage();
await page.goto(`http://localhost:${PORT}`, { waitUntil: 'domcontentloaded' }); await page.goto(`http://localhost:${server.boundPort}`, { waitUntil: 'domcontentloaded' });
await page.waitForFunction(() => (window as any).app?.terminal, null, { timeout: 30000 }); await page.waitForFunction(() => (window as any).app?.terminal, null, { timeout: 30000 });
}, 90000); }, 90000);