BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-07 07:59:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: high severity memory leaks and bugs

Browse Source 
- Add warningTimer to AgentContext and clean it up in cleanupAgent
- Clear all state in subagent-watcher stop() for clean restart
- Add cleanupStaleAgents() to remove completed agents older than 24h
- Delete pendingToolCalls entries after lookup to prevent memory leak
- Add FSWatcher error handlers to prevent unhandled exceptions
- Bump version to 0.1382

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
arkon
2026-01-26 12:50:39 +01:00
co-authored by Claude Opus 4.5
parent fe334c2ea6
commit e81dc4665a
5 changed files with 65 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/subagent-watcher.ts
+54 -2
View File
@@ -272,6 +272,39 @@ export class SubagentWatcher extends EventEmitter {
this.pendingToolCalls.clear();
}
/**
* Clean up stale completed agents to prevent unbounded memory growth
* Removes agents that have been completed for longer than STALE_AGENT_MAX_AGE_MS
*/
private cleanupStaleAgents(): void {
const now = Date.now();
const agentsToDelete: string[] = [];
for (const [agentId, info] of this.agentInfo) {
if (info.status === 'completed') {
const lastActivity = new Date(info.lastActivityAt).getTime();
if (now - lastActivity > STALE_AGENT_MAX_AGE_MS) {
agentsToDelete.push(agentId);
}
}
}
for (const agentId of agentsToDelete) {
const info = this.agentInfo.get(agentId);
if (info) {
// Clean up all associated resources
this.agentInfo.delete(agentId);
this.pendingToolCalls.delete(agentId);
this.filePositions.delete(info.filePath);
const watcher = this.fileWatchers.get(info.filePath);
if (watcher) {
watcher.close();
this.fileWatchers.delete(info.filePath);
}
}
}
}
/**
* Get all known subagents
*/
@@ -744,6 +777,13 @@ export class SubagentWatcher extends EventEmitter {
}
});
// Handle watcher errors to prevent unhandled exceptions
watcher.on('error', (error) => {
this.emit('subagent:error', error instanceof Error ? error : new Error(String(error)));
this.dirWatchers.delete(dir);
this.knownSubagentDirs.delete(dir);
});
this.dirWatchers.set(dir, watcher);
} catch {
// Watch failed
@@ -836,6 +876,12 @@ export class SubagentWatcher extends EventEmitter {
}
});
// Handle watcher errors to prevent unhandled exceptions
watcher.on('error', (error) => {
this.emit('subagent:error', error instanceof Error ? error : new Error(String(error)), agentId);
this.fileWatchers.delete(filePath);
});
this.fileWatchers.set(filePath, watcher);
this.resetIdleTimer(agentId);
} catch {
@@ -997,7 +1043,10 @@ export class SubagentWatcher extends EventEmitter {
} else if (content.type === 'tool_result' && content.tool_use_id) {
// Extract tool result
const resultContent = this.extractToolResultContent(content.content);
const toolName = this.pendingToolCalls.get(agentId)?.get(content.tool_use_id);
const agentPendingCalls = this.pendingToolCalls.get(agentId);
const toolName = agentPendingCalls?.get(content.tool_use_id);
// Delete after lookup to prevent memory leak
agentPendingCalls?.delete(content.tool_use_id);
const toolResult: SubagentToolResult = {
agentId,
@@ -1044,7 +1093,10 @@ export class SubagentWatcher extends EventEmitter {
for (const content of entry.message.content) {
if (content.type === 'tool_result' && content.tool_use_id) {
const resultContent = this.extractToolResultContent(content.content);
const toolName = this.pendingToolCalls.get(agentId)?.get(content.tool_use_id);
const agentPendingCalls = this.pendingToolCalls.get(agentId);
const toolName = agentPendingCalls?.get(content.tool_use_id);
// Delete after lookup to prevent memory leak
agentPendingCalls?.delete(content.tool_use_id);
const toolResult: SubagentToolResult = {
agentId,