fix(mobile): address review blockers on the touch-device change set
Review follow-ups on PR #111 (rebased onto master post-#112/#113): Resize arbitration redesigned (review blocker 2): the previous 'cols < _ptyCols' guard froze a mobile-only session's PTY at the spawn default — narrow phones rendered clipped and could never re-fit. The guard now uses connection-scoped desktop sizing claims instead: ws-routes registers a claim on a desktop-typed resize and releases it on socket close (or when the same connection later reports a small viewport), and Session.resize() ignores mobile/tablet resizes only while at least one desktop connection holds a claim. A phone alone fully controls its size (shrink, rows-only shrink, re-grow); a phone glancing at a desktop-driven session can no longer reflow it. mobile-handlers' keyboard open/close resize now declares its viewport type so it participates in arbitration. Tests rewritten to cover mobile-only shrink/rows-only/re-grow, claim/release lifecycle, multi- claim behavior, and untyped legacy resizes; ws-routes test covers the claim lifecycle over a real socket. Solo/detached header restored (review blocker 3): index.html had removed #soloSessionTitle and #soloRedockBtn, which _applySoloMode still references — every detached window hit a null deref. Both are back alongside the new mobile utility toggle. Desktop leak fixed (review should-fix): .mobile-header-utility-toggle had no rule outside the <=768px media queries, so the raw button rendered on desktop. styles.css now hides it by default; the mobile/ tablet queries re-enable it. Visual-regression baselines reverted to master (review should-fix): the 18 contributor-machine PNGs are environment-specific (8 of the behavioral tests already report environment-sensitive failures across machines); re-baseline deliberately on the canonical machine instead. The 24 behavioral keyboard/layout/tabs tests are kept as-is. AGENTS.md trimmed to a pointer at CLAUDE.md (review should-fix) to avoid drift between duplicated guidance. Also dropped a dead getAttachmentHistoryForPersist stub (codex-branch residue — no such method exists in src/). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arkon
|
Before Width: | Height: | Size: 197 KiB After Width: | Height: | Size: 125 KiB |
|
Before Width: | Height: | Size: 204 KiB After Width: | Height: | Size: 126 KiB |
|
Before Width: | Height: | Size: 390 KiB After Width: | Height: | Size: 173 KiB |
|
Before Width: | Height: | Size: 394 KiB After Width: | Height: | Size: 172 KiB |
|
Before Width: | Height: | Size: 184 KiB After Width: | Height: | Size: 91 KiB |
|
Before Width: | Height: | Size: 185 KiB After Width: | Height: | Size: 114 KiB |
|
Before Width: | Height: | Size: 176 KiB After Width: | Height: | Size: 90 KiB |
|
Before Width: | Height: | Size: 150 KiB After Width: | Height: | Size: 57 KiB |
|
Before Width: | Height: | Size: 153 KiB After Width: | Height: | Size: 53 KiB |
|
Before Width: | Height: | Size: 155 KiB After Width: | Height: | Size: 54 KiB |
|
Before Width: | Height: | Size: 154 KiB After Width: | Height: | Size: 56 KiB |
|
Before Width: | Height: | Size: 165 KiB After Width: | Height: | Size: 90 KiB |
|
Before Width: | Height: | Size: 204 KiB After Width: | Height: | Size: 116 KiB |
|
Before Width: | Height: | Size: 187 KiB After Width: | Height: | Size: 94 KiB |
|
Before Width: | Height: | Size: 197 KiB After Width: | Height: | Size: 99 KiB |
|
Before Width: | Height: | Size: 198 KiB After Width: | Height: | Size: 100 KiB |
|
Before Width: | Height: | Size: 197 KiB After Width: | Height: | Size: 103 KiB |
|
Before Width: | Height: | Size: 193 KiB After Width: | Height: | Size: 115 KiB |