BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-06 07:29:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: mobile keyboard layout — scroll-to-bottom on show, robust dismiss detection

Browse Source 
Three bugs fixed in KeyboardHandler:
1. onKeyboardShow() used sessionData.terminal (always undefined) instead of app.terminal
2. Keyboard dismiss threshold (50px) too tight for iOS address bar drift — widened to 100px
3. No terminal refit on keyboard hide — caused black gap below terminal

Also added: dynamic baseline update for initialViewportHeight, safety check in
updateLayoutForKeyboard() that forces dismiss when keyboardOffset <= 0.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
arkon
2026-02-16 12:10:44 +01:00
co-authored by Claude Opus 4.6
parent bd6d777294
commit da74ac248b
7 changed files with 1281 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/web/public/app.js
+32 -7
View File
@@ -250,12 +250,20 @@ const KeyboardHandler = {
this.onKeyboardShow();
}
// Keyboard hidden (viewport grew back close to initial)
else if (heightDiff < 50 && this.keyboardVisible) {
// Use 100px threshold (not 50) to handle iOS address bar drift,
// iOS 26's persistent 24px discrepancy, and Safari bottom bar changes
else if (heightDiff < 100 && this.keyboardVisible) {
this.keyboardVisible = false;
document.body.classList.remove('keyboard-visible');
this.onKeyboardHide();
}
// Update baseline when keyboard is not visible — adapts to address bar
// state changes, orientation changes, and other viewport shifts
if (!this.keyboardVisible) {
this.initialViewportHeight = currentHeight;
}
this.updateLayoutForKeyboard();
this.lastViewportHeight = currentHeight;
},
@@ -280,6 +288,16 @@ const KeyboardHandler = {
const visualBottom = window.visualViewport.offsetTop + window.visualViewport.height;
const keyboardOffset = layoutHeight - visualBottom;
// Safety: if keyboard is supposedly visible but offset is 0 or negative,
// the keyboard is actually gone — force dismiss. This catches cases where
// visualViewport.resize fires late or with intermediate values on iOS.
if (keyboardOffset <= 0) {
this.keyboardVisible = false;
document.body.classList.remove('keyboard-visible');
this.onKeyboardHide();
return;
}
// Move toolbar up above keyboard
if (toolbar) {
toolbar.style.transform = `translateY(${-keyboardOffset}px)`;
@@ -325,14 +343,14 @@ const KeyboardHandler = {
}
// Scroll active terminal to bottom so input line is visible
// Delay to let layout settle after keyboard resizes the viewport
setTimeout(() => {
if (typeof app !== 'undefined' && app.activeSessionId) {
const sessionData = app.sessions.get(app.activeSessionId);
if (sessionData?.terminal) {
sessionData.terminal.scrollToBottom();
}
if (typeof app !== 'undefined' && app.terminal) {
// Refit terminal to the now-smaller container, then scroll
if (app.fitAddon) try { app.fitAddon.fit(); } catch {}
app.terminal.scrollToBottom();
}
}, 100);
}, 150);
},
/** Called when keyboard hides */
@@ -343,6 +361,13 @@ const KeyboardHandler = {
}
this.resetLayout();
// Refit terminal to the restored (larger) container to prevent black gap
setTimeout(() => {
if (typeof app !== 'undefined' && app.fitAddon) {
try { app.fitAddon.fit(); } catch {}
}
}, 100);
},
/** Check if element is an input that triggers keyboard (excludes terminal) */