diff --git a/.changeset/f51b4ef6.md b/.changeset/f51b4ef6.md new file mode 100644 index 00000000..405bb7b1 --- /dev/null +++ b/.changeset/f51b4ef6.md @@ -0,0 +1,21 @@ +--- +'aicodeman': patch +--- + +Terminal copy: take the transcript gutter off the clipboard, using the width the CLI declares. + +Copying a paragraph out of a Claude Code pane put the pane's own two-column transcript gutter on the clipboard, so every pasted line arrived indented. #451 shipped the trailing half of the copy clean and deliberately left the leading half out, because deriving the width from the selection fires on 73% of ordinary indented text and cannot tell a margin from content. + +The width is now declared rather than derived. `capabilities.transcriptGutter` on the CLI registry is a bounded integer; claude and codex each declare 2, measured on live panes, and no other stock entry declares any, so a CLI whose transcript layout nobody has measured is never touched. The server publishes the map as `window.__codemanTranscriptGutter`, built by filtering `enabledClis()` on the capability rather than by listing ids, and the copy path looks the active session's mode up in it. It reads no terminal buffer at all. + +The declared width is a ceiling, not the answer: `clean()` strips the lesser of it and the run every selected line shares. A block can therefore only shift as a unit, the structure inside a selection survives by construction, and a selection reaching column 0 loses nothing. That is what keeps a `git log` body at its own four-space indent inside an agent's two-column gutter. + +Two derived versions were built and measured first, and both are worth recording because both looked correct. Painted trailing padding — a full-screen TUI writes real spaces across the unused part of a row, a shell leaves them never-written — has no false positives and never over-stripped, and is a function of pane WIDTH: that padding exists only while a rendered line stops short of the CLI's own layout width, and Claude's prose wraps to fill it. Dragging the same two prose rows of one live transcript at five window sizes, the share of padded rows ran 44%, 6%, 6%, 7% and 87% at 123, 160, 198, 235 and 298 columns, so the strip silently did nothing at every ordinary size. Taking the narrowest indent on the surrounding rows fires at every width and over-strips about 1%, because a file listing inside the transcript can be the narrowest thing on screen. + +Measured over 1,392,281 selections — every 1, 2, 3, 5, 10 and 20-row window of real Claude screens replayed from live PTY streams at 100, 120, 160, 198, 235 and 282 columns — the declared width over-strips none, breaks no relative indent and alters no text, and serves 100% of the selections whose own indent covers the gutter. Verified end to end in a browser with a real mouse drag and a real Ctrl+C at 123, 160, 198, 235 and 298 columns: a Claude pane pastes flush at every one, a shell pane is untouched at every one. + +Codex was measured the same way and gets the same two columns. It renders nothing like Claude — it draws boxes narrower than the pane and pushes its transcript into ordinary scrollback — so its layout was checked on its own live answer: the `•`/`›`/`⚠` markers sit in the gutter, prose continuations sit at 2, and a nested YAML block the model wrote rendered at 2/4/6/8 for its own 0/2/4/6. Replayed at 100, 120, 160, 198, 235 and 282 columns its indents were 0, 2, 4, 6 and 8 at every one and never 1. Copying that YAML out of a live Codex pane now yields 0/2/4/6: the gutter gone, the block's own nesting intact and paste-ready. + +The strip sits behind `copyStripMargin` in App Settings under Selection & clipboard, per-device and default ON. It is a display key, deliberately absent from the `.strict()` `SettingsUpdateSchema`, and read as `!== false` because the desktop branch of `getDefaultSettings()` returns `{}`. The toggle is checked before the map is consulted. + +The mid-row flag is back and governs one line rather than the whole block. It reads an ordered range, so neither end of a drag can move the result, and `range.start.x > 0` excludes only the first line — the one the mousedown genuinely cut the margin off. diff --git a/CLAUDE.md b/CLAUDE.md index 6dd34e47..2ffabbeb 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -322,7 +322,7 @@ Frontend JS modules have `@fileoverview` with `@dependency`/`@loadorder` tags. L **Welcome "Resume Conversation" list** (terminal-ui.js): `loadHistorySessions()` fetches once and caches the corpus on `_historyAll`/`_historyCases`; every subsequent view (filter box, sort select, expand, the periodic refresh in panels-ui.js) goes through `_renderHistoryList()`, so never append rows to `#historyList` directly or re-fetch to re-sort. ⚠️ The box height is **class-driven**: expanding the list without `.history-list.expanded` leaves the collapsed `max-height` in place and just deepens a scroll well, which is the bug #260 reported (35 sessions in a ~4-row box). ⚠️ The A–Z sort keys off `_historyRowLabel()`, the SAME string the row renders (`name || firstPrompt || path`), most rows are transcript-backed and have no session name, so sorting on `name` alone silently does nothing. ⚠️ A filter implies expansion, and `_renderSearch()` hides `#historyHeader` (title + controls) as one unit while a search is active. Tests: `test/history-list-controls.test.ts`. -**Command palette + shortcut registry**: `Ctrl/Cmd/Alt+K` opens the session palette; shortcuts live in a rebindable registry (`DEFAULT_SHORTCUTS`/`getShortcutRegistry()`/`matchesShortcutEvent()` in app.js, overrides in `settings.shortcutOverrides`). ⚠️ Palette-chord keys must ALSO be swallowed in `attachCustomKeyEventHandler` (terminal-ui.js) or xterm writes the control byte (0x0B) into the PTY. ⚠️ `saveAppSettings()` rebuilds settings from the DOM, so keys edited elsewhere (`shortcutOverrides`, `showTokenCount`, `showCost`) need explicit `_prev` carry-over. ⚠️ **Smart copy (`Ctrl+C`)** lives in that same handler: with a selection it copies, with none it must `return true` **without** `preventDefault()` or the interrupt is lost. `copyTerminalSelection` is deliberately absent from `SHORTCUT_ACTIONS` because the generic capture loop preventDefaults every match it dispatches. ⚠️ **The gate tests the CLEANED selection, not the raw one** (`CodemanCopySelection.clean` in constants.js, pure; `cleanedTerminalSelection()` reads the live terminal): xterm returns whole screen ROWS and trims only never-written cells, so the spaces a full-screen TUI paints across the rest of a row are content and reach the clipboard (138 of them per line, measured in a 282-column pane). The clean drops each line's TRAILING run and nothing else. ⚠️ **A shared LEADING indent is deliberately NOT stripped**, and that is a decision, not a gap: it was built, measured and dropped before #451 merged, because it fired on 73% of real non-TUI text (401,445 windows sampled) and no width threshold separates a TUI margin from content (a claude pane's own margins are 2 and 5 columns; the commonest non-TUI shared run is 4). Do not re-add it without reading the rule in architecture-invariants. ⚠️ Alt+drag COLUMN selections are returned untouched (`_activeSelectionMode === 3`), and the padding-only clear is FEEDBACK rather than interrupt protection, since a padding-only selection now cleans to `''` and falls through to the PTY on its own. → [architecture-invariants#command-palette-and-shortcut-registry](docs/architecture-invariants.md#command-palette-and-shortcut-registry) +**Command palette + shortcut registry**: `Ctrl/Cmd/Alt+K` opens the session palette; shortcuts live in a rebindable registry (`DEFAULT_SHORTCUTS`/`getShortcutRegistry()`/`matchesShortcutEvent()` in app.js, overrides in `settings.shortcutOverrides`). ⚠️ Palette-chord keys must ALSO be swallowed in `attachCustomKeyEventHandler` (terminal-ui.js) or xterm writes the control byte (0x0B) into the PTY. ⚠️ `saveAppSettings()` rebuilds settings from the DOM, so keys edited elsewhere (`shortcutOverrides`, `showTokenCount`, `showCost`) need explicit `_prev` carry-over. ⚠️ **Smart copy (`Ctrl+C`)** lives in that same handler: with a selection it copies, with none it must `return true` **without** `preventDefault()` or the interrupt is lost. `copyTerminalSelection` is deliberately absent from `SHORTCUT_ACTIONS` because the generic capture loop preventDefaults every match it dispatches. ⚠️ **The gate tests the CLEANED selection, not the raw one** (`CodemanCopySelection.clean` in constants.js, pure; `cleanedTerminalSelection()` reads the live terminal): xterm returns whole screen ROWS and trims only never-written cells, so the spaces a full-screen TUI paints across the rest of a row are content and reach the clipboard (138 of them per line, measured in a 282-column pane). The clean drops each line's TRAILING run and nothing else. ⚠️ **A LEADING margin is stripped only when the CLI DECLARES one** (`capabilities.transcriptGutter`, a bounded integer; claude and codex each declare 2, measured on live panes, and nothing else declares any). The server publishes the map as `window.__codemanTranscriptGutter` off the capability, never as an id list, and `_activeCliGutterColumns()` looks the session's mode up in it. ⚠️ **Deriving the width from the pane is what fails, and it failed twice.** The selection's own shared indent fired on 73% of ordinary indented text (401,445 windows), because a three-row window of nested YAML shares an indent for the same reason a margin does. Painted trailing padding — a TUI writes real spaces across the unused part of a row, a shell leaves them never-written — has no false positives but is a function of pane WIDTH, since that padding exists only while a rendered line stops short of the CLI's own layout width and Claude's prose wraps to fill it: measured on one live transcript the padded-row share ran 44%, 6%, 6%, 7% and 87% at 123, 160, 198, 235 and 298 columns, so the strip silently did nothing at every ordinary window size. Taking the narrowest indent on the surrounding rows fires at every width and over-strips ~1%, because a file listing inside the transcript can be the narrowest thing on screen. ⚠️ The declared width is a **CEILING**: `clean()` strips the lesser of it and the run every selected line shares, so a block only ever shifts as a unit and a selection reaching column 0 loses nothing. Over 1,392,281 selections across six pane widths of real Claude screens it over-strips none and leaves every relative indent intact. Behind the per-device `copyStripMargin` (default **ON**, in `displayKeys`, deliberately NOT in the `.strict()` `SettingsUpdateSchema`), read as `!== false` because the desktop branch of `getDefaultSettings()` returns `{}`. Nothing reads the terminal buffer on this path. ⚠️ Alt+drag COLUMN selections are returned untouched (`_activeSelectionMode === 3`), and the padding-only clear is FEEDBACK rather than interrupt protection, since a padding-only selection now cleans to `''` and falls through to the PTY on its own. → [architecture-invariants#command-palette-and-shortcut-registry](docs/architecture-invariants.md#command-palette-and-shortcut-registry) **Per-device vs synced settings**: the `displayKeys` set in settings-ui.js is a **client-side merge policy**, not a wire filter. A display key seeds from the server only when localStorage has no value for it, which is what prevents one device overwriting another; `showPlanUsageLimits` is additionally `delete`d from the incoming payload outright. Separately, `SettingsUpdateSchema` is `.strict()` and simply **does not declare** `skin`, `showFileViewerButton`, `showCronButton`, `webglRendererEnabled`, `localEchoEnabled`, `cjkInputEnabled`, or `extendedKeyboardBar`, so sending one of those is a validation error. The rest (`showResponseViewer`, `showPlanUsageLimits`, `language`, and most `show*` keys) ARE in the schema and do persist server-side; they are per-device by client policy only. ⚠️ Adding a new per-device setting means deciding **both** questions: membership in `displayKeys`, and presence in the schema. diff --git a/docs/architecture-invariants.md b/docs/architecture-invariants.md index b024875a..218a9909 100644 --- a/docs/architecture-invariants.md +++ b/docs/architecture-invariants.md @@ -308,11 +308,12 @@ Invariants: Copy goes through `_copyText()` (Clipboard API, then hidden-textarea + `execCommand`), not raw `navigator.clipboard`, because `install.sh`'s LAN option serves plain HTTP where `navigator.clipboard` is undefined; the fallback steals focus, so the terminal is refocused afterwards. Related: xterm registers its own `copy` listener on the terminal element gated on `hasSelection()`, which is why right-click → Copy has always worked. Selection itself is unavailable on touch devices by design (`user-select: none` on the terminal subtree), and in `shell`/`opencode`/`antigravity` tabs the TUI owns the mouse, so selecting there needs Shift+drag. Tests: `test/terminal-copy-selection.test.ts` (gate + wiring invariants), `test/terminal-copy-shortcut.test.ts` (browser, real key presses). -**The main terminal's four copy paths clean the selection first** (`CodemanCopySelection.clean` in constants.js, pure; `cleanedTerminalSelection()` in terminal-ui.js is the half that reads the live terminal). Those four are the `Ctrl+C` chord, right-click, the phone selection button and Auto Copy. ⚠️ Three routes still copy the RAW padded rows, all of them predating the clean: the browser's own Edit → Copy, which xterm's own `copy` listener on the terminal element serves with `selectionText` directly; a `copy-selection` shortcut the user disabled in App Settings, where nothing calls `preventDefault()` and that native listener runs; and the subagent/teammate windows, which build their own `Terminal` in panels-ui.js with no copy wiring at all. xterm hands back whole screen ROWS and its own trim drops only cells that were never written to, so the real spaces a full-screen TUI paints across the unused part of a row count as content and reach the clipboard. Measured against Claude Code in a 282-column pane, single lines arrived carrying 138 trailing spaces on top of the two-space transcript indent. The clean drops each line's trailing run. Three rules keep it honest: +**The main terminal's four copy paths clean the selection first** (`CodemanCopySelection.clean` in constants.js, pure; `cleanedTerminalSelection()` in terminal-ui.js is the half that reads the live terminal). Those four are the `Ctrl+C` chord, right-click, the phone selection button and Auto Copy. ⚠️ Three routes still copy the RAW padded rows, all of them predating the clean: the browser's own Edit → Copy, which xterm's own `copy` listener on the terminal element serves with `selectionText` directly; a `copy-selection` shortcut the user disabled in App Settings, where nothing calls `preventDefault()` and that native listener runs; and the subagent/teammate windows, which build their own `Terminal` in panels-ui.js with no copy wiring at all. xterm hands back whole screen ROWS and its own trim drops only cells that were never written to, so the real spaces a full-screen TUI paints across the unused part of a row count as content and reach the clipboard. Measured against Claude Code in a 282-column pane, single lines arrived carrying 138 trailing spaces on top of the two-space transcript indent. The clean drops each line's trailing run, and strips a LEADING margin when the pane behind the selection turns out to have one. Four rules keep it honest: -1. **Trailing padding only. A shared LEADING indent is deliberately NOT stripped**, and that is a decision rather than an omission: it was built, measured and dropped before #451 merged. It looks like the mirror image of the trailing trim and is not, because no native terminal does it and the transform cannot tell a TUI's margin from content that is genuinely indented. Measured over 401,445 three-row windows across 1,010 tracked files in this repo it fired on **73%** of them (92% inside a YAML workflow, 76% over `git log` output, 48% in a TypeScript source), and no width threshold separates the two because they are the same widths: a live Claude Code pane's own margins measure 2 and 5 columns while the most common non-TUI shared run is 4, sitting between them. The failure modes are what settle it. A wrong trailing trim costs nothing; a wrong dedent silently deletes information that was on screen, with no signal and nothing in the clipboard to hint at it, and it is wrong on `git log` bodies, on indented code read out of `cat` (semantic in Python), on `git diff` context rows where the leading space is the marker, and on stack traces. ⚠️ It also could not be made self-consistent cheaply: whether the first row joined the measurement depended on the mousedown COLUMN, which the user never sees, so one block of three rows produced three different clipboard results, and the flag read `getSelectionPosition().start`, which is the mousedown anchor xterm never normalises, so dragging UP through a block read it off the bottom row (the PR's test stub hardcoded a downward drag, so its suite could not express the case). If it is ever revisited, the one qualification that measured clean is **painted trailing padding** (a full-screen TUI writes real spaces across every row, while a shell pane leaves those cells never-written for xterm to trim): zero false positives over all 401,445 windows, no new plumbing. It still mangles a `git log` body sitting inside an agent's own gutter, which is why it was not taken. +1. **A leading strip uses the width the CLI DECLARES, never one derived from the pane.** `capabilities.transcriptGutter` (CLI registry, a bounded integer) is the whole source: claude and codex each declare 2, no other stock entry declares any, and an entry that declares nothing never has a margin taken off a copy. The server publishes the map as `window.__codemanTranscriptGutter`, built by filtering `enabledClis()` on that capability rather than by listing ids, and `_activeCliGutterColumns()` (terminal-ui.js) looks the active session's mode up in it. ⚠️ **Three ways of deriving the width from the text were built and measured, and two of them shipped looking correct.** The selection's own shared indent fired on **73%** of 401,445 three-row windows across 1,010 tracked files, because a three-row window of nested YAML shares an indent for the same reason a margin does. **Painted trailing padding** — a full-screen TUI writes real spaces across the part of a row it is not using, while a shell leaves those cells never-written for xterm to trim — has no false positives and never over-stripped, and is nonetheless a function of pane WIDTH: the padding exists only while a rendered line stops short of the CLI's own layout width, and Claude Code's prose wraps to fill it. Dragging the same two prose rows of one live transcript at five window sizes, the share of rows carrying padding measured 44%, 6%, 6%, 7% and 87% at 123, 160, 198, 235 and 298 columns, so at every ordinary size the strip did nothing at all while every test and every 282-column measurement said it worked. The **narrowest indent on the surrounding rows** fires at every width and over-strips about 1% of selections, because a file listing inside the transcript can be the narrowest thing on screen. ⚠️ The declared width is a **CEILING, not the answer**: `clean()` strips the lesser of it and the run every selected line shares, so a block can only ever shift as a unit, the relative structure inside a selection survives by construction, and a selection reaching column 0 loses nothing. That is what keeps a `git log` body at its own four spaces inside an agent's two-column gutter. Measured over 1,392,281 selections — every 1, 2, 3, 5, 10 and 20-row window of real Claude screens replayed from live PTY streams at 100, 120, 160, 198, 235 and 282 columns — it over-strips none, breaks no relative indent and alters no text, at 100% of the selections whose own indent covers the gutter. ⚠️ Nothing reads the terminal buffer on this path; the old version scanned up to ~240 rows per `Ctrl+C` to measure a width the CLI can simply state. 2. **A COLUMN selection is returned untouched.** Alt+drag makes one (xterm's `shouldColumnSelect` keys on `altKey` alone, and neither `Terminal` Codeman builds passes the one option, `macOptionClickForcesSelection`, that would disable it), and a rectangle's rows lining up is the whole point of the gesture. xterm exposes the mode nowhere public, so the check reads `terminal._core._selectionService._activeSelectionMode` (`SelectionMode.COLUMN` is 3) and cleans normally if a future xterm renames it. -3. **The emptiness gate is `trim()`, not truthiness, and it still clears the selection.** A multi-row drag across padding cleans to line breaks alone, which are truthy, and a bare newline pasted into a chat composer submits it. ⚠️ The clear is FEEDBACK, not protection for the interrupt, and the comments that said otherwise were describing the pre-clean code: the `Ctrl+C` gate above now tests the CLEANED selection, so a padding-only selection left set cleans to `''` on every later press and falls through to the PTY as `0x03` anyway. What the clear buys is that a highlight which copied nothing does not linger unexplained, which is also what the toast is for. +3. **The mid-row flag reads an ORDERED range, and it governs one line.** ⚠️ `getSelectionPosition()` is reversal-aware on the pinned xterm and the review note that called it the raw mousedown anchor is out of date: `CoreBrowserTerminal.ts` reads `_selectionService.selectionStart`, whose getter returns `SelectionModel.finalSelectionStart`, and that swaps the pair when `areSelectionValuesReversed()` says so. Driving a real upward mouse drag through chromium against xterm 6.0 reports the same range as the downward drag of the same rows. `_normalisedSelectionRange()` orders the pair anyway, because the private model one layer down exposes unnormalised fields under the same two names, and a reversed pair would put the mid-row flag on the wrong end of the drag. `range.start.x > 0` then means the first selected line began mid-row and never carried the margin, so that line alone is left out of both the shared-indent ceiling and the strip. ⚠️ This is the ONE thing the mousedown column still decides and it decides it for that line only. In the dropped version it decided whether the first row joined the measurement, which changed what **every** row lost, so the same three rows produced three different clipboard results depending on where the click landed. +4. **The emptiness gate is `trim()`, not truthiness, and it still clears the selection.** A multi-row drag across padding cleans to line breaks alone, which are truthy, and a bare newline pasted into a chat composer submits it. ⚠️ The clear is FEEDBACK, not protection for the interrupt, and the comments that said otherwise were describing the pre-clean code: the `Ctrl+C` gate above now tests the CLEANED selection, so a padding-only selection left set cleans to `''` on every later press and falls through to the PTY as `0x03` anyway. What the clear buys is that a highlight which copied nothing does not linger unexplained, which is also what the toast is for. Tests: `test/terminal-copy-clean.test.ts`. diff --git a/src/config/cli-registry/schema.ts b/src/config/cli-registry/schema.ts index d1249384..68dee0d8 100644 --- a/src/config/cli-registry/schema.ts +++ b/src/config/cli-registry/schema.ts @@ -294,6 +294,23 @@ const capabilitiesSchema = z effort: z.boolean(), agentSkillInjection: z.boolean(), statusLineTelemetry: z.boolean(), + // How many columns this CLI indents its transcript body by, so a copy can take + // that much off the clipboard. Bounded, because it is the whole strip: a copy + // never removes more than this, nor more than every selected line shares. + // + // ⚠ DECLARED, not measured off the pane, and two measured attempts are why. + // Asking whether the pane painted spaces across the unused part of each row + // separates a TUI from a shell perfectly where it fires and never + // over-stripped, but it is a function of pane WIDTH: that padding exists + // only while a rendered line stops short of the CLI's own layout width, and + // Claude Code's prose wraps to fill it — the share of padded rows on one + // live transcript ran 44%, 6%, 6%, 7% and 87% at 123, 160, 198, 235 and 298 + // columns, so the strip did nothing at any ordinary size. Taking the + // narrowest indent on screen instead fires everywhere and over-strips, since + // a file listing inside the transcript can be the narrowest thing on it. + // A declared width cannot do either. Absent means no strip, so a CLI whose + // transcript layout nobody has measured is never touched. + transcriptGutter: z.number().int().min(1).max(8).optional(), workDetect: z .object({ promptGlyph: z.string().min(1).max(8), diff --git a/src/config/cli-registry/stock.ts b/src/config/cli-registry/stock.ts index 1e455192..32826837 100644 --- a/src/config/cli-registry/stock.ts +++ b/src/config/cli-registry/stock.ts @@ -200,6 +200,10 @@ const CLAUDE: CliEntry = { }, capabilities: { external: false, + // Claude indents its transcript body two columns and puts its own ●/✻/❯ markers + // in them, so a copy can drop two and paste flush. The only entry that declares + // this, because it is the only one whose gutter has been measured. + transcriptGutter: 2, // The historical hard-coded pair, now stated as data. `workingLine` matches both the // `✻ Actualizing… (39s · ↓ 2.0k tokens)` status line and the bare `esc to interrupt` // footer, because tmux repaints partially and only one of the two may land in a chunk. @@ -519,6 +523,12 @@ const CODEX: CliEntry = { // braille spinner, and it never prints `esc to interrupt` at rest, so that phrase // alone separates a running turn from an idle one. workDetect: { promptGlyph: '›', workingLine: '[Ee]sc to interrupt' }, + // Two columns, like claude's, measured on a live 0.154.0 answer: the `•`/`›`/`⚠` + // markers sit in the gutter, prose continuations sit at 2, and a nested YAML block + // the model wrote rendered at 2/4/6/8 for its own 0/2/4/6. Replayed at 100, 120, + // 160, 198, 235 and 282 columns the indents were 0, 2, 4, 6 and 8 at every one, + // never 1, so the width is not a function of the pane. + transcriptGutter: 2, transcript: 'codex-rollout', altScreen: 'strip-full', echo: { policy: 'predict', anchor: { kind: 'cursor' }, predictProfile: 'codex' }, diff --git a/src/config/cli-registry/types.ts b/src/config/cli-registry/types.ts index 871a3762..70462c2b 100644 --- a/src/config/cli-registry/types.ts +++ b/src/config/cli-registry/types.ts @@ -345,6 +345,29 @@ export interface CliCapabilities { /** Source of a regex matching the status line this CLI draws while a turn runs. */ workingLine: string; }; + /** + * How many columns this CLI indents its transcript body by, so a copy taken from its + * pane can drop that much and paste flush. Claude Code indents two and puts its own + * markers in those columns. + * + * ⚠ DECLARED rather than measured off the pane, and two measured attempts are why. + * Asking whether the pane painted real spaces across the unused part of each row + * separates a TUI from a shell perfectly where it fires and never over-stripped; it + * is also a function of pane WIDTH, because that padding exists only while a + * rendered line stops short of the CLI's own layout width and Claude Code's prose + * wraps to fill it. On one live transcript the share of padded rows ran 44%, 6%, 6%, + * 7% and 87% at 123, 160, 198, 235 and 298 columns, so at any ordinary window size + * the strip silently did nothing. Taking the narrowest indent on the surrounding + * rows instead fires at every width and over-strips on roughly 1% of selections, + * because a file listing inside the transcript can be the narrowest thing on screen. + * + * A declared width can do neither. The strip is the lesser of this and what every + * selected line shares, so a block can only ever shift as a unit, and it can never + * shift further than the CLI itself says its gutter is. + * + * Absent means no strip at all, the same fail-safe direction `workDetect` takes. + */ + transcriptGutter?: number; /** No direct-PTY fallback: the CLI must run inside tmux (secrets ride tmux setenv). */ requiresMux: boolean; /** diff --git a/src/web/public/constants.js b/src/web/public/constants.js index 17b4b6a7..218d08f6 100644 --- a/src/web/public/constants.js +++ b/src/web/public/constants.js @@ -774,6 +774,8 @@ function resolveTerminalFontWeights(settings) { */ const AUTO_COPY_MAX_CHARS = 1_000_000; + + /** * What an auto-copy attempt should do at the end of a selection gesture. * @@ -819,36 +821,32 @@ function decideAutoCopy({ enabled, text, lastCopied, pending } = {}) { // _selectTouchSelectionLine already treats those cells as padding. This is that // same rule for the mouse and keyboard paths, which never had it. // -// ⚠ Trailing padding ONLY. A shared LEADING indent is deliberately left alone, -// and this note is here so the idea is not re-derived: it was built, measured -// and dropped before merge. Removing the longest leading run every selected row -// shares looks like the mirror image of the trailing trim and is not, because -// no native terminal does it and the transform cannot tell a TUI's margin from -// content that is genuinely indented. Measured over 401 445 three-row windows -// across 1 010 tracked files in this repo, it fired on 73% of them: 92% inside -// a YAML workflow, 76% over `git log` output, 48% in a TypeScript source file. -// No width threshold separates the two, because they are the same widths: a -// live Claude Code pane's own margins measure 2 and 5 columns while the most -// common non-TUI shared run is 4, sitting between them. +// A LEADING margin is stripped too, but only the one the CLI in the pane +// DECLARES as its transcript gutter, passed in as `options.margin`. Called with +// no options this trims trailing padding and nothing else, which is what keeps +// every caller that has no declared gutter on the old behaviour. // -// The asymmetry that settles it is in the failure modes. A wrong trailing trim +// ⚠ The failure modes are not symmetrical, and that asymmetry sets how much +// evidence a leading strip has to show before it fires. A wrong trailing trim // costs nothing. A wrong dedent silently deletes information that was on the // screen, with no signal to the user and nothing in the clipboard to hint at // it, and it is wrong on `git log` bodies, on indented code read out of `cat` // (semantic in Python), on `git diff` context rows where the leading space is // the marker, and on stack traces. // -// ⚠ It also cannot be made consistent cheaply. Whether the first row joins the -// measurement depended on the mousedown COLUMN, which the user never sees, so -// one block of three rows produced three different clipboard results; and the -// flag read `getSelectionPosition().start`, which is the mousedown anchor that -// xterm never normalises, so dragging UP through a block read it off the bottom -// row. If it is ever revisited, the one qualification that measured clean is -// painted trailing padding (a full-screen TUI writes real spaces across every -// row; a shell pane leaves those cells never-written, so xterm trims them): -// zero false positives over all 401 445 windows. It still mangles a `git log` -// body sitting inside an agent's own gutter, which is why it was not taken now. -function cleanCopiedSelection(text) { +// ⚠ The declared gutter is a CEILING, not the answer. The strip is the lesser +// of it and the run every selected line shares, so a block can only ever shift +// as a unit: the relative structure inside a selection survives by +// construction, and a selection reaching column 0 loses nothing at all. +// +// ⚠ Deriving the width from the text instead is what fails, twice over. The +// selection's own shared indent cannot tell a margin from content, because a +// three-row window of nested YAML shares an indent for the same reason a margin +// does — it fired on 73% of ordinary indented text. Taking the narrowest indent +// on the surrounding rows fails more quietly: a file listing inside the +// transcript can be the narrowest thing on screen, which over-stripped about 1% +// of selections across six pane widths. +function cleanCopiedSelection(text, options) { if (typeof text !== 'string' || !text) return ''; // Split on \n and leave any \r in place: xterm joins rows with \r\n on // Windows, and the clipboard should keep the endings xterm chose. @@ -868,7 +866,36 @@ function cleanCopiedSelection(text) { while (cut > 0 && (line[cut - 1] === ' ' || line[cut - 1] === '\t')) cut--; return cut === end ? line : line.slice(0, cut) + line.slice(end); }; - return text.split('\n').map(trimEnd).join('\n'); + const lines = text.split('\n'); + for (let i = 0; i < lines.length; i++) lines[i] = trimEnd(lines[i]); + + const margin = Math.max(0, Math.trunc(Number(options?.margin) || 0)); + if (!margin) return lines.join('\n'); + + // The first line of a selection that began mid-row carries no margin — the + // mousedown cut it off — so it neither votes on the shared indent nor gets + // stripped. This is the ONE thing the mousedown column still decides, and it + // decides it for that line alone. Whether the rest of the block is dedented + // no longer depends on where the click landed, which is what made the same + // three rows produce three different clipboard results before. + const from = options?.firstLinePartial === true ? 1 : 0; + + // The pane's margin is a ceiling, not the answer. Strip the narrower of it + // and what every selected line shares, so the block shifts as a unit and no + // line can lose indentation another line keeps. + let shared = margin; + for (let i = from; i < lines.length && shared > 0; i++) { + const line = lines[i]; + if (!line || line === '\r') continue; // a padding-only row, already trimmed away + let run = 0; + while (run < line.length && line[run] === ' ') run++; + if (run < shared) shared = run; + } + if (!shared) return lines.join('\n'); + for (let i = from; i < lines.length; i++) { + if (lines[i] && lines[i] !== '\r') lines[i] = lines[i].slice(shared); + } + return lines.join('\n'); } if (typeof window !== 'undefined') { diff --git a/src/web/public/index.html b/src/web/public/index.html index dd972edc..b602051c 100644 --- a/src/web/public/index.html +++ b/src/web/public/index.html @@ -1791,6 +1791,13 @@ +