BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-09 08:59:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(tiles): no + in the tile header (owner decision 9)

Browse Source 
Owner: "remove the + button from these views". The tile header is now
● name ... ⋯ ⤢ ×. Gone with it, because nothing else used them: the +
menu (openTileAddMenu, closeTileAddMenu and their hooks in closeTileGrid
and the global Escape handler), its "New session in this case" entry and
runInCaseForTiles, the .tile-add-empty rules, the four i18n entries only
the menu showed, and buildTilePickerSessions' exclude argument (only the
menu passed it).

Every other way of adding tiles stays and needed nothing from the menu:
the Tiles button and its right-click picker, Ctrl/Cmd+click on a tab,
dragging a tab onto a tile or an empty slot, "Open group as tiles", and
Run joining the open grid (_joinTileGridFromRun). The picker list, the
cap helper _tileGridLimit and the user-text skip on names are shared and
kept.

Tests: the + menu cases (picker, cap, auto-join, the zh-CN harvest) are
removed; tile-grid-chrome pins the header as exactly ⋯ ⤢ × with no add
menu or runInCaseForTiles left on the app.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Codeman maintainer
2026-10-07 02:48:40 +02:00
parent 5da25f782b
commit caf5248e22
10 changed files with 37 additions and 262 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/web/public/tile-grid.js
+2 -114
View File
@@ -296,7 +296,6 @@ Object.assign(CodemanApp.prototype, {
this._updateConnectionIndicator?.();
this._updateSplitButtonForTiles();
this._updateTileGridButtonState();
this.closeTileAddMenu();
// The tabs drop their .in-tiles marker.
this.renderSessionTabs?.();
if (reselect) this._selectAfterTileGrid(focusedId);
@@ -495,108 +494,6 @@ Object.assign(CodemanApp.prototype, {
picker.menu.remove();
},
/**
* A tile's +: the open sessions not yet tiled, in tab order; picking one
* adds it to the grid and focuses it (a human selection). Disabled once the
* grid holds what the window can fit.
*/
openTileAddMenu(event, fromSessionId = null) {
event?.preventDefault?.();
event?.stopPropagation?.();
const grid = this._tileGrid;
if (!grid?.open) return;
const trigger = event?.currentTarget || null;
if (this._tileAddMenu && this._tileAddMenu.trigger === trigger) {
this.closeTileAddMenu();
return;
}
this.closeTileAddMenu();
const T = window.CodemanTileGrid;
const limit = this._tileGridLimit();
const full = grid.ids.length >= limit.capacity;
const candidates = T.buildTilePickerSessions(this.sessions, this.sessionOrder, this.detachedSessions, grid.tiles);
const menu = document.createElement('div');
menu.className = 'tab-rail-action-menu tile-add-menu';
menu.setAttribute('role', 'menu');
menu.setAttribute('aria-label', 'Add a session to the grid');
if (candidates.length === 0) {
const empty = document.createElement('div');
empty.className = 'tile-add-empty';
empty.textContent = 'Every open session is already tiled';
menu.appendChild(empty);
}
for (const c of candidates) {
const item = document.createElement('button');
item.type = 'button';
item.setAttribute('role', 'menuitem');
// Only the name is user text: skipping the whole button would keep its
// title (why it is disabled) out of the translator too.
const name = document.createElement('span');
name.setAttribute('data-i18n-skip', '');
name.textContent = c.label;
item.appendChild(name);
item.disabled = full;
if (full) item.title = limit.full;
item.addEventListener('click', () => {
this.closeTileAddMenu();
if (this.addTile(c.id)) this.selectSession(c.id);
});
menu.appendChild(item);
}
// A new session in the case this tile's session belongs to: the normal Run
// for that case, which then joins the grid like any Run from this tab.
const fromSession = fromSessionId ? this.sessions.get(fromSessionId) : null;
const theCase = fromSession ? this._mobileOverviewCaseFor?.(fromSession.workingDir, this.cases || []) : null;
const create = document.createElement('button');
create.type = 'button';
create.className = 'tile-add-new';
create.setAttribute('role', 'menuitem');
create.textContent = 'New session in this case';
create.disabled = full || !theCase;
if (!theCase) create.title = 'This session is not in a case';
else if (full) create.title = limit.full;
create.addEventListener('click', () => {
this.closeTileAddMenu();
if (theCase) void this.runInCaseForTiles(theCase.name);
});
menu.appendChild(create);
document.body.appendChild(menu);
if (trigger?.getBoundingClientRect) {
const rect = trigger.getBoundingClientRect();
menu.style.position = 'fixed';
menu.style.top = `${rect.bottom + 4}px`;
menu.style.right = `${Math.max(8, window.innerWidth - rect.right)}px`;
}
const onOutside = (e) => {
if (menu.contains?.(e.target) || (trigger && trigger.contains?.(e.target))) return;
this.closeTileAddMenu();
};
const onKey = (e) => {
if (e.key === 'Escape') this.closeTileAddMenu();
};
this._tileAddMenu = { menu, trigger, onOutside, onKey };
document.addEventListener('pointerdown', onOutside, true);
document.addEventListener('keydown', onKey);
menu.querySelector?.('button:not([disabled])')?.focus?.();
},
/**
* Runs the normal Run (current run mode) in `caseName`, then puts the
* toolbar's case back as it was. The session it creates joins the grid
* through _joinTileGridFromRun.
*/
async runInCaseForTiles(caseName) {
const select = document.getElementById('quickStartCase');
const previous = select?.value;
const swap = !!select && !!caseName && previous !== caseName;
if (swap) this.selectQuickStartCase?.(caseName, { save: false });
try {
await this.run?.();
} finally {
if (swap && previous) this.selectQuickStartCase?.(previous, { save: false });
}
},
/**
* A session THIS tab's Run just created (session-ui.js
* _ensureCreatedSessionVisible, reached only from the Run paths): with the
@@ -620,16 +517,6 @@ Object.assign(CodemanApp.prototype, {
return this.addTile(sessionId);
},
/** Idempotent, like closeTilePicker. */
closeTileAddMenu() {
const m = this._tileAddMenu;
if (!m) return;
this._tileAddMenu = null;
document.removeEventListener('pointerdown', m.onOutside, true);
document.removeEventListener('keydown', m.onKey);
m.menu.remove();
},
// The Split button cannot act while the grid is open (openSplitPicker and
// openSplitPane refuse), so it says so: aria-disabled plus a title, the same
// refusal the split already gives for web tabs and the welcome screen.
@@ -1207,7 +1094,8 @@ Object.assign(CodemanApp.prototype, {
actions.append(
button('tile-menu', 'Session actions', '\u22EF', (e) => this.openTabRailActionMenu?.(e, sessionId)),
zoomBtn,
button('tile-add', 'Add a session to the grid', '+', (e) => this.openTileAddMenu(e, sessionId)),
// (No + here, owner decision 9: tiles are added from the Tiles button's
// picker, Ctrl/Cmd+click, a dragged tab, a tab group or Run.)
// Removes the tile ONLY: the session keeps running. Killing it stays
// behind the menu's Close session and its confirm.
button('tile-remove', 'Remove tile (the session keeps running)', '\u00D7', () =>