BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-11 09:49:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(settings): Apply cannot keep a later Save open, refreshes only after a saved PUT (review)

Browse Source 
- Split the one-shot keep-open intent from the in-flight guard and consume it before the
  first await, so a Save clicked while an Apply is in flight closes the modal.
- Refresh the dependent groups only when the settings PUT returned ok (_apiPut answers null
  or a non-ok response instead of throwing), and also when only the webhook save failed.
- Find the 'Apply or Save' hint by a data marker, not its English text; add zh-CN strings
  for the new toast and title.
- Tests run the real saveAppSettings() (Apply then Save mid-flight, a failed PUT, a webhook-only
  failure, a plain Save).
- Narrow the changeset and JSDoc to MCP sync and CLI management; touch the tray comment, the
  architecture note and the wiki.
This commit is contained in:
Devvyn
2026-10-09 19:46:09 +08:00
parent 9c63c41283
commit c75d62ce04
7 changed files with 157 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/settings-apply-button.md
+1 -1
View File
@@ -2,4 +2,4 @@
'aicodeman': minor
---
Settings has an Apply button next to Save. It saves the same way but keeps Settings open and refreshes the groups that depend on a saved value, so switching on MCP server sync (or custom model endpoints, or CLI management) brings up its controls straight away instead of needing a close-and-reopen. The MCP sync hint now says to Apply or Save first.
Settings has an Apply button next to Save. It saves the same way but keeps Settings open, so switching on MCP server sync makes its Preview and Sync usable straight away, and CLI management's add, enable and disable work without a close-and-reopen. The MCP sync hint now says to Apply or Save first.