BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-10 01:09:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(codex): limit launch defaults to local sessions

Browse Source
This commit is contained in:
shenlvkang-collab
2026-10-07 17:48:46 +08:00
parent fc6e911888
commit c30128d3f0
6 changed files with 74 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/routes/session-routes-codex-defaults.test.ts
+60 -1
View File
@@ -1,5 +1,5 @@
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import { mkdir, writeFile } from 'node:fs/promises';
import { mkdir, writeFile, rm } from 'node:fs/promises';
import { dirname, join } from 'node:path';
import { homedir } from 'node:os';
import { createRouteTestHarness, type RouteTestHarness } from './_route-test-utils.js';
@@ -10,6 +10,7 @@ import { resolveCodexLaunchDefaults } from '../../src/web/codex-launch-defaults.
import { buildCodexCommand } from '../../src/tmux-manager.js';
import { Session } from '../../src/session.js';
import { safeRmHomeTree } from '../mocks/index.js';
import { getDataDir } from '../../src/config/instance.js';
vi.mock('../../src/utils/cli-launcher.js', async (importOriginal) => {
const actual = await importOriginal<typeof import('../../src/utils/cli-launcher.js')>();
@@ -21,6 +22,9 @@ describe('Codex launch defaults', () => {
const workingDir = join(homedir(), 'codex-default-test');
beforeEach(async () => {
for (const name of ['docker-hosts.json', 'docker-cases.json', 'remote-hosts.json', 'remote-cases.json']) {
await rm(join(getDataDir(), name), { force: true });
}
await mkdir(workingDir, { recursive: true });
await mkdir(dirname(SETTINGS_PATH), { recursive: true });
await writeFile(SETTINGS_PATH, JSON.stringify({ codexModel: 'gpt-6.1', codexReasoningEffort: 'high' }));
@@ -42,6 +46,7 @@ describe('Codex launch defaults', () => {
: { caseName: 'codex-default-test', mode: 'codex', ...overrides };
const res = await harness.app.inject({ method: 'POST', url, payload });
expect(res.statusCode).toBe(200);
expect(res.json().success, res.body).not.toBe(false);
const session = [...harness.ctx.sessions.values()].at(-1) as Session | undefined;
expect(session).toBeDefined();
return session!.codexConfig;
@@ -79,6 +84,60 @@ describe('Codex launch defaults', () => {
expect(await resolveCodexLaunchDefaults(config, true)).toBe(config);
});
it('does not record unused defaults for a Docker quick-start', async () => {
await writeFile(
join(getDataDir(), 'docker-hosts.json'),
JSON.stringify([{ id: 'docker1', label: 'Docker', image: 'codeman/agent:base' }])
);
await writeFile(
join(getDataDir(), 'docker-cases.json'),
JSON.stringify([
{
name: 'codex-default-test',
type: 'docker',
hostId: 'docker1',
hostWorkspacePath: workingDir,
container: 'codeman-default-test',
},
])
);
expect(await createdConfig('/api/quick-start')).toBeUndefined();
const session = [...harness.ctx.sessions.values()].at(-1) as Session;
expect(session.docker?.containerName).toBe('codeman-default-test');
expect(session.toState().model).toBeUndefined();
});
it('does not record unused defaults for a remote attach', async () => {
await writeFile(
join(getDataDir(), 'remote-hosts.json'),
JSON.stringify([{ id: 'remote1', label: 'Remote', host: '10.0.0.5', username: 'dev' }])
);
expect(
await createdConfig('/api/sessions', {
workingDir: undefined,
attachRemoteSession: { hostId: 'remote1', remoteSessionName: 'codeman-existing' },
})
).toBeUndefined();
const session = [...harness.ctx.sessions.values()].at(-1) as Session;
expect(session.toState().remote?.hostId).toBe('remote1');
expect(session.toState().model).toBeUndefined();
});
it('does not record unused defaults for a remote quick-start', async () => {
await writeFile(
join(getDataDir(), 'remote-hosts.json'),
JSON.stringify([{ id: 'remote1', label: 'Remote', host: '10.0.0.5', username: 'dev' }])
);
await writeFile(
join(getDataDir(), 'remote-cases.json'),
JSON.stringify([{ name: 'codex-default-test', type: 'remote', hostId: 'remote1', remotePath: '/home/dev/work' }])
);
expect(await createdConfig('/api/quick-start')).toBeUndefined();
const session = [...harness.ctx.sessions.values()].at(-1) as Session;
expect(session.toState().remote?.hostId).toBe('remote1');
expect(session.toState().model).toBeUndefined();
});
it('accepts, persists, clears and validates synced settings via HTTP', async () => {
const system = await createRouteTestHarness(registerSystemRoutes);
try {