mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-10-05 06:59:42 +02:00
fix(docker): pre-fill the copied case instead of blanking two fields
The previous version cleared the case name and the in-container directory on the
grounds that they must differ. That left a form with three fields mysteriously
filled and two empty, and turned the most common operation — changing
/srv/app/api to /srv/app/web — into retyping a long path.
Both are now pre-filled, with focus on the in-container directory and the caret
at the end, since the tail is what changes. What stops an unmodified submit is no
longer an empty field but a guard: the values applied are recorded, compared at
submit time, and if nothing changed the reason is stated next to the field and
focus moves to it, without sending a request that is certain to be refused.
The server refuses these anyway (a duplicate case name, a twin case on the same
container and directory) and its errors are clear; but making a round trip to be
told "you forgot to edit the field you are looking at" is worse than saying so on
the spot. The guard only applies when a source case was actually selected, so
filling the adopt form from scratch is unaffected.
⚠️ The status text is written into dockerLinkStatus. My first version referenced
an id that does not exist (dockerAdoptStatus), which made the explanation vanish
silently and left only a toast. The test now extracts that id from the code and
looks it up in index.html, pinning that it must really exist.
This commit is contained in:
@@ -55,8 +55,8 @@ describe('the picker only offers what the server would accept', () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe('applying a source fills what stays and clears what must differ', () => {
|
||||
const fn = ui.slice(ui.indexOf('applyDockerCloneSource()'), ui.indexOf('applyDockerCloneSource()') + 1400);
|
||||
describe('applying a source fills every field, including the two that must differ', () => {
|
||||
const fn = ui.slice(ui.indexOf('applyDockerCloneSource()'), ui.indexOf('dockerCloneGuard()'));
|
||||
|
||||
it('carries over container, host and workspace', () => {
|
||||
for (const id of ['dockerContainerName', 'dockerHostId', 'dockerWorkspacePath']) {
|
||||
@@ -64,15 +64,21 @@ describe('applying a source fills what stays and clears what must differ', () =>
|
||||
}
|
||||
});
|
||||
|
||||
it('clears the case name and the container workdir', () => {
|
||||
// Keeping either would pre-fill a value the server is certain to refuse —
|
||||
// the name as an existing case, the workdir as an exact twin.
|
||||
expect(fn).toContain("set('dockerCaseName', '')");
|
||||
expect(fn).toContain("set('dockerAdoptWorkdir', '')");
|
||||
it('PRE-FILLS the case name and container workdir rather than clearing them', () => {
|
||||
// Editing `/srv/app/api` into `/srv/app/web` beats retyping a long path, and a
|
||||
// form with three fields mysteriously filled and two blank reads as broken.
|
||||
// What stops an unchanged submit is the guard, not an empty field.
|
||||
expect(fn).toContain("set('dockerCaseName', option.value)");
|
||||
expect(fn).toContain("set('dockerAdoptWorkdir', option.dataset.workdir)");
|
||||
});
|
||||
|
||||
it('focuses the workdir, the field the user came here to change', () => {
|
||||
expect(fn).toMatch(/getElementById\('dockerAdoptWorkdir'\)\?\.focus\(\)/);
|
||||
it('remembers what it applied, so the guard can tell unchanged from similar', () => {
|
||||
expect(fn).toContain('select.dataset.appliedName = option.value');
|
||||
expect(fn).toContain('select.dataset.appliedWorkdir =');
|
||||
});
|
||||
|
||||
it('focuses the workdir with the caret at the END, where the edit happens', () => {
|
||||
expect(fn).toMatch(/setSelectionRange\(workdir\.value\.length, workdir\.value\.length\)/);
|
||||
});
|
||||
|
||||
it('does nothing for the blank "start from scratch" option', () => {
|
||||
@@ -80,6 +86,39 @@ describe('applying a source fills what stays and clears what must differ', () =>
|
||||
});
|
||||
});
|
||||
|
||||
describe('the guard refuses a duplicate that was never edited', () => {
|
||||
const fn = ui.slice(ui.indexOf('dockerCloneGuard()'), ui.indexOf('dockerCloneGuard()') + 1400);
|
||||
|
||||
it('flags an unchanged case name', () => {
|
||||
expect(fn).toMatch(/appliedName/);
|
||||
expect(fn).toContain('give this one a new name');
|
||||
});
|
||||
|
||||
it('flags an unchanged container workdir', () => {
|
||||
expect(fn).toMatch(/appliedWorkdir/);
|
||||
expect(fn).toContain('another directory');
|
||||
});
|
||||
|
||||
it('stays silent when no source was picked', () => {
|
||||
// Typing a fresh adoption by hand must not be second-guessed.
|
||||
expect(fn).toMatch(/if \(!select \|\| !select\.value\) return null;/);
|
||||
});
|
||||
|
||||
it('runs BEFORE the request, and focuses the offending field', () => {
|
||||
const submit = ui.slice(ui.indexOf('const cloneIssue'), ui.indexOf('const cloneIssue') + 500);
|
||||
expect(submit).toContain('cloneIssue.el.focus()');
|
||||
expect(submit).toContain('return;');
|
||||
});
|
||||
|
||||
it('reports into a status element that actually exists', () => {
|
||||
// A dead id would silently drop the explanation next to the field.
|
||||
const submit = ui.slice(ui.indexOf('const cloneIssue'), ui.indexOf('const cloneIssue') + 500);
|
||||
const id = /getElementById\('([^']+)'\)/.exec(submit)?.[1];
|
||||
expect(id).toBeTruthy();
|
||||
expect(html).toContain(`id="${id}"`);
|
||||
});
|
||||
});
|
||||
|
||||
describe('the row is wired into the adoption panel', () => {
|
||||
it('lives in the adopt-only block and starts hidden', () => {
|
||||
expect(html).toMatch(/id="dockerAdoptCloneRow"[^>]*hidden/);
|
||||
|
||||
Reference in New Issue
Block a user