BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-09 08:59:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(split): Pane B and its PTY never disagree about size (#464)

Browse Source 
- Font size, family and weight changes refit Pane B AND tell its PTY.
  They used to reflow the xterm only, leaving the CLI wrapping at the old
  column count, the garbled-redraw class #464 fixed for the primary pane.
- The resize frame reports the size the xterm actually holds, with no
  40x10 floor (the divider's 20% clamp leaves about 28 columns), skips
  an unchanged size, and is always re-sent on a fresh socket so it
  re-registers as a desktop viewer.
- The server's {t:'zc'} geometry report is handled: a different column
  count is adopted, rows stay local, using the primary pane's own
  reconcilePtyGeometry verdict.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Codeman maintainer
2026-10-06 10:07:40 +02:00
parent 0ec17633ba
commit a54ad81684
4 changed files with 171 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/terminal-font-weight.test.ts
+7 -5
View File
@@ -67,7 +67,7 @@ function makeApp(
opts: {
teammates?: number;
terminal?: ReturnType<typeof fakeTerminal> | null;
splitPane?: { terminal: ReturnType<typeof fakeTerminal>; localFit: () => void } | null;
splitPane?: { terminal: ReturnType<typeof fakeTerminal>; fit: () => void } | null;
} = {}
) {
const fit = vi.fn();
@@ -108,10 +108,12 @@ function makeApp(
}
describe('applyTerminalFontWeights', () => {
it('reaches an open split pane: same weights, refit in place', () => {
it('reaches an open split pane: same weights, refit AND reported to its PTY', () => {
const splitTerminal = fakeTerminal();
const localFit = vi.fn();
const { app } = makeApp({ splitPane: { terminal: splitTerminal, localFit } });
// fit(), not localFit(): a weight change can move the cell size, and the
// split pane's PTY must hear about the new geometry like the primary's does.
const fit = vi.fn();
const { app } = makeApp({ splitPane: { terminal: splitTerminal, fit } });
(app as unknown as { applyTerminalFontWeights: (s: unknown) => void }).applyTerminalFontWeights({
terminalFontWeight: '300',
@@ -120,7 +122,7 @@ describe('applyTerminalFontWeights', () => {
expect(splitTerminal.options.fontWeight).toBe(300);
expect(splitTerminal.options.fontWeightBold).toBe(700);
expect(localFit).toHaveBeenCalledTimes(1);
expect(fit).toHaveBeenCalledTimes(1);
});
it('writes both slots to the live terminal', () => {