BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-04 22:49:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge PR #122: restore response-viewer eye button on mobile

Browse Source 
Remove the dead mobile-collapsed header tray that hid the entire header-right cluster (incl. the opt-in response-viewer eye) on phones/tablets, and update the mobile test to assert inline reachability. Eye stays hidden by default (showResponseViewer).
This commit is contained in:
Ark0N
2026-06-14 19:46:11 +02:00
committed by GitHub
parent e742d00c98 a68f23e647
commit a122e867ef
3 changed files with 14 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/mobile/tabs.test.ts
+8 -5
View File
@@ -132,13 +132,16 @@ describe('Tab Navigation', () => {
expect(modalClass).toMatch(/active/);
});
it('header has no utility toggle and the tray stays collapsed on mobile', async () => {
it('header has no utility toggle and the tray is reachable inline on mobile', async () => {
// The three-dot header utility toggle was removed (owner decision,
// 2026-06-10): nothing interactive may occupy the top-left corner, and
// the headerRight tray stays collapsed (hidden) on small viewports.
// 2026-06-10) and the collapsible position:fixed headerRight tray it
// controlled was dropped (PR #122): with the toggle gone, leaving the
// tray collapsed made every header-right utility — including the opt-in
// response-viewer eye button — permanently unreachable on phones. The
// utilities now flow INLINE and must stay reachable on small viewports;
// nothing interactive may occupy the top-left corner.
await page.evaluate(() => {
document.querySelectorAll('.modal.active').forEach((modal) => modal.classList.remove('active'));
document.getElementById('headerRight')?.classList.add('mobile-collapsed');
});
const toggleCount = await page.locator('#mobileHeaderUtilityToggle').count();
@@ -148,7 +151,7 @@ describe('Tab Navigation', () => {
const tray = document.getElementById('headerRight');
return tray ? getComputedStyle(tray).display !== 'none' : false;
});
expect(trayVisible).toBe(false);
expect(trayVisible).toBe(true);
});
it('tabs remain visible on large phone and tablet headers', async () => {