BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-09-30 12:39:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #441 from shenlvkang-collab/fix/android-last-char

Browse Source 
fix(input): deliver a recovered keystroke before the Enter that submits it
This commit is contained in:
Ark0N
2026-09-18 13:41:21 +02:00
committed by GitHub
parent 9d7b29d899 a1c35da0d8
commit 9a503872d9
3 changed files with 88 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/android-last-character-on-enter.md
+5
View File
@@ -0,0 +1,5 @@
---
"aicodeman": patch
---
Stop a phone keyboard losing the last character of every message it sends. Android soft keyboards commit the last typed character and send the Enter key in one InputConnection transaction, so the `input` event and the Enter keydown are both processed before any zero-delay timer runs. The orphaned-input recovery from #388 only resolved its candidate on such a timer, and lost it both ways: xterm emits `\r` synchronously from the Enter keydown, so the local-echo composer submitted the prompt before the recovered character existed, and that `\r` bumped the "did xterm speak for this keystroke" counter, so the candidate then stood itself down and dropped the character outright. Pending candidates are now drained synchronously at the next keydown, from xterm's custom key handler — before xterm processes that key — so the counter still holds the value it had while the candidate's own keystroke was current, and the recovered byte reaches the composer ahead of the Enter. Typing on a physical keyboard is unaffected: there, the timer has already resolved the candidate before the next key arrives.