From 6f64e557e528e89ade6517e5cdf9fc33ac749192 Mon Sep 17 00:00:00 2001
From: timkjr <timkjr@k-lab.lan>
Date: Tue, 15 Sep 2026 23:37:26 -0500
Subject: [PATCH] docs(plan): fix session-creation test bug found by Task 4's
 implementer
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Task 4's implementer found two real bugs in this plan's browser-test
helpers: POST /api/sessions nests the id at data.session.id (not
data.id), and mode:'shell' needs a follow-up POST .../shell to actually
spawn a PTY. Fixed in Task 4's own snippet (documentation accuracy —
already fixed in the real committed code) and pre-emptively in Tasks
5/6's createShellSession() helper before either was dispatched, so
neither implementer has to rediscover it independently. Also corrected
the <script> tag snippet to defer, matching the real file's convention.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 .../plans/2026-09-15-split-pane-sessions.md   | 31 ++++++++++++++++---
 1 file changed, 26 insertions(+), 5 deletions(-)

diff --git a/docs/superpowers/plans/2026-09-15-split-pane-sessions.md b/docs/superpowers/plans/2026-09-15-split-pane-sessions.md
index 98acacd5..9c95a26b 100644
--- a/docs/superpowers/plans/2026-09-15-split-pane-sessions.md
+++ b/docs/superpowers/plans/2026-09-15-split-pane-sessions.md
@@ -453,7 +453,14 @@ describe('SplitTerminalPane in a real browser', () => {
         headers: { 'Content-Type': 'application/json' },
         body: JSON.stringify({ workingDir: '/tmp', mode: 'shell' }),
       });
-      return (await res.json()).data.id;
+      // POST /api/sessions nests the session under data.session, and mode:'shell'
+      // does not spawn a PTY on creation alone (pid: null, no pane) — an explicit
+      // POST .../shell is what actually starts it (both were bugs in this plan's
+      // original text, found and fixed by Task 4's implementer against the real
+      // server; corrected here to match what was actually committed).
+      const id = (await res.json()).data.session.id;
+      await fetch(`/api/sessions/${id}/shell`, { method: 'POST' });
+      return id;
     });
 
     const result = await page.evaluate(async (id) => {
@@ -624,10 +631,10 @@ Expected: This file is not yet listed in `config/test-suites.ts`'s `BROWSER_TEST
 })(window);
 ```
 
-In `src/web/public/index.html`, find the `<script src="terminal-ui.js">` tag and add immediately after it:
+In `src/web/public/index.html`, find the `<script src="terminal-ui.js">` tag — check whether it (and its neighbors) actually carry a `defer` attribute in the real file before copying this verbatim; match whatever the surrounding block's real convention is — and add immediately after it:
 
 ```html
-<script src="terminal-split.js"></script>
+<script defer src="terminal-split.js"></script>
 ```
 
 In `CLAUDE.md`, find the Frontend load-order line (`... → terminal-ui.js(7) → respawn-ui.js(8) → ...`) and insert `terminal-split.js(7.5)` between them, matching the existing `X.Y of 16` `@loadorder` numbering convention already used for other `.5`-numbered modules (e.g. `tab-rail-resize.js(6.5)`).
@@ -704,7 +711,14 @@ describe('split-pane orchestration in a real browser', () => {
         headers: { 'Content-Type': 'application/json' },
         body: JSON.stringify({ workingDir: '/tmp', mode: 'shell' }),
       });
-      return (await res.json()).data.id;
+      // POST /api/sessions nests the session under data.session, and mode:'shell'
+      // does not spawn a PTY on creation alone (pid: null, no pane) — an explicit
+      // POST .../shell is what actually starts it (both found and fixed by Task 4's
+      // implementer against this exact pattern; carried forward here so this task
+      // does not rediscover the same two bugs).
+      const id = (await res.json()).data.session.id;
+      await fetch(`/api/sessions/${id}/shell`, { method: 'POST' });
+      return id;
     });
   }
 
@@ -971,7 +985,14 @@ describe('split-pane auto-collapse in a real browser', () => {
         headers: { 'Content-Type': 'application/json' },
         body: JSON.stringify({ workingDir: '/tmp', mode: 'shell' }),
       });
-      return (await res.json()).data.id;
+      // POST /api/sessions nests the session under data.session, and mode:'shell'
+      // does not spawn a PTY on creation alone (pid: null, no pane) — an explicit
+      // POST .../shell is what actually starts it (both found and fixed by Task 4's
+      // implementer against this exact pattern; carried forward here so this task
+      // does not rediscover the same two bugs).
+      const id = (await res.json()).data.session.id;
+      await fetch(`/api/sessions/${id}/shell`, { method: 'POST' });
+      return id;
     });
   }