mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-10-12 02:09:42 +02:00
fix(git): pin git's locale for clone, so failures classify on any host
classifyGitFailure() matches git's English stderr, but cloneRepository() spawned git with gitNonInteractiveEnv(), which left the host's locale in place. Under de_DE.UTF-8 a missing ref came back as FAILED / 422 instead of REF_NOT_FOUND / 400, and a missing repository as 422 instead of 404; the clone dialog showed "git failed: Schwerwiegend: …". gitNonInteractiveEnv() now sets LC_ALL=C and LANG=C, as git-workspace-status.ts already does. Two tests depended on the locale on their own: - git-status-routes: the spy runner called git without the production runner's LC_ALL=C, so "Kein Git-Repository" was not recognised. - custom-model-run-menu-ui: the modal formats with toLocaleString(), the test hard-coded 16,384 and 40,000. Full suite under de_DE.UTF-8: 5 failed before, 0 after. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
committed by
Codeman maintainer
co-authored by
Claude Opus 5.5
parent
3a0cee6b90
commit
6ba311f38d
@@ -1342,8 +1342,8 @@ describe('Custom Model Endpoint Profiles: _confirmContextWarning (in-app modal,
|
||||
expect(modal.classList.contains('active')).toBe(true);
|
||||
const message = win.document.getElementById('customModelContextWarningMessage')!.textContent!;
|
||||
expect(message).toContain('qwen3.8-27b-ud-q4_k_xl');
|
||||
expect(message).toContain('16,384');
|
||||
expect(message).toContain('40,000');
|
||||
expect(message).toContain((16384).toLocaleString()); // the modal formats for the user's locale
|
||||
expect(message).toContain((40000).toLocaleString());
|
||||
expect(message).toMatch(/llama-swap/i);
|
||||
expect(message).toMatch(/fit-ctx/i);
|
||||
|
||||
|
||||
@@ -14,6 +14,8 @@ import { clearGitStatusCache, runGit, type GitRunner } from '../../src/git-works
|
||||
|
||||
const ENV = {
|
||||
...process.env,
|
||||
// As the production runner (git-workspace-status.ts): git's not-a-repo message is matched in English.
|
||||
LC_ALL: 'C',
|
||||
GIT_AUTHOR_NAME: 'T',
|
||||
GIT_AUTHOR_EMAIL: 't@example.com',
|
||||
GIT_COMMITTER_NAME: 'T',
|
||||
|
||||
Reference in New Issue
Block a user