BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-06 15:39:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #423 from Ark0N/fix/xterm6-selection-background

Browse Source 
fix(terminal): name the selection colour the way xterm 6 does
This commit is contained in:
Codeman maintainer
2026-09-14 23:35:43 +02:00
parent e54a8b1189 9acc5aad50
commit 653e3cdf96
3 changed files with 86 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/xterm6-selection-background.md
+5
View File
@@ -0,0 +1,5 @@
---
"aicodeman": patch
---
Fix an invisible terminal text selection on the light skins (#360). Every xterm palette declared its selection colour under the key `selection`, which xterm.js renamed to `selectionBackground` in v5. An `ITheme` is a plain object, so the unknown key was dropped without an error and every skin fell back to xterm's own default of `rgba(255,255,255,0.3)`: unnoticeable on the dark skins, which wanted roughly that anyway, and effectively invisible on Paper Gray, Solarized Light, Catppuccin Latte and Rosé Pine Dawn, where white at 30% over a near-white background moves a channel by about 3/255. Selecting text on those skins now highlights it, with desktop drag-select and the mobile long-press both fixed by the same rename.