BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-09-30 12:39:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #225 from christianhaberl/fix/bound-the-process-tree-walk

Browse Source 
fix(mux): bound the process-tree walk — unbounded pgrep recursion can take a machine down
This commit is contained in:
Ark0N
2026-08-08 01:31:00 +02:00
committed by GitHub
parent cb95a8562c 2e69e28e71
commit 52571c7fd4
4 changed files with 421 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/bounded-process-tree-walk.md
+17
View File
@@ -0,0 +1,17 @@
---
'aicodeman': patch
---
Bound the process-tree walk that could take a machine down.
`getChildPids` ran `pgrep -P <pid>` per node and recursed with no visited set, no
depth limit and no node cap. Across ~28 adopted tmux trees the fan-out exploded,
and because each `pgrep` blocks in the kernel while reading `/proc/<pid>/cgroup`
under WSL, none returned while the walk kept spawning more — ~13,000 `pgrep`
processes stuck in D-state out of ~39,000 total, load average above 13,000,
recoverable only by restarting WSL.
Now: one `ps` snapshot, breadth-first with a visited set, a depth cap and a node
cap, in a pure module (`proc-tree.ts`) that the regression tests exercise
directly. The snapshot is refreshed asynchronously, and the kill path forces a
fresh one so the SIGKILL escalation cannot re-read pre-SIGTERM state.