mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-10-08 16:39:42 +02:00
COD-52 fix: wire maxTodos + todoExpirationMinutes through ralph-config to the tracker
The Ralph settings modal sent maxTodos/todoExpirationMinutes but RalphConfigSchema (zod) stripped them and the ralph-config route never applied them, so the inputs were silent no-ops. Fix: add both as optional positive-int fields to RalphConfigSchema; destructure and apply them in the ralph-config route (matching the maxIterations pattern). RalphTracker had no setters (the values were module constants) — added per-instance _maxTodos/_todoExpiryMs (defaulting to the same constants, behavior unchanged), switched the eviction + expiry sites to read them, and added setMaxTodos/setTodoExpirationMinutes (minutes→ms) + getters. Test: route test POSTs the two fields and asserts the route applies them to the tracker. Verified RED (setters not called — fields stripped) → GREEN. 34/34 ralph-routes tests pass; tsc + eslint(src) + prettier + build clean. Frontend already sent the fields (no change).
This commit is contained in:
+37
-3
@@ -467,6 +467,12 @@ export class RalphTracker extends EventEmitter {
|
|||||||
/** Timestamp of last cleanup check for throttling */
|
/** Timestamp of last cleanup check for throttling */
|
||||||
private _lastCleanupTime: number = 0;
|
private _lastCleanupTime: number = 0;
|
||||||
|
|
||||||
|
/** Maximum number of todos retained for this session (defaults to global cap) */
|
||||||
|
private _maxTodos: number = MAX_TODOS_PER_SESSION;
|
||||||
|
|
||||||
|
/** Todo auto-expiry duration in milliseconds (defaults to global constant) */
|
||||||
|
private _todoExpiryMs: number = TODO_EXPIRY_MS;
|
||||||
|
|
||||||
/** Debouncer for todoUpdate events */
|
/** Debouncer for todoUpdate events */
|
||||||
private _todoDeb = new Debouncer(EVENT_DEBOUNCE_MS);
|
private _todoDeb = new Debouncer(EVENT_DEBOUNCE_MS);
|
||||||
|
|
||||||
@@ -1840,7 +1846,7 @@ export class RalphTracker extends EventEmitter {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
while (this._todos.size >= MAX_TODOS_PER_SESSION) {
|
while (this._todos.size >= this._maxTodos) {
|
||||||
const oldest = this.findOldestTodo();
|
const oldest = this.findOldestTodo();
|
||||||
if (oldest) {
|
if (oldest) {
|
||||||
this._todos.delete(oldest.id);
|
this._todos.delete(oldest.id);
|
||||||
@@ -2164,14 +2170,14 @@ export class RalphTracker extends EventEmitter {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Remove todo items older than TODO_EXPIRY_MS.
|
* Remove todo items older than the configured expiry duration.
|
||||||
*/
|
*/
|
||||||
private cleanupExpiredTodos(): void {
|
private cleanupExpiredTodos(): void {
|
||||||
const now = Date.now();
|
const now = Date.now();
|
||||||
const toDelete: string[] = [];
|
const toDelete: string[] = [];
|
||||||
|
|
||||||
for (const [id, todo] of this._todos) {
|
for (const [id, todo] of this._todos) {
|
||||||
if (now - todo.detectedAt > TODO_EXPIRY_MS) {
|
if (now - todo.detectedAt > this._todoExpiryMs) {
|
||||||
toDelete.push(id);
|
toDelete.push(id);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -2211,6 +2217,34 @@ export class RalphTracker extends EventEmitter {
|
|||||||
this.emit('loopUpdate', this.loopState);
|
this.emit('loopUpdate', this.loopState);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Maximum number of todos retained for this session. */
|
||||||
|
get maxTodos(): number {
|
||||||
|
return this._maxTodos;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Todo auto-expiry duration in minutes for this session. */
|
||||||
|
get todoExpirationMinutes(): number {
|
||||||
|
return Math.round(this._todoExpiryMs / 60000);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Update the maximum number of retained todos (external API).
|
||||||
|
* Ignores non-positive values.
|
||||||
|
*/
|
||||||
|
setMaxTodos(maxTodos: number): void {
|
||||||
|
if (!Number.isFinite(maxTodos) || maxTodos <= 0) return;
|
||||||
|
this._maxTodos = Math.floor(maxTodos);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Update the todo auto-expiry duration (external API), specified in minutes.
|
||||||
|
* Converts to milliseconds internally. Ignores non-positive values.
|
||||||
|
*/
|
||||||
|
setTodoExpirationMinutes(minutes: number): void {
|
||||||
|
if (!Number.isFinite(minutes) || minutes <= 0) return;
|
||||||
|
this._todoExpiryMs = Math.floor(minutes) * 60000;
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Configure the tracker from external state.
|
* Configure the tracker from external state.
|
||||||
*/
|
*/
|
||||||
|
|||||||
@@ -32,17 +32,16 @@ export function registerRalphRoutes(
|
|||||||
// Configure Ralph tracker for a session
|
// Configure Ralph tracker for a session
|
||||||
app.post('/api/sessions/:id/ralph-config', async (req) => {
|
app.post('/api/sessions/:id/ralph-config', async (req) => {
|
||||||
const { id } = req.params as { id: string };
|
const { id } = req.params as { id: string };
|
||||||
const { enabled, completionPhrase, maxIterations, reset, disableAutoEnable } = parseBody(
|
const { enabled, completionPhrase, maxIterations, maxTodos, todoExpirationMinutes, reset, disableAutoEnable } =
|
||||||
RalphConfigSchema,
|
parseBody(RalphConfigSchema, req.body, 'Invalid request body') as {
|
||||||
req.body,
|
enabled?: boolean;
|
||||||
'Invalid request body'
|
completionPhrase?: string;
|
||||||
) as {
|
maxIterations?: number;
|
||||||
enabled?: boolean;
|
maxTodos?: number;
|
||||||
completionPhrase?: string;
|
todoExpirationMinutes?: number;
|
||||||
maxIterations?: number;
|
reset?: boolean | 'full';
|
||||||
reset?: boolean | 'full';
|
disableAutoEnable?: boolean;
|
||||||
disableAutoEnable?: boolean;
|
};
|
||||||
};
|
|
||||||
const session = findSessionOrFail(ctx, id);
|
const session = findSessionOrFail(ctx, id);
|
||||||
|
|
||||||
// Ralph tracker is not supported for external-CLI sessions (opencode/codex)
|
// Ralph tracker is not supported for external-CLI sessions (opencode/codex)
|
||||||
@@ -98,6 +97,14 @@ export function registerRalphRoutes(
|
|||||||
session.ralphTracker.setMaxIterations(maxIterations || null);
|
session.ralphTracker.setMaxIterations(maxIterations || null);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (maxTodos !== undefined) {
|
||||||
|
session.ralphTracker.setMaxTodos(maxTodos);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (todoExpirationMinutes !== undefined) {
|
||||||
|
session.ralphTracker.setTodoExpirationMinutes(todoExpirationMinutes);
|
||||||
|
}
|
||||||
|
|
||||||
// Persist and broadcast the update
|
// Persist and broadcast the update
|
||||||
ctx.persistSessionState(session);
|
ctx.persistSessionState(session);
|
||||||
ctx.broadcast(SseEvent.SessionRalphLoopUpdate, {
|
ctx.broadcast(SseEvent.SessionRalphLoopUpdate, {
|
||||||
|
|||||||
@@ -497,6 +497,8 @@ export const RalphConfigSchema = z.object({
|
|||||||
enabled: z.boolean().optional(),
|
enabled: z.boolean().optional(),
|
||||||
completionPhrase: z.string().max(500).optional(),
|
completionPhrase: z.string().max(500).optional(),
|
||||||
maxIterations: z.number().int().min(0).max(10000).optional(),
|
maxIterations: z.number().int().min(0).max(10000).optional(),
|
||||||
|
maxTodos: z.number().int().positive().max(10000).optional(),
|
||||||
|
todoExpirationMinutes: z.number().int().positive().max(525600).optional(),
|
||||||
reset: z.union([z.boolean(), z.literal('full')]).optional(),
|
reset: z.union([z.boolean(), z.literal('full')]).optional(),
|
||||||
disableAutoEnable: z.boolean().optional(),
|
disableAutoEnable: z.boolean().optional(),
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -21,6 +21,8 @@ function createMockRalphTracker() {
|
|||||||
disableAutoEnable: vi.fn(),
|
disableAutoEnable: vi.fn(),
|
||||||
startLoop: vi.fn(),
|
startLoop: vi.fn(),
|
||||||
setMaxIterations: vi.fn(),
|
setMaxIterations: vi.fn(),
|
||||||
|
setMaxTodos: vi.fn(),
|
||||||
|
setTodoExpirationMinutes: vi.fn(),
|
||||||
resetCircuitBreaker: vi.fn(),
|
resetCircuitBreaker: vi.fn(),
|
||||||
generateFixPlanMarkdown: vi.fn(() => '# Fix Plan\n\n- [ ] Task 1\n'),
|
generateFixPlanMarkdown: vi.fn(() => '# Fix Plan\n\n- [ ] Task 1\n'),
|
||||||
importFixPlanMarkdown: vi.fn(() => 3),
|
importFixPlanMarkdown: vi.fn(() => 3),
|
||||||
@@ -158,6 +160,25 @@ describe('ralph-routes', () => {
|
|||||||
expect(tracker.setMaxIterations).toHaveBeenCalledWith(50);
|
expect(tracker.setMaxIterations).toHaveBeenCalledWith(50);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('applies maxTodos and todoExpirationMinutes to the tracker (COD-52)', async () => {
|
||||||
|
const tracker = (harness.ctx._session as Record<string, unknown>).ralphTracker as ReturnType<
|
||||||
|
typeof createMockRalphTracker
|
||||||
|
>;
|
||||||
|
|
||||||
|
const res = await harness.app.inject({
|
||||||
|
method: 'POST',
|
||||||
|
url: `/api/sessions/${harness.ctx._sessionId}/ralph-config`,
|
||||||
|
payload: { maxTodos: 25, todoExpirationMinutes: 90 },
|
||||||
|
});
|
||||||
|
expect(res.statusCode).toBe(200);
|
||||||
|
const body = JSON.parse(res.body);
|
||||||
|
// The ralph-config success path returns a bare {} envelope (matching its
|
||||||
|
// sibling config routes); an error would surface as { success: false }.
|
||||||
|
expect(body.success).not.toBe(false);
|
||||||
|
expect(tracker.setMaxTodos).toHaveBeenCalledWith(25);
|
||||||
|
expect(tracker.setTodoExpirationMinutes).toHaveBeenCalledWith(90);
|
||||||
|
});
|
||||||
|
|
||||||
it('returns error for unknown session', async () => {
|
it('returns error for unknown session', async () => {
|
||||||
const res = await harness.app.inject({
|
const res = await harness.app.inject({
|
||||||
method: 'POST',
|
method: 'POST',
|
||||||
|
|||||||
Reference in New Issue
Block a user