mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-10-07 16:09:43 +02:00
feat(api): establish stable HTTP contract — uniform {success,data} envelope, status codes, /api/v1
Point 1 of the v1.0 lock-in: commit to a stable HTTP API (the cleanest, fullest form).
Core (centralized):
- Every JSON /api response now uses ONE envelope via a Fastify preSerialization hook (src/web/server.ts): success -> { success:true, data:<payload> }; error -> { success:false, error, errorCode } with a conventional HTTP status. Non-JSON routes (file-raw, tail-file SSE, download, screenshots, /q redirect, WS) are skipped.
- Error-code -> HTTP status is a single source of truth (httpStatusForErrorCode in src/types/api.ts): 400/401/404/409/422/429/500. Expanded ApiErrorCode (added UNAUTHORIZED, CONFLICT, RATE_LIMITED). Errors are no longer HTTP 200.
- Versioned alias: /api/v1/* rewrites to /api/* (rewriteApiV1Url), so external clients pin to a stable surface while the bundled UI keeps using /api/*.
- Handlers stripped of manual 'success:true' (50 across 14 route files) so they return bare payloads the hook wraps uniformly; fixed the mux DELETE {success:<bool>} envelope collision (-> {killed}).
Frontend (48 call sites across 10 files):
- _apiJson() auto-unwraps { success:true, data } -> data (null on error), so most bare-shape readers are transparent. Raw-fetch sites relocate payload reads under .data; success/res.ok/error checks unchanged.
Docs: new docs/api-reference.md (envelope, status table, error codes, /api/v1, SSE); versioning-policy.md flipped — the HTTP/SSE API is now part of the stable, SemVer-covered surface.
Verification: full unit/route suite green (2680 passed) incl. ~166 updated assertions across 24 test files; typecheck/lint/format/frontend-syntax clean; a headless-chromium smoke loaded the migrated UI and drove the panels with 0 console/page errors; /api/status and /api/v1/status confirmed returning the uniform envelope live.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
+12
-12
@@ -32,21 +32,21 @@ describe('generateHooksConfig', () => {
|
||||
it('should configure idle_prompt matcher', () => {
|
||||
const config = generateHooksConfig();
|
||||
const notifHooks = config.hooks.Notification as Array<{ matcher?: string }>;
|
||||
const idleHook = notifHooks.find(h => h.matcher === 'idle_prompt');
|
||||
const idleHook = notifHooks.find((h) => h.matcher === 'idle_prompt');
|
||||
expect(idleHook).toBeDefined();
|
||||
});
|
||||
|
||||
it('should configure permission_prompt matcher', () => {
|
||||
const config = generateHooksConfig();
|
||||
const notifHooks = config.hooks.Notification as Array<{ matcher?: string }>;
|
||||
const permHook = notifHooks.find(h => h.matcher === 'permission_prompt');
|
||||
const permHook = notifHooks.find((h) => h.matcher === 'permission_prompt');
|
||||
expect(permHook).toBeDefined();
|
||||
});
|
||||
|
||||
it('should configure elicitation_dialog matcher', () => {
|
||||
const config = generateHooksConfig();
|
||||
const notifHooks = config.hooks.Notification as Array<{ matcher?: string }>;
|
||||
const elicitHook = notifHooks.find(h => h.matcher === 'elicitation_dialog');
|
||||
const elicitHook = notifHooks.find((h) => h.matcher === 'elicitation_dialog');
|
||||
expect(elicitHook).toBeDefined();
|
||||
});
|
||||
|
||||
@@ -146,7 +146,7 @@ describe('writeHooksConfig', () => {
|
||||
mkdirSync(claudeDir, { recursive: true });
|
||||
writeFileSync(
|
||||
join(claudeDir, 'settings.local.json'),
|
||||
JSON.stringify({ existingKey: 'existingValue', permissions: { allow: ['Read'] } }, null, 2),
|
||||
JSON.stringify({ existingKey: 'existingValue', permissions: { allow: ['Read'] } }, null, 2)
|
||||
);
|
||||
|
||||
await writeHooksConfig(testDir);
|
||||
@@ -160,10 +160,7 @@ describe('writeHooksConfig', () => {
|
||||
it('should overwrite existing hooks key', async () => {
|
||||
const claudeDir = join(testDir, '.claude');
|
||||
mkdirSync(claudeDir, { recursive: true });
|
||||
writeFileSync(
|
||||
join(claudeDir, 'settings.local.json'),
|
||||
JSON.stringify({ hooks: { oldHook: [] } }, null, 2),
|
||||
);
|
||||
writeFileSync(join(claudeDir, 'settings.local.json'), JSON.stringify({ hooks: { oldHook: [] } }, null, 2));
|
||||
|
||||
await writeHooksConfig(testDir);
|
||||
|
||||
@@ -214,7 +211,7 @@ describe('Hook Event API', () => {
|
||||
body: JSON.stringify({}),
|
||||
});
|
||||
const createData = await createRes.json();
|
||||
testSessionId = createData.session.id;
|
||||
testSessionId = createData.data.session.id;
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
@@ -396,7 +393,7 @@ describe('Hook Data Sanitization', () => {
|
||||
body: JSON.stringify({}),
|
||||
});
|
||||
const createData = await createRes.json();
|
||||
testSessionId = createData.session.id;
|
||||
testSessionId = createData.data.session.id;
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
@@ -641,7 +638,7 @@ describe('Hook Config Generation - Extended', () => {
|
||||
it('should include all event types', () => {
|
||||
const config = generateHooksConfig();
|
||||
const notifHooks = config.hooks.Notification as Array<{ matcher?: string }>;
|
||||
const matchers = notifHooks.map(n => n.matcher);
|
||||
const matchers = notifHooks.map((n) => n.matcher);
|
||||
expect(matchers).toContain('idle_prompt');
|
||||
expect(matchers).toContain('permission_prompt');
|
||||
expect(matchers).toContain('elicitation_dialog');
|
||||
@@ -694,7 +691,10 @@ describe('Hook Config Generation - Extended', () => {
|
||||
|
||||
it('should have consistent structure across all notification hooks', () => {
|
||||
const config = generateHooksConfig();
|
||||
const notifHooks = config.hooks.Notification as Array<{ matcher: string; hooks: Array<{ type: string; command: string; timeout: number }> }>;
|
||||
const notifHooks = config.hooks.Notification as Array<{
|
||||
matcher: string;
|
||||
hooks: Array<{ type: string; command: string; timeout: number }>;
|
||||
}>;
|
||||
|
||||
for (const hook of notifHooks) {
|
||||
expect(hook.matcher).toBeDefined();
|
||||
|
||||
Reference in New Issue
Block a user