fix(session-options): keep Respawn and Ralph visible for Claude sessions

Since the CLI registry gave claude kind 'agent' (#476), isExternalCliRunMode() reads claude as an external CLI, so Session Options opened every Claude session on Summary and hid the Respawn and Ralph tabs and every Claude-only control (auto-resume, the respawn loop). The browser catalog now carries the registry's capabilities.external, the flag the server's isExternalCliMode() already reads, and Session Options asks that instead. run() keeps isExternalCliRunMode(): choosing a launch path is a different question, and custom agents rely on it.
This commit is contained in:
JD
2026-10-08 00:15:50 -04:00
parent ac94f339ac
commit 45492a3013
4 changed files with 36 additions and 4 deletions
+9 -2
View File
@@ -248,16 +248,23 @@ describe('WebServer.renderIndexHtml', () => {
shortBadge: string;
order: number;
kind: string;
external: boolean;
enabled: boolean;
available: boolean;
}>;
expect(catalog.map((entry) => entry.id)).toEqual(STOCK_CLIS.map((entry) => entry.id));
expect(catalog.find((entry) => entry.id === 'codex')).toMatchObject({ label: 'Codex', kind: 'agent' });
expect(catalog.find((entry) => entry.id === 'codex')).toMatchObject({
label: 'Codex',
kind: 'agent',
external: true,
});
// claude is `kind: 'agent'` too; `external` is what keeps its Respawn/Ralph options visible.
expect(catalog.find((entry) => entry.id === 'claude')).toMatchObject({ kind: 'agent', external: false });
expect(catalog.find((entry) => entry.id === 'shell')).toMatchObject({ enabled: true, available: true });
expect(
catalog.every((entry) =>
Object.keys(entry).every((key) =>
['id', 'label', 'shortBadge', 'order', 'kind', 'enabled', 'available'].includes(key)
['id', 'label', 'shortBadge', 'order', 'kind', 'external', 'enabled', 'available'].includes(key)
)
)
).toBe(true);
+18 -1
View File
@@ -453,7 +453,15 @@ describe('Codex quick start settings', () => {
const src = readFileSync(resolve(import.meta.dirname, `../src/web/public/${file}`), 'utf8');
vm.runInContext(src, context, { filename: file });
}
return { app: new (CodemanApp as any)(), welcomeCliActions, tunnelBtn, runModeCliOptions, modeBtns, menu };
return {
app: new (CodemanApp as any)(),
welcomeCliActions,
tunnelBtn,
runModeCliOptions,
modeBtns,
menu,
context,
};
}
const ALL_OFF = {
@@ -539,6 +547,15 @@ describe('Codex quick start settings', () => {
expect(src).not.toContain('data-mode="codex"');
});
it('keeps Claude-only session options for claude even though it is a registry agent', () => {
const catalog = CATALOG.map((cli) => ({ ...cli, external: cli.id !== 'claude' && cli.id !== 'shell' }));
const { context } = loadUi(undefined, catalog);
expect(context.isExternalCliSession('claude')).toBe(false);
expect(context.isExternalCliSession('shell')).toBe(false);
expect(context.isExternalCliSession('codex')).toBe(true);
expect(context.isExternalCliSession('custom-agent')).toBe(true);
});
it('shows everything when the flags were never injected', () => {
// A cached page from a build without the injection, or a solo popup. Hiding
// every run button on a doubt would leave a working install nothing to click.