BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-06 15:39:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: address medium severity issues from code review

Browse Source 
- Fix inconsistent null handling in state-store (use ?? instead of ||)
- Add JSON.stringify error handling with specific messages
- Add error handling for SSE init event in app.js
- Fix spawn orchestrator silent failures (add logging)
- Fix statSync race condition in subagent-watcher
- Fix unbounded _taskNumberToContent Map in ralph-tracker
- Fix YAML pattern case sensitivity in ralph-config

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
arkon
2026-01-26 13:58:34 +01:00
co-authored by Claude Opus 4.5
parent e81dc4665a
commit 3c2e89f427
9 changed files with 106 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/state-store.ts
+21 -7
View File
@@ -123,11 +123,18 @@ export class StateStore {
this.ensureDir();
// Atomic write: write to temp file, then rename (atomic on POSIX)
const tempPath = this.filePath + '.tmp';
let json: string;
try {
writeFileSync(tempPath, JSON.stringify(this.state, null, 2), 'utf-8');
json = JSON.stringify(this.state, null, 2);
} catch (err) {
console.error('[StateStore] Failed to serialize state (circular reference or invalid data):', err);
throw err;
}
try {
writeFileSync(tempPath, json, 'utf-8');
renameSync(tempPath, this.filePath);
} catch (err) {
console.error('[StateStore] Failed to save state:', err);
console.error('[StateStore] Failed to write state file:', err);
// Try to clean up temp file on error
try {
if (existsSync(tempPath)) {
@@ -156,7 +163,7 @@ export class StateStore {
/** Returns a session state by ID, or null if not found. */
getSession(id: string) {
return this.state.sessions[id] || null;
return this.state.sessions[id] ?? null;
}
/** Sets a session state and triggers a debounced save. */
@@ -178,7 +185,7 @@ export class StateStore {
/** Returns a task state by ID, or null if not found. */
getTask(id: string) {
return this.state.tasks[id] || null;
return this.state.tasks[id] ?? null;
}
/** Sets a task state and triggers a debounced save. */
@@ -457,11 +464,18 @@ export class StateStore {
const data = Object.fromEntries(this.ralphStates);
// Atomic write: write to temp file, then rename (atomic on POSIX)
const tempPath = this.ralphStatePath + '.tmp';
let json: string;
try {
writeFileSync(tempPath, JSON.stringify(data, null, 2), 'utf-8');
json = JSON.stringify(data, null, 2);
} catch (err) {
console.error('[StateStore] Failed to serialize Ralph state (circular reference or invalid data):', err);
throw err;
}
try {
writeFileSync(tempPath, json, 'utf-8');
renameSync(tempPath, this.ralphStatePath);
} catch (err) {
console.error('[StateStore] Failed to save Ralph state:', err);
console.error('[StateStore] Failed to write Ralph state file:', err);
// Try to clean up temp file on error
try {
if (existsSync(tempPath)) {
@@ -475,7 +489,7 @@ export class StateStore {
/** Returns inner state for a session, or null if not found. */
getRalphState(sessionId: string): RalphSessionState | null {
return this.ralphStates.get(sessionId) || null;
return this.ralphStates.get(sessionId) ?? null;
}
/** Sets inner state for a session and triggers a debounced save. */