feat: add type-safe error handling utilities

- Add isError() type guard to check if value is Error instance
- Add getErrorMessage() utility for safe error message extraction
  in catch blocks (handles TypeScript 4.4+ unknown error type)
- Replace all (err as Error).message patterns with getErrorMessage(err)
  across server.ts, cli.ts, ralph-loop.ts, and screen-manager.ts
- Follows TypeScript best practice of treating caught errors as unknown

This improves code safety by properly handling the case where caught
values may not be Error instances (e.g., thrown strings or objects).

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
arkon
2026-01-21 14:07:04 +01:00
co-authored by Claude Opus 4.5
parent c33d6e0987
commit 384350f731
5 changed files with 74 additions and 32 deletions
+5 -4
View File
@@ -13,6 +13,7 @@ import { getSessionManager } from './session-manager.js';
import { getTaskQueue } from './task-queue.js';
import { getRalphLoop } from './ralph-loop.js';
import { getStore } from './state-store.js';
import { getErrorMessage } from './types.js';
const program = new Command();
@@ -40,7 +41,7 @@ sessionCmd
console.log(` Working directory: ${session.workingDir}`);
console.log(` PID: ${session.pid}`);
} catch (err) {
console.error(chalk.red(`✗ Failed to start session: ${(err as Error).message}`));
console.error(chalk.red(`✗ Failed to start session: ${getErrorMessage(err)}`));
process.exit(1);
}
});
@@ -54,7 +55,7 @@ sessionCmd
await manager.stopSession(id);
console.log(chalk.green(`✓ Session stopped: ${id}`));
} catch (err) {
console.error(chalk.red(`✗ Failed to stop session: ${(err as Error).message}`));
console.error(chalk.red(`✗ Failed to stop session: ${getErrorMessage(err)}`));
process.exit(1);
}
});
@@ -474,7 +475,7 @@ program
console.log(chalk.green(`\n✓ Web interface running at http://localhost:${port}`));
console.log(chalk.gray(' Press Ctrl+C to stop\n'));
} catch (err) {
console.error(chalk.red(`✗ Failed to start web server: ${(err as Error).message}`));
console.error(chalk.red(`✗ Failed to start web server: ${getErrorMessage(err)}`));
process.exit(1);
}
});
@@ -496,7 +497,7 @@ program
port,
});
} catch (err) {
console.error(chalk.red(`✗ Failed to start TUI: ${(err as Error).message}`));
console.error(chalk.red(`✗ Failed to start TUI: ${getErrorMessage(err)}`));
process.exit(1);
}
});