BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-10 01:09:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(session-options): keep the external flag when App Settings resyncs the CLI catalog

Browse Source 
_syncCliLaunchCatalog() rebuilt window.__codemanCliCatalog from /api/clis rows, which carry no capabilities, so after App Settings loaded the CLI list isExternalCliSession('claude') fell back to the kind check and Respawn and Ralph disappeared again until a reload. The rebuild now carries external over from the served catalog; a newly created custom CLI has no previous entry and falls back to kind, which is right since custom entries are external. Tests pin the resync and the openSessionOptions() call site, and the /api/clis comment names the page catalog as the deliberate capabilities exception.
This commit is contained in:
JD
2026-10-08 10:05:57 -04:00
parent 45492a3013
commit 354c4641a9
3 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/run-mode-ui.test.ts
+19
View File
@@ -556,6 +556,25 @@ describe('Codex quick start settings', () => {
expect(context.isExternalCliSession('custom-agent')).toBe(true);
});
it('keeps the served external flag when App Settings resyncs the catalog from /api/clis', () => {
const catalog = CATALOG.map((cli) => ({ ...cli, external: cli.id !== 'claude' && cli.id !== 'shell' }));
const { app, context } = loadUi(undefined, catalog);
// /api/clis rows: no capabilities, so no `external`.
app._cliList = CATALOG.map((cli) => ({ ...cli, installed: true }));
app.runMode = 'claude';
app._syncCliLaunchCatalog();
expect(context.isExternalCliSession('claude')).toBe(false);
expect(context.isExternalCliSession('codex')).toBe(true);
});
it('gates Session Options on isExternalCliSession, not the launch-path check', () => {
const src = readFileSync(resolve(import.meta.dirname, '../src/web/public/session-ui.js'), 'utf8');
const open = src.slice(src.indexOf('\n openSessionOptions('));
const body = open.slice(0, open.indexOf('\n },'));
expect(body).toContain('isExternalCliSession(session.mode)');
expect(body).not.toContain('isExternalCliRunMode(');
});
it('shows everything when the flags were never injected', () => {
// A cached page from a build without the injection, or a solo popup. Hiding
// every run button on a doubt would leave a working install nothing to click.