mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-09-30 12:39:42 +02:00
fix(webview): let a proxied single-page app route on its own path, and recover a frame that reloads
A dashboard served through a web tab saw `/webview/<cap>/` as its
`location.pathname`, and no app has a route for that: a React Router, Vue
Router or Vite dev-server page painted its HTML and CSS and then replaced
them with its own "page not found" the moment its script ran (reproduced
with a minimal history-routed page).
The proxy's runtime shim now rewrites the history entry to the path the
page would see on its own origin, before any page script runs. The base
element still resolves relative URLs inside the prefix and every root-
absolute sink is rewritten back into it, so only what the page READS
changes. With the document URL masked the Referer-keyed 404 rescue can no
longer help a request the shim misses, so the remaining URL-taking entry
points (`Worker`, `SharedWorker`, `navigator.sendBeacon`, `window.open`)
are covered by the shim as well.
A navigation the page starts itself afterwards — `location.reload()`
(a dev server's full-reload HMR), a root-absolute `location.href` — lands
on Codeman's root with no capability anywhere: no prefix in the path, no
cookie in an opaque-origin frame, a Referer naming the masked page. It is
recognised by shape (a top-level iframe navigation asking for HTML, for a
path Codeman does not serve) and answered with a static page whose only
script posts `{type:'codeman:webview-lost', path}` to the parent; the tab
that owns the frame (matched by `event.source`, never by the payload)
remounts it inside the prefix at that path, bounded per frame. The
unauthenticated form is answered in the auth middleware before the
credential checks, so a dev server that reloads on every save cannot
rate-limit its own user out of Codeman; the authenticated form (Basic
auth, trusted mode) is answered by the 404 handler.
Verified end to end against a history-routed page: boots on `/`, its
API call succeeds, a reload inside the frame comes back routed on the
path it had pushed, `location.href = '/about'` comes back on `/about`,
and a deep link opens on its path.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5.1
parent
d9eeb039db
commit
349a89ec3b
@@ -40,6 +40,7 @@ interface AppLike {
|
||||
openWebview(id: string, options?: { path?: string }): Promise<void>;
|
||||
_apiJson(path: string, opts?: { method?: string; body?: unknown }): Promise<unknown>;
|
||||
_updateActiveWebviewTab(): void;
|
||||
_installWebviewLostListener(): void;
|
||||
showToast?: (msg: string, kind: string) => void;
|
||||
}
|
||||
|
||||
@@ -226,3 +227,73 @@ describe('callers consult the hook first', () => {
|
||||
expect(section.indexOf('openLinkThroughWebTabIfLoopback?.(urlLink.href)')).toBeGreaterThan(urlHandler);
|
||||
});
|
||||
});
|
||||
|
||||
/**
|
||||
* Lost-frame recovery: the server's recovery page posts `{type, path}` to the
|
||||
* parent; the tab that owns the frame remounts it inside the prefix at that path.
|
||||
*/
|
||||
describe('lost-frame recovery', () => {
|
||||
const lost = (win: Window, source: unknown, path: unknown) =>
|
||||
win.dispatchEvent(
|
||||
new (win as unknown as { MessageEvent: typeof MessageEvent }).MessageEvent('message', {
|
||||
data: { type: 'codeman:webview-lost', path },
|
||||
source: source as Window,
|
||||
})
|
||||
);
|
||||
const frameOf = (win: Window, id: string) =>
|
||||
win.document.querySelector(`.webview-frame[data-webview-id="${id}"] iframe`) as HTMLIFrameElement;
|
||||
|
||||
it('remounts the frame that sent the message at the path it lost, inside the prefix', async () => {
|
||||
const { win, app } = boot();
|
||||
app._installWebviewLostListener();
|
||||
await app.openWebview('dev');
|
||||
const frame = frameOf(win, 'dev');
|
||||
lost(win, frame.contentWindow, '/about?tab=2#top');
|
||||
await vi.waitFor(() => expect(frameSrc(win, 'dev')).toBe('/webview/cap-dev/about?tab=2#top'));
|
||||
expect(frameOf(win, 'dev')).toBe(frame);
|
||||
});
|
||||
|
||||
it('recovers to the landing page for a bare reload', async () => {
|
||||
const { win, app } = boot();
|
||||
app._installWebviewLostListener();
|
||||
await app.openWebview('dev');
|
||||
await app.openUrlInWebTab('http://localhost:5173/deep');
|
||||
expect(frameSrc(win, 'dev')).toBe('/webview/cap-dev/deep');
|
||||
lost(win, frameOf(win, 'dev').contentWindow, '/');
|
||||
await vi.waitFor(() => expect(frameSrc(win, 'dev')).toBe('/webview/cap-dev/'));
|
||||
});
|
||||
|
||||
it('ignores a message that did not come from one of its frames, or is malformed', async () => {
|
||||
const { win, app, calls } = boot();
|
||||
app._installWebviewLostListener();
|
||||
await app.openWebview('dev');
|
||||
const before = calls.length;
|
||||
lost(win, win, '/elsewhere');
|
||||
lost(win, frameOf(win, 'dev').contentWindow, 42);
|
||||
win.dispatchEvent(
|
||||
new (win as unknown as { MessageEvent: typeof MessageEvent }).MessageEvent('message', {
|
||||
data: 'codeman:webview-lost',
|
||||
source: frameOf(win, 'dev').contentWindow as Window,
|
||||
})
|
||||
);
|
||||
await new Promise((r) => setTimeout(r, 20));
|
||||
expect(calls.length).toBe(before);
|
||||
expect(frameSrc(win, 'dev')).toBe('/webview/cap-dev/');
|
||||
});
|
||||
|
||||
it('never lets the path jump the frame off the proxy, and bounds a reload loop', async () => {
|
||||
const { win, app, calls } = boot();
|
||||
app._installWebviewLostListener();
|
||||
await app.openWebview('dev');
|
||||
lost(win, frameOf(win, 'dev').contentWindow, '//evil.example/x');
|
||||
await vi.waitFor(() => expect(calls.filter((c) => c.path.endsWith('/open')).length).toBe(2));
|
||||
expect(frameSrc(win, 'dev')).toBe('/webview/cap-dev/');
|
||||
|
||||
const opensBefore = calls.filter((c) => c.path.endsWith('/open')).length;
|
||||
for (let i = 0; i < 10; i += 1) lost(win, frameOf(win, 'dev').contentWindow, `/spin-${i}`);
|
||||
await new Promise((r) => setTimeout(r, 50));
|
||||
const opens = calls.filter((c) => c.path.endsWith('/open')).length - opensBefore;
|
||||
expect(opens).toBeLessThanOrEqual(5);
|
||||
expect(opens).toBeGreaterThan(0);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user