BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-03 22:19:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #315 from aakhter/fix/respawn-stop-race

Browse Source 
fix(respawn): do not revive a stopped controller after a cycle-step write
This commit is contained in:
Ark0N
2026-08-18 21:15:17 +02:00
committed by GitHub
parent 30f35490f6 ce405a4cff
commit 2e19fc0430
2 changed files with 106 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/respawn-controller.ts
+20
View File
@@ -1624,6 +1624,11 @@ export class RespawnController extends EventEmitter {
const prompt = this.config.kickstartPrompt!;
this.logAction('command', `Sending kickstart: "${prompt.substring(0, 40)}..."`);
await this.session.writeViaMux(prompt + '\r'); // \r triggers key.return in Ink/Claude CLI
// COD-51: stop() may have run during the await; re-check before reviving the
// state machine. Reads the public getter, not `_state`: TypeScript narrows
// `_state` across the await from the guard above and cannot see that stop()
// mutated it, so the comparison would be flagged as impossible.
if (this.state === 'stopped') return;
this.emit('stepSent', 'kickstart', prompt);
this.setState('waiting_kickstart');
this.promptDetected = false;
@@ -2833,6 +2838,11 @@ export class RespawnController extends EventEmitter {
const input = updatePrompt + '\r'; // \r triggers Enter in Ink/Claude CLI
this.logAction('command', `Sending: "${updatePrompt.substring(0, 50)}..."`);
await this.session.writeViaMux(input);
// COD-51: stop() may have run during the await; re-check before reviving the
// state machine. Reads the public getter, not `_state`: TypeScript narrows
// `_state` across the await from the guard above and cannot see that stop()
// mutated it, so the comparison would be flagged as impossible.
if (this.state === 'stopped') return;
this.emit('stepSent', 'update', updatePrompt);
this.setState('waiting_update');
this.promptDetected = false;
@@ -2860,6 +2870,11 @@ export class RespawnController extends EventEmitter {
if (this._state === 'stopped') return;
this.logAction('command', 'Sending: /clear');
await this.session.writeViaMux('/clear\r'); // \r triggers Enter in Ink/Claude CLI
// COD-51: stop() may have run during the await; re-check before reviving the
// state machine. Reads the public getter, not `_state`: TypeScript narrows
// `_state` across the await from the guard above and cannot see that stop()
// mutated it, so the comparison would be flagged as impossible.
if (this.state === 'stopped') return;
this.emit('stepSent', 'clear', '/clear');
this.setState('waiting_clear');
this.promptDetected = false;
@@ -2902,6 +2917,11 @@ export class RespawnController extends EventEmitter {
if (this._state === 'stopped') return;
this.logAction('command', 'Sending: /init');
await this.session.writeViaMux('/init\r'); // \r triggers Enter in Ink/Claude CLI
// COD-51: stop() may have run during the await; re-check before reviving the
// state machine. Reads the public getter, not `_state`: TypeScript narrows
// `_state` across the await from the guard above and cannot see that stop()
// mutated it, so the comparison would be flagged as impossible.
if (this.state === 'stopped') return;
this.emit('stepSent', 'init', '/init');
this.setState('waiting_init');
this.promptDetected = false;