BitSquare/Codeman
2
0
Fork 0
mirror of https://github.com/Ark0N/Codeman.git synced 2026-10-05 15:09:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(settings): lead with version + update, tail the rest of System

Browse Source 
App Settings opened on a System section that mixed the two things worth seeing
immediately (what this install runs, whether a newer release is waiting) with
three groups nobody sets twice (CLAUDE.md template path, default working
directory, image watcher, Cloudflare tunnel).

Split in two. **Updates** is now the first section and carries only the current
version and the update action, so the modal opens on it and the second thing in
reach is Terminal & Input, where Local Echo lives. **System** keeps Paths,
Automation and Remote access and tails the document, last in the rail.

Also fixes the admin-ui load-order test, which broke on this branch: it located
the modules with a bare `indexOf('session-ui.js')`, and the modal markup now
cites those modules in comments well above the script tags, so it was comparing
a comment against a `<script src>`. It matches the script tag itself now.
This commit is contained in:
Codeman maintainer
2026-08-10 12:29:00 +02:00
parent 8d094b086c
commit 1513067a7f
6 changed files with 112 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/admin-ui.test.ts
+10 -5
View File
@@ -135,11 +135,16 @@ describe('admin panel modal', () => {
describe('index.html wiring', () => {
it('loads admin-ui.js after settings-ui.js and before session-ui.js', () => {
const settings = INDEX_HTML.indexOf('settings-ui.js');
const admin = INDEX_HTML.indexOf('admin-ui.js');
const session = INDEX_HTML.indexOf('session-ui.js');
expect(admin).toBeGreaterThan(settings);
expect(session).toBeGreaterThan(admin);
// Match the SCRIPT TAG, not the bare filename: modal markup earlier in the
// document cites these modules in comments ("session-ui.js: openSessionOptions"),
// and a bare indexOf finds the comment instead of the load order.
const at = (file: string) => {
const i = INDEX_HTML.indexOf(`src="${file}"`);
expect(i, `no <script src="${file}"> in index.html`).toBeGreaterThan(-1);
return i;
};
expect(at('admin-ui.js')).toBeGreaterThan(at('settings-ui.js'));
expect(at('session-ui.js')).toBeGreaterThan(at('admin-ui.js'));
});
it('ships the header Admin Panel button hidden by default', () => {
test/app-settings-structure.test.ts
+14 -9
View File
@@ -59,20 +59,25 @@ describe('App Settings modal structure', () => {
}
});
it('opens on System, with the version and the updater above everything else', () => {
expect(settingsUi).toContain("this.switchSettingsTab('settings-system')");
it('opens on Updates: the version and the updater above everything else', () => {
expect(settingsUi).toContain("this.switchSettingsTab('settings-updates')");
const modal = settingsModal();
const order = [...modal.matchAll(/<section class="set-section" id="([a-z-]+)"/g)].map((m) => m[1]);
// Rail and document must agree, or scroll-spy paints the wrong entry.
const rail = [...modal.matchAll(/data-section="([a-z-]+)"/g)].map((m) => m[1]);
expect(rail.slice(0, 3)).toEqual(['settings-system', 'settings-terminal', 'settings-layout']);
expect(order.slice(0, 3)).toEqual(['settings-system', 'settings-terminal', 'settings-layout']);
// Updates leads the System section: version first, then the update action.
expect(rail.slice(0, 3)).toEqual(['settings-updates', 'settings-terminal', 'settings-layout']);
expect(order.slice(0, 3)).toEqual(['settings-updates', 'settings-terminal', 'settings-layout']);
// Updates carries ONLY the version and the update action; the rest of the
// system settings tail the document under System, out of the way.
const updates = modal.match(/id="settings-updates"([\s\S]*?)<\/section>/)?.[1] ?? '';
expect(updates).toContain('id="updateCurrentVersion"');
expect(updates).toContain('id="updateCheckBtn"');
expect(updates).not.toContain('id="appSettingsClaudeMdPath"');
expect(rail[rail.length - 1]).toBe('settings-system');
expect(order[order.length - 1]).toBe('settings-system');
const system = modal.match(/id="settings-system"([\s\S]*?)<\/section>/)?.[1] ?? '';
const version = system.indexOf('id="updateCurrentVersion"');
expect(version).toBeGreaterThan(-1);
expect(version).toBeLessThan(system.indexOf('id="appSettingsClaudeMdPath"'));
expect(system.indexOf('id="updateCheckBtn"')).toBeLessThan(system.indexOf('id="appSettingsClaudeMdPath"'));
expect(system).toContain('id="appSettingsClaudeMdPath"');
expect(system).toContain('id="appSettingsTunnelEnabled"');
});
it('keeps Local Echo the first row of the second section', () => {