mirror of
https://github.com/Ark0N/Codeman.git
synced 2026-10-09 00:49:41 +02:00
feat: skill fast-path hardening, lineage retune + colors, per-tab pop-out, reliable tab alerts
- SKILL.md: forbid the standalone preamble check and pre-spawn recon turns (measured: two wasted model turns cost ~12s of a 28s two-worker run; the hardened flow measured 20.2s cold / 12.8s warm end to end) - Lineage lines: dip now hangs from the strip's bottom edge (cap 104 -> 64, no stacked row offsets), fixing the deep bow in wrapped strips and keeping row-1 arcs off row-2 tab labels; per-child color palette (skin blue first, then matrix green, pink, violet, red, turquoise, orange) via an inline --lineage-color custom property - Session Options -> Session: per-TAB pop-out (open-in-window) button override on top of the general showTabDetachButton setting; per-device localStorage map rendered as the tab-show-detach class - Tab alerts: seed the pending-hook state machine from GET /api/approvals regardless of the approvals-inbox setting (reloads used to lose the red tab entirely with the inbox off), clear unconditionally on approval_resolved, and repaint the alert as a steady red/yellow ring + glow + status dot on a ::before overlay so it stays visible on the selected (active) tab until the permission is actually resolved - docs: worker warm-pool design sketch (verified numbers baked in) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -37,13 +37,21 @@ Object.assign(CodemanApp.prototype, {
|
||||
async seedApprovals() {
|
||||
if (!this.approvals) this.approvals = new Map();
|
||||
this.approvals.clear();
|
||||
if (this.approvalsInboxEnabled()) {
|
||||
const data = await this._apiJson('/api/approvals');
|
||||
for (const item of (data && data.approvals) || []) {
|
||||
this.approvals.set(item.id, item);
|
||||
// Re-arm the tab alert state machine (idempotent set-add).
|
||||
this.setPendingHook(item.sessionId, approvalKindToHook(item.kind));
|
||||
}
|
||||
// ⚠ Fetch and re-arm the tab-alert state machine REGARDLESS of the inbox
|
||||
// setting. The server-side approval store runs unconditionally (only the
|
||||
// inbox SURFACES are opt-in), and the red/yellow tab alert predates the
|
||||
// inbox: gating the seed on the setting meant that with the inbox off, a
|
||||
// reload landed with every alert store empty while a permission dialog sat
|
||||
// blocking a session (owner report 2026-08-15: rail said NEEDS YOU from
|
||||
// the live SSE event, the reloaded-elsewhere tab showed a plain green
|
||||
// dot). Only populating `this.approvals` (bell/drawer/answer strips) stays
|
||||
// behind the setting.
|
||||
const data = await this._apiJson('/api/approvals');
|
||||
const inboxOn = this.approvalsInboxEnabled();
|
||||
for (const item of (data && data.approvals) || []) {
|
||||
if (inboxOn) this.approvals.set(item.id, item);
|
||||
// Re-arm the tab alert state machine (idempotent set-add).
|
||||
this.setPendingHook(item.sessionId, approvalKindToHook(item.kind));
|
||||
}
|
||||
this.renderApprovals();
|
||||
},
|
||||
@@ -68,14 +76,15 @@ Object.assign(CodemanApp.prototype, {
|
||||
},
|
||||
|
||||
_onApprovalResolved(info) {
|
||||
if (!info || !info.id || !this.approvals) return;
|
||||
if (this.approvals.delete(info.id)) {
|
||||
// Clear the matching tab alert: the inbox resolves on more signals than
|
||||
// the hook handlers do (superseded, expired, answered from another
|
||||
// device), and clearPendingHooks is a no-op when nothing is set.
|
||||
this.clearPendingHooks(info.sessionId, approvalKindToHook(info.kind));
|
||||
this.renderApprovals();
|
||||
}
|
||||
if (!info || !info.id) return;
|
||||
// Clear the matching tab alert UNCONDITIONALLY: the inbox resolves on more
|
||||
// signals than the hook handlers do (superseded, expired, answered from
|
||||
// another device), clearPendingHooks is a no-op when nothing is set, and
|
||||
// with the inbox setting OFF the item was never stored in `this.approvals`
|
||||
// even though seedApprovals armed the alert — gating the clear on a map hit
|
||||
// would strand that alert forever.
|
||||
this.clearPendingHooks(info.sessionId, approvalKindToHook(info.kind));
|
||||
if (this.approvals?.delete(info.id)) this.renderApprovals();
|
||||
},
|
||||
|
||||
// ─── Actions ─────────────────────────────────────────────────
|
||||
|
||||
Reference in New Issue
Block a user