fix(remote): merge-time fixes for Wake-on-LAN

The MAC-count limit lived in two places that disagreed. RemoteHostSchema.wakeMac's
128-character cap admits seven comma-separated MACs while parseMacList takes at most
four, all-or-nothing, so a five-MAC value validated, was written to remote-hosts.json,
and then resolved to NO wake target: POST /api/sessions/:id/wake answered
"No wake-on-LAN target configured for this host" and the banner offered "Configure WoL"
for a host the user had just configured. MAX_WAKE_MACS now lives in
src/config/remote-wake-limits.ts and both sides refine against it. Its own module
because src/remote-wake.ts is import-fenced to session-routes.ts and server.ts (the
wiring guard that stops a watcher waking a host), and because schemas.ts must not drag
dgram/net/child_process into every request-validating module.

The documented 40 s request budget also omitted the wake's own cost. A `command` target
is bounded by REMOTE_WAKE_COMMAND_TIMEOUT_MS and runs BEFORE the readiness poll, so a
slow one pushed a wakeCommand host's worst case to ~68 s, past the 60 s
proxy_read_timeout the budget exists to stay under. _wakeAndWait now subtracts the
wake's measured elapsed time from the readiness budget, floored at one poll interval so
a wake that ate the whole budget still gets one probe. A magic packet is effectively
instant and is unaffected, which is why live testing never saw it.

Also: the two new endpoints are documented in docs/api-reference.md with the import
fence stated as the rule it is, CLAUDE.md's frontend module count moves to 34, and the
release changesets carry the Thanks section.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Codeman maintainer
2026-09-19 12:18:40 +02:00
parent 4c705094f7
commit 035bfbc2fe
8 changed files with 176 additions and 9 deletions
+23
View File
@@ -0,0 +1,23 @@
/**
* @fileoverview Limits shared between Wake-on-LAN parsing and its request schema.
*
* Its own module because `src/remote-wake.ts` is import-fenced: only
* `web/routes/session-routes.ts` and `web/server.ts` may import it, so that no
* watcher or boot-recovery path can WAKE a host (pinned by the wiring guard in
* `test/remote-wake.test.ts`). `web/schemas.ts` needs the same MAC-count limit and
* must not become a third importer, and it would drag `dgram`/`net`/`child_process`
* into every module that validates a request body. A plain constant satisfies both.
*/
/**
* How many comma-separated MACs one `wakeMac` may carry.
*
* ⚠ Single source for `parseMacList()` and `RemoteHostSchema.wakeMac`. The two used
* to disagree: the schema's 128-character cap admits seven MACs while the parser
* rejected more than four all-or-nothing, so a five-MAC value validated, persisted to
* `remote-hosts.json`, and then resolved to NO wake target. The host read as
* unconfigured and the banner offered "Configure WoL" for a host the user had just
* configured, which is the worst shape a validation gap can take: accepted, stored,
* silently inert.
*/
export const MAX_WAKE_MACS = 4;